[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Dev: Creating a task without any replies disappears from LHN when navigating to other report.

@esh-g

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Create a chat.
Create a task.
Click on another Option in LHN

Expected Result:

The task should stay there

Actual Result:

The task disappears from LHN even when the user is assigned.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.36-4 [THIS IS ONLY OCCURING ON DEV]
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-05.at.12.30.40.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688497160874409

View all open jobs on GitHub

@maddylewis

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Newly created Task's get's hidden id not commented.

What is the root cause of that problem?

shouldReportBeInOptionList function return's false when a thread is not commented and as a task is treated as thread, its causing the issues in report's list which are provided by getOrderedReportIDs function.

What changes do you think we should make in order to solve the problem?

We should check if the thread is a Task then don't hide the report.

App/src/libs/ReportUtils.js

Lines 2022 to 2024 in cb7988c

    
           if (isThread(report) && !report.lastMessageText) { 
        
               return false; 
        
           }

Like this:

if (isThread(report) && !report.lastMessageText && !isTaskReport(report)) {

What alternative solutions did you explore? (Optional)

N/A

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Hide only chat threads that haven't been commented on #22349

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@maddylewis

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[] The PR that introduced the bug has been identified. Link to the PR:
[] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[] Determine if we should create a regression test for this bug.
[] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@esh-g

i think im only issuing payment for the reporting bonus to @esh-g

asked about this here - #22300 (comment)

dupe!

@maddylewis

@maddylewis I mentioned that this issue was opened before that issue here: #22300 (comment) What I meant was that issue was a dupe. And this is original. Sorry for not being clear

Navigation Menu

Repository navigation

[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Dev: Creating a task without any replies disappears from LHN when navigating to other report. #22294

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (isThread(report) && !report.lastMessageText) {
	return false;
	}

[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Dev: Creating a task without any replies disappears from LHN when navigating to other report. #22294

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jul 5, 2023

melvin-bot commented on Jul 5, 2023

Bug0 Triage Checklist (Main S/O)

jeet-dhandha commented on Jul 5, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jul 6, 2023

melvin-bot commented on Jul 7, 2023

melvin-bot commented on Jul 7, 2023

melvin-bot commented on Jul 7, 2023

melvin-bot commented on Jul 10, 2023

melvin-bot commented on Jul 10, 2023

maddylewis commented on Jul 17, 2023

maddylewis commented on Jul 17, 2023

maddylewis commented on Jul 17, 2023

esh-g commented on Jul 18, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions