[HOLD for payment 2023-09-07] Make animations within RHP consistent and reliable

Problem

Navigating between flows in RHP does not have animations. For exmaple if you go from search to new Group using shortcuts or if you navigate to new money request confirmation modal and then you click on details of the recipient there is no animation for the User details page in RHP.

Screen.Recording.2023-07-07.at.1.16.40.AM.mov

Solution

Lets make this animations consistent, everytime we push, replace or pop a page within RHP no matter what flow they are at, lets have the same slide in and out animation.

@flaviadefaria

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@WoLewicki

@WoLewicki @adamgrzybowski this will be our next one to tackle after the remounting issue.

@flaviadefaria no need to act on this one, making it weekly, SWM will handle this

This should be partially solved by #22437

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[navigation-refactor] Style based approach for the three pane layout #22437

If no regressions arise, payment will be issued on 2023-09-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@mountiny

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mountiny] Determine if we should create a regression test for this bug.
[@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@mountiny

@mountiny just catching up, do I need to take any action at all here?

I think this is fine and we can handle the payments here #20404

Also we would make more specific issue for the animation as this is an old issue just for clarity, deployed going to close this out

Navigation Menu

Repository navigation

[HOLD for payment 2023-09-07] Make animations within RHP consistent and reliable #22372

Problem

Solution

Bug0 Triage Checklist (Main S/O)

10 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-09-07] Make animations within RHP consistent and reliable #22372

Description

Problem

Solution

Activity

melvin-bot commented on Jul 6, 2023

melvin-bot commented on Jul 6, 2023

Bug0 Triage Checklist (Main S/O)

mountiny commented on Jul 6, 2023

mountiny commented on Jul 10, 2023

10 remaining items

melvin-bot commented on Aug 31, 2023

melvin-bot commented on Aug 31, 2023

melvin-bot commented on Aug 31, 2023

flaviadefaria commented on Sep 4, 2023

mountiny commented on Sep 4, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions