Skip to content

[HOLD for payment 2023-07-17] [$1000] Dev: After creating a task without assignee “0” displayed #22398

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a chat
  2. Go to the “Assign task”
  3. Enter title click on “Confirm task”

Expected Result:

After creating a task without assignee “0” should not be displayed

Actual Result:

After creating a task without assignee “0” displayed after leaving

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.37-5
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-07.at.2.08.21.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688677922284949

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0128bb3b4ad89ce372
  • Upwork Job ID: 1677273013757554688
  • Last Price Increase: 2023-07-07

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 7, 2023
  2. melvin-bot commented on Jul 7, 2023

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 7, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Jul 7, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Jul 7, 2023

    @melvin-bot

    Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. Julesssss commented on Jul 7, 2023

    @Julesssss
    Contributor

    FYI I kicked off the release less than 5 minutes ago and I'm worried the existence of a new deploy blocker will cause issues. I'll re-add it once the new checklist is up!

  7. situchan commented on Jul 7, 2023

    @situchan
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    After creating task without assignee, "0" is displayed

    What is the root cause of that problem?

    Issue happens on this line:

    {assigneeAccountID && assigneeAccountID > 0 && (

    assigneeAccountID is number and when no assignee, this fallbacks to 0.
    And 0 && 0 > 0 && <></> returns 0

    What changes do you think we should make in order to solve the problem?

    remove this redundant condition: assigneeAccountID &&

    Fixed code will look like this:

     {assigneeAccountID > 0 && (
    
  8. 36 remaining items

  9. changed the title [-][$1000] Dev: After creating a task without assignee “0” displayed[/-] [+][HOLD for payment 2023-07-17] [$1000] Dev: After creating a task without assignee “0” displayed[/+] on Jul 10, 2023
  10. melvin-bot commented on Jul 10, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jul 10, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-07-17. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  12. melvin-bot commented on Jul 10, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@aimane-chnaif] Determine if we should create a regression test for this bug.
    • [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. MitchExpensify commented on Jul 11, 2023

    @MitchExpensify
    Contributor

    Reminder set to pay out on 7/17 👍

    Lets square off the BZ steps above in advance of that @aimane-chnaif 🚀

  14. MitchExpensify commented on Jul 17, 2023

    @MitchExpensify
    Contributor

    Payments issued! Friendly bump on @aimane-chnaif on the BZ steps :)

  15. MitchExpensify commented on Jul 20, 2023

    @MitchExpensify
    Contributor

    friendly bump @aimane-chnaif 👍

  16. aimane-chnaif commented on Jul 20, 2023

    @aimane-chnaif
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    No need regression test step. It's already in checklist:

    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  17. MitchExpensify commented on Jul 21, 2023

    @MitchExpensify
    Contributor

    Awesome, thank you @aimane-chnaif !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions