You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-17] [$1000] Dev: After creating a task without assignee “0” displayed #22398
After creating a task without assignee “0” should not be displayed
Actual Result:
After creating a task without assignee “0” displayed after leaving
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.37-5 Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
FYI I kicked off the release less than 5 minutes ago and I'm worried the existence of a new deploy blocker will cause issues. I'll re-add it once the new checklist is up!
changed the title [-][$1000] Dev: After creating a task without assignee “0” displayed[/-][+][HOLD for payment 2023-07-17] [$1000] Dev: After creating a task without assignee “0” displayed[/+]on Jul 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
No need regression test step. It's already in checklist:
I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
Activity
melvin-bot commentedon Jul 7, 2023
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 7, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Jul 7, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 7, 2023
Triggered auto assignment to @MariaHCD (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Julesssss commentedon Jul 7, 2023
FYI I kicked off the release less than 5 minutes ago and I'm worried the existence of a new deploy blocker will cause issues. I'll re-add it once the new checklist is up!
situchan commentedon Jul 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
After creating task without assignee, "0" is displayed
What is the root cause of that problem?
Issue happens on this line:
App/src/components/TaskHeader.js
Line 83 in 0ee7dfa
assigneeAccountIDis number and when no assignee, this fallbacks to 0.And
0 && 0 > 0 && <></>returns 0What changes do you think we should make in order to solve the problem?
remove this redundant condition:
assigneeAccountID &&Fixed code will look like this:
36 remaining items
[-][$1000] Dev: After creating a task without assignee “0” displayed[/-][+][HOLD for payment 2023-07-17] [$1000] Dev: After creating a task without assignee “0” displayed[/+]melvin-bot commentedon Jul 10, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jul 10, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
MitchExpensify commentedon Jul 11, 2023
Reminder set to pay out on 7/17 👍
Lets square off the BZ steps above in advance of that @aimane-chnaif 🚀
MitchExpensify commentedon Jul 17, 2023
Payments issued! Friendly bump on @aimane-chnaif on the BZ steps :)
MitchExpensify commentedon Jul 20, 2023
friendly bump @aimane-chnaif 👍
aimane-chnaif commentedon Jul 20, 2023
No need regression test step. It's already in checklist:
myBool && <MyComponent />.MitchExpensify commentedon Jul 21, 2023
Awesome, thank you @aimane-chnaif !