You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-26] [$1000] Dev: Web - Console error on click of Connect online with Plaid button #22448
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Dev 1.3.37-6 Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
Console error when connecting plaid
What is the root cause of that problem?
We're not wrapping the BankAccountPlaidStep component inside the withLocalize HoC and instead we are using the useLocalize hook. Despite this, we are still using the props that get injected only when using the HoC.
What changes do you think we should make in order to solve the problem?
We should remove the withLocalizePropTypes from the props.
What alternative solutions did you explore? (Optional)
We should wrap the BankAccountPlaidStep component inside the withLocalize Hoc and remove the usage of useLocalize hook.
changed the title [-]Dev: Web - Console error on click of Connect online with Plaid button[/-][+][$1000] Dev: Web - Console error on click of Connect online with Plaid button[/+]on Jul 8, 2023
changed the title [-][$1000] Dev: Web - Console error on click of Connect online with Plaid button[/-][+][HOLD for payment 2023-07-26] [$1000] Dev: Web - Console error on click of Connect online with Plaid button[/+]on Jul 19, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-26. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jul 7, 2023
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 7, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)allroundexperts commentedon Jul 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Console error when connecting plaid
What is the root cause of that problem?
We're not wrapping the
BankAccountPlaidStepcomponent inside thewithLocalizeHoC and instead we are using theuseLocalizehook. Despite this, we are still using the props that get injected only when using the HoC.What changes do you think we should make in order to solve the problem?
We should remove the
withLocalizePropTypesfrom the props.What alternative solutions did you explore? (Optional)
We should wrap the
BankAccountPlaidStepcomponent inside thewithLocalizeHoc and remove the usage ofuseLocalizehook.greg-schroeder commentedon Jul 8, 2023
I can't reproduce this ... I think it's Dev only? Will ask C+ to help
[-]Dev: Web - Console error on click of Connect online with Plaid button[/-][+][$1000] Dev: Web - Console error on click of Connect online with Plaid button[/+]melvin-bot commentedon Jul 8, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01422f8298b6001281
melvin-bot commentedon Jul 8, 2023
Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Jul 8, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)14 remaining items
[-][$1000] Dev: Web - Console error on click of Connect online with Plaid button[/-][+][HOLD for payment 2023-07-26] [$1000] Dev: Web - Console error on click of Connect online with Plaid button[/+]melvin-bot commentedon Jul 19, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 19, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-26. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jul 19, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
greg-schroeder commentedon Jul 26, 2023
Okay so this was a regression and is being handled here (payments, etc.): #16242
gadhiyamanan commentedon Jul 26, 2023
@greg-schroeder i think reporting bonus should be done here, right?
greg-schroeder commentedon Jul 26, 2023
Ye, but the C/C+ are in the other issue. You have an offer for reporting in Upwork.
gadhiyamanan commentedon Jul 26, 2023
@greg-schroeder i do not have any offer for reporting
greg-schroeder commentedon Jul 26, 2023
Woops, I sent it the wrong person. Fixed.
gadhiyamanan commentedon Jul 26, 2023
@greg-schroeder offer Accepted, Thanks!