Skip to content

[HOLD for payment 2023-07-26] [$1000] Dev: Web - Console error on click of Connect online with Plaid button #22448

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create workspace if not created
  2. Go to settings > Workspaces >Connect bank account
  3. Click on Connect online with Plaid button

Expected Result:

Should not show any console error

Actual Result:

Multiple console error appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev 1.3.37-6
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-07.at.3.38.44.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688724565368739

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01422f8298b6001281
  • Upwork Job ID: 1677488790826577920
  • Last Price Increase: 2023-07-08

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 7, 2023
  2. melvin-bot commented on Jul 7, 2023

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 7, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. allroundexperts commented on Jul 7, 2023

    @allroundexperts
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Console error when connecting plaid

    What is the root cause of that problem?

    We're not wrapping the BankAccountPlaidStep component inside the withLocalize HoC and instead we are using the useLocalize hook. Despite this, we are still using the props that get injected only when using the HoC.

    What changes do you think we should make in order to solve the problem?

    We should remove the withLocalizePropTypes from the props.

    What alternative solutions did you explore? (Optional)

    We should wrap the BankAccountPlaidStep component inside the withLocalize Hoc and remove the usage of useLocalize hook.

  5. greg-schroeder commented on Jul 8, 2023

    @greg-schroeder
    Contributor

    I can't reproduce this ... I think it's Dev only? Will ask C+ to help

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 8, 2023
  7. changed the title [-]Dev: Web - Console error on click of Connect online with Plaid button[/-] [+][$1000] Dev: Web - Console error on click of Connect online with Plaid button[/+] on Jul 8, 2023
  8. melvin-bot commented on Jul 8, 2023

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 8, 2023
  10. melvin-bot commented on Jul 8, 2023

    @melvin-bot

    Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

  11. melvin-bot commented on Jul 8, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

  12. 14 remaining items

  13. changed the title [-][$1000] Dev: Web - Console error on click of Connect online with Plaid button[/-] [+][HOLD for payment 2023-07-26] [$1000] Dev: Web - Console error on click of Connect online with Plaid button[/+] on Jul 19, 2023
  14. melvin-bot commented on Jul 19, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jul 19, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-07-26. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. melvin-bot commented on Jul 19, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
    • [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@allroundexperts] Determine if we should create a regression test for this bug.
    • [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. greg-schroeder commented on Jul 26, 2023

    @greg-schroeder
    Contributor

    Okay so this was a regression and is being handled here (payments, etc.): #16242

  18. gadhiyamanan commented on Jul 26, 2023

    @gadhiyamanan
    Contributor

    @greg-schroeder i think reporting bonus should be done here, right?

  19. greg-schroeder commented on Jul 26, 2023

    @greg-schroeder
    Contributor

    Ye, but the C/C+ are in the other issue. You have an offer for reporting in Upwork.

  20. gadhiyamanan commented on Jul 26, 2023

    @gadhiyamanan
    Contributor

    You have an offer for reporting in Upwork.

    @greg-schroeder i do not have any offer for reporting

  21. greg-schroeder commented on Jul 26, 2023

    @greg-schroeder
    Contributor

    Woops, I sent it the wrong person. Fixed.

  22. gadhiyamanan commented on Jul 26, 2023

    @gadhiyamanan
    Contributor

    @greg-schroeder offer Accepted, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsNeeds ReproductionReproducible steps needed

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions