You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for checklist] [$1000] Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line #22453
Please re-state the problem that we are trying to solve in this issue.
Android truncating the last character of the text before adding ....
What is the root cause of that problem?
The root cause of the issue is that the Text wrapped inside Flex View is not taking on the full width on Android when number of lines is restricted. This can be seen here.
What changes do you think we should make in order to solve the problem?
changed the title [-]Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line[/-][+][$1000] Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line[/+]on Jul 11, 2023
@allroundexperts is a on NewDot payment beta, @narefyev91 is Call Stack, and the issue reporter was Applause. So, no payments actually need to be made via Upwork here. 🎉
changed the title [-][HOLD for payment 2023-07-24] [$1000] Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line[/-][+][HOLD for checklist] [$1000] Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line[/+]on Jul 24, 2023
The issue existed since Tasks were implemented. As such, there isn't a particular PR to point to here.
N/A
Apart from more thorough PR testing, I don't think there is anything else we could have done here. Slack discussion is not required as additional checklist items are not needed here.
This was really hard to spot. I don't think it has any effect on the user experience. A regression test would be overkill here.
cc @greg-schroeder let me know if you disagree with the last point.
Activity
melvin-bot commentedon Jul 7, 2023
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 7, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)c3024 commentedon Jul 8, 2023
When the description is too long, we show ellipsis. This appears fine, doesn't it?
allroundexperts commentedon Jul 8, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android truncating the last character of the text before adding
....What is the root cause of that problem?
The root cause of the issue is that the
Textwrapped insideFlex Viewis not taking on the full width on Android when number of lines is restricted. This can be seen here.What changes do you think we should make in order to solve the problem?
We just need to add
flex: 1here.What alternative solutions did you explore? (Optional)
None
Christinadobrzyn commentedon Jul 10, 2023
Looks like a dupe of - #21825 (comment) asking
allroundexperts commentedon Jul 10, 2023
I don't think these are related but good to get more eyes here!
Christinadobrzyn commentedon Jul 11, 2023
You're right @allroundexperts - not related!
I can only reproduce this on Android App:
adding external
[-]Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line[/-][+][$1000] Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line[/+]melvin-bot commentedon Jul 11, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01f634e6d328dcb7fb
32 remaining items
greg-schroeder commentedon Jul 24, 2023
@allroundexperts is a on NewDot payment beta, @narefyev91 is Call Stack, and the issue reporter was Applause. So, no payments actually need to be made via Upwork here. 🎉
Just need the checklist completed @narefyev91!
FYI: Payment should be $1500 for standard payment + speed bonus of $500
[-][HOLD for payment 2023-07-24] [$1000] Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line[/-][+][HOLD for checklist] [$1000] Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line[/+]greg-schroeder commentedon Jul 26, 2023
Waiting for checklist
greg-schroeder commentedon Jul 31, 2023
@narefyev91 / @allroundexperts can anyone take care of this checklist so we can close this out?
allroundexperts commentedon Aug 1, 2023
Checklist
cc @greg-schroeder let me know if you disagree with the last point.
greg-schroeder commentedon Aug 1, 2023
hmm. I think you're right. It seems a bit too niche to be added as a recurring test in this manner. Appreciate your help with the checklist :)
JmillsExpensify commentedon Aug 2, 2023
Reviewed details for @allroundexperts. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.