Skip to content

[HOLD for checklist] [$1000] Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line #22453

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #21553

Action Performed:

  1. Login to ND
  2. Click on + icon and select Assign task option
  3. Enter title and description(with multiple line ~30line)
  4. Click on the Next button

Expected Result:

The information entered in the second line should be displayed correctly without 3 dots. All other apps don't show the 3 dots

Actual Result:

When entering numbers on each line, 3 dots will be displayed on the second line

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.38.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

21553.Android.1.mp4

21553 android photo

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f634e6d328dcb7fb
  • Upwork Job ID: 1678879714211528704
  • Last Price Increase: 2023-07-11

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 7, 2023
  2. melvin-bot commented on Jul 7, 2023

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 7, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. c3024 commented on Jul 8, 2023

    @c3024
    Contributor

    When the description is too long, we show ellipsis. This appears fine, doesn't it?

  5. allroundexperts commented on Jul 8, 2023

    @allroundexperts
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Android truncating the last character of the text before adding ....

    What is the root cause of that problem?

    The root cause of the issue is that the Text wrapped inside Flex View is not taking on the full width on Android when number of lines is restricted. This can be seen here.

    What changes do you think we should make in order to solve the problem?

    We just need to add flex: 1 here.

    What alternative solutions did you explore? (Optional)

    None

  6. Christinadobrzyn commented on Jul 10, 2023

    @Christinadobrzyn
    Contributor

    Looks like a dupe of - #21825 (comment) asking

  7. allroundexperts commented on Jul 10, 2023

    @allroundexperts
    Contributor

    I don't think these are related but good to get more eyes here!

  8. Christinadobrzyn commented on Jul 11, 2023

    @Christinadobrzyn
    Contributor

    You're right @allroundexperts - not related!

    I can only reproduce this on Android App:

    image

    adding external

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 11, 2023
  10. changed the title [-]Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line[/-] [+][$1000] Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line[/+] on Jul 11, 2023
  11. melvin-bot commented on Jul 11, 2023

    @melvin-bot
  12. 32 remaining items

  13. greg-schroeder commented on Jul 24, 2023

    @greg-schroeder
    Contributor

    @allroundexperts is a on NewDot payment beta, @narefyev91 is Call Stack, and the issue reporter was Applause. So, no payments actually need to be made via Upwork here. 🎉

    Just need the checklist completed @narefyev91!

    FYI: Payment should be $1500 for standard payment + speed bonus of $500

  14. changed the title [-][HOLD for payment 2023-07-24] [$1000] Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line[/-] [+][HOLD for checklist] [$1000] Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line[/+] on Jul 24, 2023
  15. greg-schroeder commented on Jul 26, 2023

    @greg-schroeder
    Contributor

    Waiting for checklist

  16. greg-schroeder commented on Jul 31, 2023

    @greg-schroeder
    Contributor

    @narefyev91 / @allroundexperts can anyone take care of this checklist so we can close this out?

  17. allroundexperts commented on Aug 1, 2023

    @allroundexperts
    Contributor

    Checklist

    1. The issue existed since Tasks were implemented. As such, there isn't a particular PR to point to here.
    2. N/A
    3. Apart from more thorough PR testing, I don't think there is anything else we could have done here. Slack discussion is not required as additional checklist items are not needed here.
    4. This was really hard to spot. I don't think it has any effect on the user experience. A regression test would be overkill here.

    cc @greg-schroeder let me know if you disagree with the last point.

  18. greg-schroeder commented on Aug 1, 2023

    @greg-schroeder
    Contributor

    hmm. I think you're right. It seems a bit too niche to be added as a recurring test in this manner. Appreciate your help with the checklist :)

  19. JmillsExpensify commented on Aug 2, 2023

    @JmillsExpensify
    Contributor

    Reviewed details for @allroundexperts. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions