Skip to content

[HOLD for payment 2023-08-17] [Snyk] Fix for 1 vulnerabilities #22463

Closed

Description

@melvin-bot

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 768/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS)
SNYK-JS-SEMVER-3247795
Yes Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: @storybook/addon-essentials The new version differs by 250 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b12b4a3857910782
  • Upwork Job ID: 1677517705638334464
  • Last Price Increase: 2023-07-08

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Jul 8, 2023
  2. melvin-bot commented on Jul 8, 2023

    @melvin-bot
    Author

    This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

        C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
        - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
        - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
        - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
        - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.
    
  3. melvin-bot commented on Jul 8, 2023

    @melvin-bot
    Author
  4. melvin-bot commented on Jul 8, 2023

    @melvin-bot
    Author

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

  5. melvin-bot commented on Jul 31, 2023

    @melvin-bot
    Author

    This issue has not been updated in over 15 days. @abdulrahuman5196 eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  6. abdulrahuman5196 commented on Aug 3, 2023

    @abdulrahuman5196
    Contributor

    I will close it over this weekend

  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 8, 2023
  8. melvin-bot commented on Aug 8, 2023

    @melvin-bot
    Author

    Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  9. 1 remaining item

  10. srikarparsi commented on Aug 8, 2023

    @srikarparsi
    Contributor

    Hey @tjferriss! We need to pay @abdulrahuman5196 for reviewing a PR. @abdulrahuman5196 decided to create a new PR since there were merge conflicts but I believe the compensation remains the same.

  11. tjferriss commented on Aug 9, 2023

    @tjferriss
    Contributor

    @abdulrahuman5196 can you please apply to the Upworks job here: https://www.upwork.com/jobs/~0142f9e7244cf14d69

  12. abdulrahuman5196 commented on Aug 9, 2023

    @abdulrahuman5196
    Contributor

    @tjferriss applied for the mentioned upwork

  13. tjferriss commented on Aug 10, 2023

    @tjferriss
    Contributor

    The offer has been sent

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 10, 2023
  15. changed the title [-][Snyk] Fix for 1 vulnerabilities[/-] [+][HOLD for payment 2023-08-17] [Snyk] Fix for 1 vulnerabilities[/+] on Aug 10, 2023
  16. melvin-bot commented on Aug 10, 2023

    @melvin-bot
    Author

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-17. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter NA
    • Contributor that fixed the issue NA
    • Contributor+ that helped on the issue and/or PR @abdulrahuman5196 $1000

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  17. melvin-bot commented on Aug 10, 2023

    @melvin-bot
    Author

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
    • [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@abdulrahuman5196] Determine if we should create a regression test for this bug.
    • [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  18. abdulrahuman5196 commented on Aug 12, 2023

    @abdulrahuman5196
    Contributor

    No BZ checklist, since this is a Synk PR merge for version updates.

  19. tjferriss commented on Aug 23, 2023

    @tjferriss
    Contributor

    The payment has been sent via Upworks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions