Skip to content

[HOLD for payment 2023-08-07] [$1000] Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section. #22560

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the "Settings" page.
  2. Navigate to the "Profile" section.
  3. Access the "Pronouns" subsection.
  4. Enter an invalid pronoun and observe that the "No result found" error is displayed below the input field with a padding of 20px, while on all other pages the padding does not exceed 12px.

Expected Result:

The padding above the "No result found" error should be consistent with other pages, set to 12px

Actual Result:

The padding above the "No result found" error is 20px.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.38-3
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug.10.mp4

Screenshot 2023-07-10 at 21 48 43

Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688976013859439

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01258e7c1b59f26cff
  • Upwork Job ID: 1682352401511223296
  • 2023-07-21
  • Automatic offers:
    • | | 0
    • | | 0
    • | | 0

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 10, 2023
  2. melvin-bot commented on Jul 10, 2023

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 10, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. DanutGavrus commented on Jul 10, 2023

    @DanutGavrus
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section.

    What is the root cause of that problem?

    In some places, we are using SelectionListRadio and in others, we are using the OptionsSelector.

    1. SelectionListRadio uses BaseSelectionListRadio which has styles.ph5, styles.pv5(20px padding up down left & right):
      {shouldShowTextInput && (
      <View style={[styles.ph5, styles.pv5]}>
      <TextInput
      ref={textInputRef}
      label={props.textInputLabel}
      value={props.textInputValue}
      placeholder={props.textInputPlaceholder}
      maxLength={props.textInputMaxLength}
      onChangeText={props.onChangeText}
      keyboardType={props.keyboardType}
      selectTextOnFocus
      />
      </View>
      )}
    2. OptionsSelector uses BaseOptionsSelector which has both styles.ph5, styles.pv5(same as above) and styles.ph5, styles.pb3(20px left & right, 12px bottom, 0px top):
      <View style={[styles.flexGrow1, styles.flexShrink1, styles.flexBasisAuto]}>
      {this.props.shouldTextInputAppearBelowOptions ? (
      <>
      <View style={[styles.flexGrow0, styles.flexShrink1, styles.flexBasisAuto, styles.w100, styles.flexRow]}>{optionsList}</View>
      <View style={this.props.shouldUseStyleForChildren ? [styles.ph5, styles.pv5, styles.flexGrow1, styles.flexShrink0] : []}>
      {this.props.children}
      {this.props.shouldShowTextInput && textInput}
      </View>
      </>
      ) : (
      <>
      <View style={this.props.shouldUseStyleForChildren ? [styles.ph5, styles.pb3] : []}>
      {this.props.children}
      {this.props.shouldShowTextInput && textInput}
      </View>
      {optionsList}
      </>
      )}
      </View>

      Inconsistency comes from using both View style={this.props.shouldUseStyleForChildren ? [styles.ph5, styles.pv5... at line 354 & <View style={this.props.shouldUseStyleForChildren ? [styles.ph5, styles.pb3... at line 361.

    What changes do you think we should make in order to solve the problem?

    1. Decide if we want to keep styles.ph5, styles.pv5 or styles.ph5, styles.pb3 in all 3 places, but I think styles.ph5, styles.pv5 should be the one as it appears in 2 out of 3 places;
    2. If we keep first option, we'll update line 361 to also use styles.ph5, styles.pv5;
    3. Quickly check all 9 OptionsSelector appearances before & after to make sure it still looks good.

    If we decide to keep the other one, we'll update the other 2 places accordingly.

  5. Pujan92 commented on Jul 10, 2023

    @Pujan92
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Padding inconsistency for search input and list between SelectionListRadio & OptionsSelector.

    What is the root cause of that problem?

    In the SelectionListRadio we are giving the padding of 20px for each side of text input View whereas for OptionsSelector giving 20px horizontally and 12px from bottom.

    <View style={[styles.ph5, styles.pv5]}>

    What changes do you think we should make in order to solve the problem?

    We can provide the same padding for SelectionListRadio like OptionsSelector with [styles.ph5, styles.pb3] here.

    <View style={[styles.ph5, styles.pv5]}>

  6. ahmedGaber93 commented on Jul 10, 2023

    @ahmedGaber93
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section.

    What is the root cause of that problem?

    search screen use BaseOptionsSelector and has search box with padding bottom 12 px, while Pronouns use SelectionListRadio and has search box with padding bottom 20 px.

    <View style={this.props.shouldUseStyleForChildren ? [styles.ph5, styles.pb3] : []}>

    <View style={[styles.ph5, styles.pv5]}>

    What changes do you think we should make in order to solve the problem?

    we need to make consistent padding bottom for both 12 px or 20 px (or what ever we agree to do with internal developer).
    i perfer 12 px for both it seem more suitable.

    What alternative solutions did you explore? (Optional)

    N/A

  7. hungvu193 commented on Jul 10, 2023

    @hungvu193
    Contributor

    how can you guys can text with that lighting speed, I wonder 🤣 🚀

  8. jeet-dhandha commented on Jul 10, 2023

    @jeet-dhandha
    Contributor

    Its that they found the bug. They reported it and they have the solution and they posted when the bug was posted.
    Its simple.

  9. slafortune commented on Jul 12, 2023

    @slafortune
    Contributor

    How do we know if 12 or 20px are correct? I would think all comparable box types would be the same regardless of which page they are on.

  10. slafortune commented on Jul 13, 2023

    @slafortune
    Contributor

    Let's get some design eyes to make sure!

  11. 42 remaining items

  12. changed the title [-][$1000] Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section.[/-] [+][HOLD for payment 2023-08-07] [$1000] Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section.[/+] on Jul 31, 2023
  13. melvin-bot commented on Jul 31, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jul 31, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-07. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  15. melvin-bot commented on Jul 31, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
    • [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
    • [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. slafortune commented on Aug 7, 2023

    @slafortune
    Contributor

    The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

    when @DanutGavrus got assigned: 2023-07-24 22:59:59 Z
    when the PR got merged: 2023-07-26 17:05:17 UTC

    • External issue reporter: @usmantariq96/$250 - offer sent
    • Contributor that fixed the issue: @DanutGavrus/$1500 - offer sent
    • Contributor+ that helped on the issue and/or PR: @Santhosh-Sellavel does not require payment (Eligable for Manual Requests)/$1500

    @Santhosh-Sellavel can you please complete the checklist?

  17. DanutGavrus commented on Aug 7, 2023

    @DanutGavrus
    Contributor

    @slafortune Offer accepted on Upwork!

  18. usmantariq96 commented on Aug 8, 2023

    @usmantariq96

    @slafortune offer accepted
    Thanks

  19. Santhosh-Sellavel commented on Aug 8, 2023

    @Santhosh-Sellavel
    Collaborator

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    cc: @cead22 Let me know if you differ from any of the above, thanks!

  20. Santhosh-Sellavel commented on Aug 10, 2023

    @Santhosh-Sellavel
    Collaborator

    Requested on ND

  21. JmillsExpensify commented on Aug 15, 2023

    @JmillsExpensify
    Contributor

    Reviewed the details for @Santhosh-Sellavel. Approved for payment in NewDot based on BZ summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2DesignExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions