You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-07] [$1000] Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section. #22560
Enter an invalid pronoun and observe that the "No result found" error is displayed below the input field with a padding of 20px, while on all other pages the padding does not exceed 12px.
Expected Result:
The padding above the "No result found" error should be consistent with other pages, set to 12px
Actual Result:
The padding above the "No result found" error is 20px.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.38-3 Reproducible in staging?: y Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
OptionsSelector uses BaseOptionsSelector which has both styles.ph5, styles.pv5(same as above) and styles.ph5, styles.pb3(20px left & right, 12px bottom, 0px top):
Inconsistency comes from using both View style={this.props.shouldUseStyleForChildren ? [styles.ph5, styles.pv5... at line 354 & <View style={this.props.shouldUseStyleForChildren ? [styles.ph5, styles.pb3... at line 361.
What changes do you think we should make in order to solve the problem?
Decide if we want to keep styles.ph5, styles.pv5 or styles.ph5, styles.pb3 in all 3 places, but I think styles.ph5, styles.pv5 should be the one as it appears in 2 out of 3 places;
If we keep first option, we'll update line 361 to also use styles.ph5, styles.pv5;
Quickly check all 9 OptionsSelector appearances before & after to make sure it still looks good.
If we decide to keep the other one, we'll update the other 2 places accordingly.
Please re-state the problem that we are trying to solve in this issue.
Padding inconsistency for search input and list between SelectionListRadio & OptionsSelector.
What is the root cause of that problem?
In the SelectionListRadio we are giving the padding of 20px for each side of text input View whereas for OptionsSelector giving 20px horizontally and 12px from bottom.
Please re-state the problem that we are trying to solve in this issue.
Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section.
What is the root cause of that problem?
search screen use BaseOptionsSelector and has search box with padding bottom 12 px, while Pronouns use SelectionListRadio and has search box with padding bottom 20 px.
What changes do you think we should make in order to solve the problem?
we need to make consistent padding bottom for both 12 px or 20 px (or what ever we agree to do with internal developer).
i perfer 12 px for both it seem more suitable.
What alternative solutions did you explore? (Optional)
changed the title [-][$1000] Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section.[/-][+][HOLD for payment 2023-08-07] [$1000] Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section.[/+]on Jul 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A (We will have this covered already, it's been reported multiple times already)
[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
[@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
cc: @cead22 Let me know if you differ from any of the above, thanks!
Activity
melvin-bot commentedon Jul 10, 2023
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 10, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)DanutGavrus commentedon Jul 10, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section.
What is the root cause of that problem?
In some places, we are using
SelectionListRadioand in others, we are using theOptionsSelector.SelectionListRadiousesBaseSelectionListRadiowhich hasstyles.ph5, styles.pv5(20px padding up down left & right):App/src/components/SelectionListRadio/BaseSelectionListRadio.js
Lines 219 to 232 in 4f398db
OptionsSelectorusesBaseOptionsSelectorwhich has bothstyles.ph5, styles.pv5(same as above) andstyles.ph5, styles.pb3(20px left & right, 12px bottom, 0px top):App/src/components/OptionsSelector/BaseOptionsSelector.js
Lines 350 to 368 in 4f398db
Inconsistency comes from using both
View style={this.props.shouldUseStyleForChildren ? [styles.ph5, styles.pv5...at line 354 &<View style={this.props.shouldUseStyleForChildren ? [styles.ph5, styles.pb3...at line 361.What changes do you think we should make in order to solve the problem?
styles.ph5, styles.pv5orstyles.ph5, styles.pb3in all 3 places, but I thinkstyles.ph5, styles.pv5should be the one as it appears in 2 out of 3 places;styles.ph5, styles.pv5;OptionsSelectorappearances before & after to make sure it still looks good.If we decide to keep the other one, we'll update the other 2 places accordingly.
Pujan92 commentedon Jul 10, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Padding inconsistency for search input and list between
SelectionListRadio&OptionsSelector.What is the root cause of that problem?
In the
SelectionListRadiowe are giving the padding of 20px for each side of text inputViewwhereas forOptionsSelectorgiving 20px horizontally and 12px from bottom.App/src/components/SelectionListRadio/BaseSelectionListRadio.js
Line 220 in 6a7c1b2
What changes do you think we should make in order to solve the problem?
We can provide the same padding for
SelectionListRadiolikeOptionsSelectorwith[styles.ph5, styles.pb3]here.App/src/components/SelectionListRadio/BaseSelectionListRadio.js
Line 220 in 6a7c1b2
ahmedGaber93 commentedon Jul 10, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section.
What is the root cause of that problem?
search screen use
BaseOptionsSelectorand has search box with padding bottom 12 px, while Pronouns useSelectionListRadioand has search box with padding bottom 20 px.App/src/components/OptionsSelector/BaseOptionsSelector.js
Line 361 in 2e3f8c2
App/src/components/SelectionListRadio/BaseSelectionListRadio.js
Line 220 in 2e3f8c2
What changes do you think we should make in order to solve the problem?
we need to make consistent padding bottom for both 12 px or 20 px (or what ever we agree to do with internal developer).
i perfer 12 px for both it seem more suitable.
What alternative solutions did you explore? (Optional)
N/A
hungvu193 commentedon Jul 10, 2023
how can you guys can text with that lighting speed, I wonder 🤣 🚀
jeet-dhandha commentedon Jul 10, 2023
Its that they found the bug. They reported it and they have the solution and they posted when the bug was posted.
Its simple.
slafortune commentedon Jul 12, 2023
How do we know if 12 or 20px are correct? I would think all comparable box types would be the same regardless of which page they are on.
slafortune commentedon Jul 13, 2023
Let's get some design eyes to make sure!
42 remaining items
[-][$1000] Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section.[/-][+][HOLD for payment 2023-08-07] [$1000] Web – Profile – Inconsistency of padding above “No result found” error in “Pronouns” section.[/+]melvin-bot commentedon Jul 31, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jul 31, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
slafortune commentedon Aug 7, 2023
The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
when @DanutGavrus got assigned: 2023-07-24 22:59:59 Z
when the PR got merged: 2023-07-26 17:05:17 UTC
@Santhosh-Sellavel can you please complete the checklist?
DanutGavrus commentedon Aug 7, 2023
@slafortune Offer accepted on Upwork!
usmantariq96 commentedon Aug 8, 2023
@slafortune offer accepted
Thanks
Santhosh-Sellavel commentedon Aug 8, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
cc: @cead22 Let me know if you differ from any of the above, thanks!
Santhosh-Sellavel commentedon Aug 10, 2023
Requested on ND
JmillsExpensify commentedon Aug 15, 2023
Reviewed the details for @Santhosh-Sellavel. Approved for payment in NewDot based on BZ summary above.