Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to settings > security > Two factor authentication
- Observe that the next button is not highlighted or clickable unless you copy or download the codes
- Go to settings > security > Change password
- Observe that the save button is highlighted and clickable even though you didn't feed the necessary information and fix error option will show up.
- Go to settings > security > Close account
- Observe that the Confirm button is highlighted and clickable even though you didn't feed the necessary information and fix error option will show up.
Expected Result:
Button's should be clickable even though the necessary steps are not fulfilled and Fix error options should be shown up instead to keep the app consistency
Actual Result:
Button was not clickable when the necessary steps were not fulfilled and Fix error options was not shown
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
new.BR.27.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Yokabdk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689037540044139
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0137dd1f2f9d3d3972
- Upwork Job ID: 1679119869039431680
- Last Price Increase: 2023-08-18 2023-07-26
- Automatic offers:
- dukenv0307 | Contributor | 25774623
Activity
melvin-bot commentedon Jul 11, 2023
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.DanutGavrus commentedon Jul 11, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistency in the security page
What is the root cause of that problem?
Some buttons should not be disabled from the start, but right now, they are.
What changes do you think we should make in order to solve the problem?
We need to update
Two Factor Authentication Pagewhere the button starts disabled, as to be enabled & show the corresponding error if user presses on it without doing anything before. We also need to do this for any other places in which the button starts as disabled, but shouldn't(such as on theRequest Money Page).melvin-bot commentedon Jul 11, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)dukenv0307 commentedon Jul 12, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistency in the security page
What is the root cause of that problem?
We disable the button for first when we open the page
App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js
Line 48 in d6b2d07
What changes do you think we should make in order to solve the problem?
App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js
Line 133 in d6b2d07
isNextButtonDisableistrueand seterrorstate for a translation key that can confirm by design teamApp/src/pages/settings/Security/TwoFactorAuth/CodesPage.js
Line 131 in 74ae95c
errorto emptyApp/src/pages/settings/Security/TwoFactorAuth/CodesPage.js
Line 113 in 74ae95c
App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js
Line 103 in 74ae95c
styles.formError. The style and position to display error need design team to confirmWhat alternative solutions did you explore? (Optional)
NA
Result
Screencast.from.26-07-2023.00.48.01.webm
CortneyOfstad commentedon Jul 12, 2023
Was able to recreate so going to get eyes on this
[-]Inconsistency in the security page[/-][+][$1000] Inconsistency in the security page[/+]melvin-bot commentedon Jul 12, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0137dd1f2f9d3d3972
melvin-bot commentedon Jul 12, 2023
Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Jul 12, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)94 remaining items
melvin-bot commentedon Sep 25, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-02. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 25, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mvtglobally commentedon Sep 28, 2023
Issue not reproducible during KI retests. (First week)
Ollyws commentedon Oct 3, 2023
There is no PR responsible for this as it was a new feature. I do think a regression test would be helpful to ensure it continues working properly, as it includes one of the main flows and it's easy to test for.
Ollyws commentedon Oct 3, 2023
Regression Test Proposal
Do we agree 👍 or 👎
CortneyOfstad commentedon Oct 3, 2023
@dukenv0307 — you have been paid in Upwork, so you are all set!
@Ollyws and @Yokabdk — I sent you both offers in Upwork. Please let me know once you accept!
Ollyws commentedon Oct 3, 2023
@CortneyOfstad Accepted, thanks!
CortneyOfstad commentedon Oct 3, 2023
@Yokabdk Just waiting on your offer acceptance — thank you!
@shawnborton @tgolen thoughts on the regression test here? TIA!
tgolen commentedon Oct 3, 2023
They look good to me!
Yokabdk commentedon Oct 3, 2023
@CortneyOfstad offer accepted
CortneyOfstad commentedon Oct 4, 2023
Thank you @Yokabdk! I've gone ahead and gotten that paid!
I'm creating the regression test now and then we're good to close!