You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] App loses focus from concierge compose box when visiting concierge chat after connect bank step 3 #22664
Open workspaces-> any workspace-> bank account-> connect manually->fill in step 1, step 2, step 3 details and continue
On passport page, click on question mark icon in header
Click on chat with concierge and observe that app does not focus on compose box
Open any other report and observe that app does not focus on any compose box anymore
Expected Result:
App should focus on compose box of concierge chat if we visit the chat from 'Chat with concierge' option from workspace help
Actual Result:
App does not focus on compose box of concierge chat if we visit the chat from 'Chat with concierge' option from workspace help after step 3 of connect bank account
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.39-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
I think that this happens anytime you click on an in-app link directing you to Concierge, since I was able to reproduce this by going to Settings > Account > Report a bug.
changed the title [-]App loses focus from concierge compose box when visiting concierge chat after connect bank step 3[/-][+][$1000] App loses focus from concierge compose box when visiting concierge chat after connect bank step 3[/+]on Jul 11, 2023
Please re-state the problem that we are trying to solve in this issue.
App loses focus from concierge compose box when visiting concierge chat after connect bank step 3
What is the root cause of that problem?
When navigating to concierge chat from RHP, we don't dismiss modal before doing it so in Onyx, modal keeps isVisibletrue => shouldAutoFocus on ReportActionComposer is false
When we use composer actions, emoji picker, context menu action and close it, we check if prevProps.modal.isVisible && !this.props.modal.isVisible => focus.
When we open RHP from a report and back to that report, same as 2.
What changes do you think we should make in order to solve the problem?
We can use Navigation.dismissModal(conciergeChatReportID) instead of navigate methods. In most of the cases we are navigating to concierge from RHP so it's safe to use.
Or we can add a check if previous stack is RHP then dismiss modal else navigate like this
@sakluger@abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
throw whatever you want on that tracking issue that's what it's for. no one is assigned to it though so not much is going to get done with it until someone picks it up.
Activity
melvin-bot commentedon Jul 11, 2023
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 11, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)sakluger commentedon Jul 11, 2023
I think that this happens anytime you click on an in-app link directing you to Concierge, since I was able to reproduce this by going to Settings > Account > Report a bug.
[-]App loses focus from concierge compose box when visiting concierge chat after connect bank step 3[/-][+][$1000] App loses focus from concierge compose box when visiting concierge chat after connect bank step 3[/+]melvin-bot commentedon Jul 11, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01ecac728c74967838
melvin-bot commentedon Jul 11, 2023
Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Jul 11, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (
External)ginsuma commentedon Jul 11, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App loses focus from concierge compose box when visiting concierge chat after connect bank step 3
What is the root cause of that problem?
When navigating to concierge chat from RHP, we don't dismiss modal before doing it so in Onyx,
modalkeepsisVisibletrue=>shouldAutoFocusonReportActionComposerisfalseApp/src/libs/actions/Report.js
Line 1196 in 702d8e2
App/src/pages/home/report/ReportActionCompose.js
Line 197 in 702d8e2
What changes do you think we should make in order to solve the problem?
Currently, we are using
modalfor focusing in 3 cases:ReportActionComposemount, this will check if we open RHP by deeplink =>modalis visible => not focus.App/src/pages/home/report/ReportActionCompose.js
Line 207 in be2c81f
prevProps.modal.isVisible && !this.props.modal.isVisible=> focus.App/src/pages/home/report/ReportActionCompose.js
Lines 277 to 279 in be2c81f
We shouldn't focus base on
modalkey.We will focus when the active route is
CentralPaneNavigator.Creating a function in
Navigationlike below:!props.modal.isVisibletoNavigation.isCPNRoute()=> this will solve that GH.modalhere . Therefore, we keepmodalin the condition and wait to see the update.Nodebrute commentedon Jul 11, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App loses focus from concierge compose box when visiting concierge chat after connect bank step 3
What is the root cause of that problem?
We are navigating to concierge hence in Onyx key modal isVisible = true. It will not become false until we open another modal and close it.
What changes do you think we should make in order to solve the problem?
We can use Navigation.dismissModal(conciergeChatReportID) instead of navigate methods. In most of the cases we are navigating to concierge from RHP so it's safe to use.
Or we can add a check if previous stack is RHP then dismiss modal else navigate like this
here I have created another function in
Navigationto getLastRouteWhat alternative solutions did you explore? (Optional)
13 remaining items
abdulrahuman5196 commentedon Jul 20, 2023
@sakluger There hasn't been any proposals we have made suitable to approve yet. I think we should increase this bounty.
ginsuma commentedon Jul 20, 2023
Proposal
Update
cc: @abdulrahuman5196
Nodebrute commentedon Jul 20, 2023
@abdulrahuman5196 this is dupe of #21401
abdulrahuman5196 commentedon Jul 21, 2023
Thanks for the reference @Nodebrute
@sakluger It seems we have a tracking issue for these composer focus kind of issues - #15992
melvin-bot commentedon Jul 24, 2023
@sakluger, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!
sakluger commentedon Jul 25, 2023
Good find! I'll leave this open until we hear back from @bondydaa whether this should be included in that tracking issue or not.
melvin-bot commentedon Jul 25, 2023
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon Jul 25, 2023
@sakluger @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
bondydaa commentedon Jul 26, 2023
throw whatever you want on that tracking issue that's what it's for. no one is assigned to it though so not much is going to get done with it until someone picks it up.
sakluger commentedon Jul 27, 2023
I added this to the list of related issues on the tracking issue, let's close for now since this will eventually be fixed there.