[HOLD for payment 2023-07-24] [$1000] Web - [Deleted message] shows even if there is no thread

@gadhiyamanan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to any chat
Send any message
Hover on that message and select reply in thread option which will redirect you to thread report screen
Go back to main report screen which will remove thread from LHN
Delete thar message

Expected Result:

Should delete completely as there is no thread attached

Actual Result:

[Deleted message] shows even if there is no thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-11.at.4.49.31.PM.mov

Recording.3554.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689076375456339

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019dc97a0bc3822c9f
Upwork Job ID: 1679007363269394432
Last Price Increase: 2023-07-12

@kadiealexander

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Deleted message] shows even if there is no thread

What is the root cause of that problem?

We are using the function hasCommentThread here to check if there is a comment thread:

App/src/libs/ReportActionsUtils.js

Lines 92 to 94 in 702d8e2

    
           function hasCommentThread(reportAction) { 
        
               return lodashGet(reportAction, 'childType', '') === CONST.REPORT.TYPE.CHAT; 
        
           }

This only checks if the thread was created, not if it actually contains any reportActions.

What changes do you think we should make in order to solve the problem?

We can check if the child report contains any report actions by using the childReportID of the reportAction and only display [Deleted message] if it does.

Edit: Please note that what I meant here is using the childReportID to get the child report and check if it has any reportActions.

What alternative solutions did you explore? (Optional)

None

Note that the above proposal will not work because childReportID field will exist after the user click the reply thread in the context menu

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - [Deleted message] shows even if there is no thread

What is the root cause of that problem?

we only use childType field to check hasCommentThread

App/src/libs/ReportActionsUtils.js

Lines 92 to 94 in 105ba31

    
           function hasCommentThread(reportAction) { 
        
               return lodashGet(reportAction, 'childType', '') === CONST.REPORT.TYPE.CHAT; 
        
           }

childType field will be 'chat' after the user clicks the reply thread in the context menu. Even though, after deleting the message, the childType filed still be 'chat'

What changes do you think we should make in order to solve the problem?

When deleting the parent comment we should check if this comment has childReportID and doesn't have any comment on the child report, we will update childType is empty in the parent comment (also should remove childReportID)

in here:

App/src/libs/actions/Report.js

Line 861 in d6b2d07

const optimisticReportActions = {

we can add this code

if (reportAction.childReportID && lodashGet(reportAction, 'childVisibleActionCount', 0) === 0) {
        optimisticReportActions[reportActionID].childType = ''
    }

With this approach, we don't need update from BE

What alternative solutions did you explore? (Optional)

We should change the condition to check hasCommentThread

 function hasCommentThread(reportAction) { 
     return reportAction.childReportID && reportAction.childVisibleActionCount > 0 // can use lodash get instead
 }

With this approach, We also need to fix the same thing from BE.

Repro'd:

2023-07-12_17-57-48.mp4

Job added to Upwork: https://www.upwork.com/jobs/~019dc97a0bc3822c9f

@kadiealexander

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

@fedirjh

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.41-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If a deleted parent doesn't have a thread anymore, hide it #22690

If no regressions arise, payment will be issued on 2023-07-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@fedirjh

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@fedirjh

Sent offers to @fedirjh and @gadhiyamanan.

@fedirjh, please don't forget about the checklist!

@kadiealexander

@kadiealexander offer accepted, thanks!

@gadhiyamanan

Paid @gadhiyamanan. @fedirjh please let us know when you expect to have the checklist completed, and I'll get you paid and close this out.

@kadiealexander

@kadiealexander I don't think we need a separate BZ for this issue. The other issue should cover this case as well : #21508 (comment) . As for the payment, I think I am not eligible for the payment, so we just have to close this issue.

@fedirjh

Thanks for the honesty, @fedirjh!! Closing this one out.

Navigation Menu

Repository navigation

[HOLD for payment 2023-07-24] [$1000] Web - [Deleted message] shows even if there is no thread #22674

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

12 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function hasCommentThread(reportAction) {
	return lodashGet(reportAction, 'childType', '') === CONST.REPORT.TYPE.CHAT;
	}

[HOLD for payment 2023-07-24] [$1000] Web - [Deleted message] shows even if there is no thread #22674

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jul 11, 2023

melvin-bot commented on Jul 11, 2023

Bug0 Triage Checklist (Main S/O)

Ollyws commented on Jul 11, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dukenv0307 commented on Jul 12, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

kadiealexander commented on Jul 12, 2023

melvin-bot commented on Jul 12, 2023

melvin-bot commented on Jul 12, 2023

melvin-bot commented on Jul 12, 2023

12 remaining items

melvin-bot commented on Jul 17, 2023

melvin-bot commented on Jul 17, 2023

melvin-bot commented on Jul 17, 2023

kadiealexander commented on Jul 24, 2023

gadhiyamanan commented on Jul 24, 2023

kadiealexander commented on Jul 25, 2023

fedirjh commented on Jul 25, 2023

kadiealexander commented on Jul 26, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions