You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for checklist][$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money #22691
Click on the avatar and observe that app displays 'Hmm its not here' page in place of user details
Expected Result:
App should also display user details page on click of avatar
Actual Result:
After clicking avatar, it displays 'Hmm its not here' page in request money flow
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.39-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
Tooltip shows only avatar and no login or display name in MoneyRequestConfirmationList page. Clicking on the user returns a Hmm, it ’s not there page.
What is the root cause of that problem?
Root cause of the problem is the new user obtained from getOptions is nowhere merged in personalDetailsList in Onyx. So, when we find the details of this new user in personalDetails, it returns nothing.
What changes do you think we should make in order to solve the problem?
Profile Issue's RC
if participant is the non-exist user in DB, Onyx send the optimisticData with random generated accountId.
When click the participant, it navigate to user profile.
We need to determine the expected result in this case.
There is no entry in DB in this case, so can't show profile info properly.
What alternative solutions did you explore? (Optional)
N/A Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Web - Tooltip displays only avatar and 'Hmm its not here' page is displayed on visiting profile of new user during request money[/-][+]Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/+]on Jul 12, 2023
changed the title [-]Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/-][+][$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/+]on Jul 12, 2023
changed the title [-][HOLD for payment 2023-08-14] [$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/-][+][HOLD for payment 2023-08-16] [HOLD for payment 2023-08-14] [$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/+]on Aug 9, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-16. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@sobitneupanedoes not require payment (Eligable for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-08-16] [HOLD for payment 2023-08-14] [$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/-][+][HOLD for payment 2023-08-16][$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/+]on Aug 10, 2023
changed the title [-][HOLD for payment 2023-08-16][$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/-][+][HOLD for checklist][$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/+]on Aug 17, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Not required.
[@sobitneupane] Determine if we should create a regression test for this bug.
Yes
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Jul 11, 2023
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 11, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)c3024 commentedon Jul 11, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Tooltip shows only avatar and no login or display name in
MoneyRequestConfirmationListpage. Clicking on the user returns a Hmm, it ’s not there page.What is the root cause of that problem?
Root cause of the problem is the new user obtained from
getOptionsis nowhere merged inpersonalDetailsListin Onyx. So, when we find the details of this new user inpersonalDetails, it returns nothing.What changes do you think we should make in order to solve the problem?
So, we need to update the
personalDetailson clicking the new user option inMoneyRequestParticipantsselector.It happens to be the
https://github.com/Expensify/App/blob/17d1c3dc1f16428802b151ac069db43f27a93aad/src/libs/actions/IOU.js#L1391C1-L1393C2
Here, we add before the
IOUmerge in the abovesetMoneyRequestParticipamtsfunction.and get
allPersonalDetailsby adding this also inIOUThis merges the new user’s details in
personalDetailsand the tooltip appears and clicking on avatar/user also takes to the page.What alternative solutions did you explore? (Optional)
Result
Screen.Recording.2023-07-12.at.12.17.32.PM.mov
multijump commentedon Jul 12, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Tooltip displays only avatar and 'Hmm its not here' page is displayed on visiting profile of new user during request money
What is the root cause of that problem?
We generate participants list from
createOptioninOptionsListUtils.jsWhen get avatar here,
createOptioncallsReportUtils.getIcons.App/src/libs/OptionsListUtils.js
Line 524 in 882026d
createOptionpasspersonalDetail.loginandpersonalDetail.accountIDbut actually, there is no parameters for these values.App/src/libs/ReportUtils.js
Line 807 in 882026d
If participant is the non-exist user in DB, there is not any report so in this case, follow code bloc execute.
That's why tooltip doesn't have description.
if participant is the non-exist user in DB, Onyx send the optimisticData with random generated accountId.
When click the participant, it navigate to user profile.
But this
option.accountIDis randomly generated so can't get correct profile data from this fake accountID.What changes do you think we should make in order to solve the problem?
We can add simply user login and accountID in getIcons function.
What alternative solutions did you explore? (Optional)
N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
greg-schroeder commentedon Jul 12, 2023
The tooltip part of this is a duplicate of #22485 / #22062
[-]Web - Tooltip displays only avatar and 'Hmm its not here' page is displayed on visiting profile of new user during request money[/-][+]Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/+]greg-schroeder commentedon Jul 12, 2023
I updated the OP/issue title to focus on the missing details in the user profile
[-]Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/-][+][$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/+]melvin-bot commentedon Jul 12, 2023
Job added to Upwork: https://www.upwork.com/jobs/~010b086092b3e04fff
melvin-bot commentedon Jul 12, 2023
Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.
66 remaining items
[-][HOLD for payment 2023-08-14] [$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/-][+][HOLD for payment 2023-08-16] [HOLD for payment 2023-08-14] [$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/+]melvin-bot commentedon Aug 9, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-16. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Aug 9, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-08-16] [HOLD for payment 2023-08-14] [$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/-][+][HOLD for payment 2023-08-16][$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/+]greg-schroeder commentedon Aug 16, 2023
Issue Participants:
Issue reported by: @dhanashree-sawant ($250)
Contributor: @dukenv0307 ($500)
C+: @sobitneupane ($500)
There was a regression here: #22691 (comment)
greg-schroeder commentedon Aug 17, 2023
Sent payments/offers. Remaining payments will be done via NewDot. All that's left is the checklist @sobitneupane
[-][HOLD for payment 2023-08-16][$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/-][+][HOLD for checklist][$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money[/+]sobitneupane commentedon Aug 21, 2023
#20746
#20746 (comment)
Not required.
Yes
#22691 (comment)
sobitneupane commentedon Aug 21, 2023
Regression Test Proposal
Do we agree 👍 or 👎
sobitneupane commentedon Aug 21, 2023
Requested payment on newDot
#22691 (comment)
greg-schroeder commentedon Aug 23, 2023
Thanks @sobitneupane! Took care of payments, filing regression test, closing.
JmillsExpensify commentedon Aug 30, 2023
Reviewed the details for @sobitneupane. $500 approved for payment in NewDot based on BZ summary.