Skip to content

[$1000] Web - Member`s avatar is 40x40px instead of 32x32px #22751

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Isіue found when executing PR #20512

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Go to Settings -> Workspace -> Create new WS -> Add any user to WS
  4. Create a $$ request in a workspace chat, open the created request
  5. Verify that the member`s avatar is 32x32px

Expected Result:

The member`s avatar is 32x32px

Actual Result:

The member`s avatar is 40x40px

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.39.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6125083_image__134_

Bug6125083_image__133_

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c72abdd919a99974
  • Upwork Job ID: 1679459962364895232
  • Last Price Increase: 2023-07-13

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 12, 2023
  2. melvin-bot commented on Jul 12, 2023

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 12, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. Nodebrute commented on Jul 12, 2023

    @Nodebrute
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Web - Member`s avatar is 40x40px instead of 32x32px

    What is the root cause of that problem?

    We are using avatarSizeNormal: 40 here

    What changes do you think we should make in order to solve the problem?

    We can pass size prop here and use CONST.AVATAR_SIZE.SMALL_NORMAL which is 32.

    What alternative solutions did you explore? (Optional)

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 13, 2023
  6. changed the title [-]Web - Member`s avatar is 40x40px instead of 32x32px[/-] [+][$1000] Web - Member`s avatar is 40x40px instead of 32x32px[/+] on Jul 13, 2023
  7. melvin-bot commented on Jul 13, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 13, 2023
  9. melvin-bot commented on Jul 13, 2023

    @melvin-bot

    Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

  10. melvin-bot commented on Jul 13, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  11. 0xmiroslav commented on Jul 13, 2023

    @0xmiroslav
    Contributor

    I think this is expected.
    @shawnborton @grgia can you please confirm?

  12. shawnborton commented on Jul 13, 2023

    @shawnborton
    Contributor

    Correct, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions