You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-03] DEV: The paid amount appears as 0 after sending a money request between users #22763
Account B send money request back to Account A, with same amount
Account B send other money request to Account A (maybe optional)
Check the paid amount showing in the report and click to view details
Expected Result:
The correct paid amount should be displayed.
Actual Result:
The paid amount appears as 0 and there is error when click to view details
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.39-7 Dev Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
(It didn’t happen initially right after sending the Request Money, but then it started occurring and persisted, even after logging out and logging in again)
I saw this bug too, it's because the preview total relies on checking the iouReport, but no iouReport gets returned by the back end because no iouReportID gets returned for the chat once the iou is settled.
To me it happened also previous my PRs. (and I can also reproduce it in prod). I don't see how it ever worked, as auth never returns iouReportID for a chat once it's settled... Or did the getChats query returned some iouReports at some point and not anymore?
I made this fix to default on the reportAction amount if no iouReport gets returned ... but not sure how reliable it is.
When using my branch, can you tell me what you see if you click on the browser Application > IndexedDB > OnyxDB > keyvaluepairs > reportActions_{yourChatReportID}
An open the json with the reportPreview report action > message[0] > text.
changed the title [-]DEV: The paid amount appears as 0 after sending a money request between users[/-][+][HOLD for payment 2023-08-03] DEV: The paid amount appears as 0 after sending a money request between users[/+]on Jul 27, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-03. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
[@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@0xmiroslav] Determine if we should create a regression test for this bug.
[@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@tranvantoan-qn I talked this over in Slack - I think in this case even though this was fixed elsewhere you deserve $250 reporting and $250 for help testing
Payment Summary
Payment Summary
@tranvantoan-qn - $250 for reporting bonus $ $250 for help testing. $500 total(paid via Upwork)
Activity
melvin-bot commentedon Jul 12, 2023
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 12, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)tranvantoan-qn commentedon Jul 12, 2023
Added screenshot and error log for more information:
console.txt
tranvantoan-qn commentedon Jul 12, 2023
(It didn’t happen initially right after sending the Request Money, but then it started occurring and persisted, even after logging out and logging in again)
nkuoch commentedon Jul 14, 2023
I saw this bug too, it's because the preview total relies on checking the iouReport, but no iouReport gets returned by the back end because no iouReportID gets returned for the chat once the iou is settled.
To me it happened also previous my PRs. (and I can also reproduce it in prod). I don't see how it ever worked, as auth never returns iouReportID for a chat once it's settled... Or did the getChats query returned some iouReports at some point and not anymore?
I made this fix to default on the reportAction amount if no iouReport gets returned ... but not sure how reliable it is.
tranvantoan-qn commentedon Jul 14, 2023
@nkuoch

I checked out your branch and now I no longer see the both sender and the amount
nkuoch commentedon Jul 14, 2023
When using my branch, can you tell me what you see if you click on the browser Application > IndexedDB > OnyxDB > keyvaluepairs > reportActions_{yourChatReportID}
An open the json with the reportPreview report action > message[0] > text.
tranvantoan-qn commentedon Jul 14, 2023
I'm not sure which sub-element I should check, but the message is empty for some
I attached the database here (please convert it to
.json, so It may help you to check it easier, the key isreportActions_285914402761623reportActions_285914402761623.txt
nkuoch commentedon Jul 14, 2023
Thanks for testing. Can you pull my branch and try again?
tranvantoan-qn commentedon Jul 14, 2023
Hi,
It looks much better now as the paid amount is showing, but the sender name is still missing, or there is new logic added?
nkuoch commentedon Jul 14, 2023
Thanks, can you pull my branch and try again?
18 remaining items
[-]DEV: The paid amount appears as 0 after sending a money request between users[/-][+][HOLD for payment 2023-08-03] DEV: The paid amount appears as 0 after sending a money request between users[/+]melvin-bot commentedon Jul 27, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 27, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-03. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jul 27, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
adelekennedy commentedon Aug 4, 2023
checking in bugzero cause this one's a little weird
adelekennedy commentedon Aug 6, 2023
@tranvantoan-qn I talked this over in Slack - I think in this case even though this was fixed elsewhere you deserve $250 reporting and $250 for help testing
Payment Summary
Payment Summary
@tranvantoan-qn - $250 for reporting bonus $ $250 for help testing. $500 total(paid via Upwork)
tranvantoan-qn commentedon Aug 6, 2023
@adelekennedy
I truly appreciate your consideration!
I've accepted the offer. Thank you!