Repository navigation
[HOLD for payment 2023-10-24] [ECard Settings] - Add Assigned Card tile & Display Expensify cards #22872
Description
HOLD ON https://github.com/Expensify/Expensify/issues/299923
Design Doc Section
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ab3350fcd013bf5f
- Upwork Job ID: 1679789970416893952
- Last Price Increase: 2023-07-14
Activity
melvin-bot commentedon Jul 14, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01ab3350fcd013bf5f
melvin-bot commentedon Jul 14, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (
Internal)grgia commentedon Aug 31, 2023
cc @pac-guerreiro
pac-guerreiro commentedon Aug 31, 2023
Could you assign me to this @grgia ? 😄
marcaaron commentedon Aug 31, 2023
I think this one actually can be off HOLD or at least split into two parts. There won't be any cards appearing until the API changes are merged and we start using these components on the "Wallet" page. But we could build most of the UI with mock data.
Maybe we can get started building out the Assigned cards tile component and add a story for it in Storybook.
@pac-guerreiro does an approach like that work for you?
marcaaron commentedon Aug 31, 2023
I don't think we want to switch over to the new page until the Expensify Cards are actually showing up. But we could also start reviewing and testing the changes so they are ready to ship as soon as the API changes are deployed.
marcaaron commentedon Aug 31, 2023
I'm gonna remove the HOLD on the issue so we can get started. But I'd recommend to put a hold on the PR so it doesn't get accidentally deployed before the API changes.
[-][HOLD E/E#299923][ECard Settings] - Add Assigned Card tile & Display Expensify cards[/-][+][ECard Settings] - Add Assigned Card tile & Display Expensify cards[/+]32 remaining items
[-][ECard Settings] - Add Assigned Card tile & Display Expensify cards[/-][+][HOLD for payment 2023-10-24] [ECard Settings] - Add Assigned Card tile & Display Expensify cards[/+]melvin-bot commentedon Oct 17, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 17, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-24. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
joekaufmanexpensify commentedon Oct 18, 2023
Payment summary:
JmillsExpensify commentedon Oct 18, 2023
$500 payment approved for @rushatgabhane based on BZ summary.
joekaufmanexpensify commentedon Oct 23, 2023
Confirming second payment was issued too
joekaufmanexpensify commentedon Oct 24, 2023
Okay, chatted with Jason and confirmed @allroundexperts payment is still pending being issued. Closing this as payment has been requested.
JmillsExpensify commentedon Oct 24, 2023
$500 payment approved for @allroundexperts based on summary above.