Skip to content

[HOLD for payment 2023-08-24] [$2000] mWeb - Chat - emoji picker presents glitches while scrolling with the keyboard open #22939

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #22680

Action Performed:

  1. Go to https://staging.new.expensify.com/
    and log in
  2. Navigate to any chat.
  3. Tap on Emoji button in composer
  4. Enter a term that has no results
  5. Scroll up and down slowly

Expected Result:

The emoji picker should be stable when scrolling up and down

Actual Result:

The emoji picker looks unstable and presents glitches while scrolling with the keyboard open

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.41.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6128880_mWeb_-_Safari_-_Emoji_Picker.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Interanl Team

*Slack conversation:

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bdc44dc552114d99
  • Upwork Job ID: 1682463762946265088
  • Last Price Increase: 2023-08-03
  • Automatic offers:
    • s-alves10 | Contributor | 26030445

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 15, 2023
  2. melvin-bot commented on Jul 15, 2023

    @melvin-bot

    Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 15, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. maddylewis commented on Jul 18, 2023

    @maddylewis
    Contributor
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 21, 2023
  6. changed the title [-]mWeb - Chat - emoji picker presents glitches while scrolling with the keyboard open[/-] [+][$1000] mWeb - Chat - emoji picker presents glitches while scrolling with the keyboard open[/+] on Jul 21, 2023
  7. melvin-bot commented on Jul 21, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 21, 2023
  9. melvin-bot commented on Jul 21, 2023

    @melvin-bot

    Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

  10. 71 remaining items

  11. maddylewis commented on Aug 24, 2023

    @maddylewis
    Contributor

    @sobitneupane - will you confirm if any of this checklist needs to be filled out - thanks! #22939 (comment)

  12. melvin-bot commented on Aug 28, 2023

    @melvin-bot

    @amyevans, @sobitneupane, @maddylewis, @s-alves10 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. maddylewis commented on Aug 28, 2023

    @maddylewis
    Contributor

    just waiting for @sobitneupane to confirm if any of these details need to be filled out before closing - #22939 (comment)

  14. sobitneupane commented on Aug 29, 2023

    @sobitneupane
    Contributor

    Sorry for the delay. I will try to get to it asap.

  15. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    @amyevans, @sobitneupane, @maddylewis, @s-alves10 Eep! 4 days overdue now. Issues have feelings too...

  16. maddylewis commented on Sep 5, 2023

    @maddylewis
    Contributor

    @sobitneupane - we're just waiting for you to confirm if anything on this checklist needs to be completed, and then we can close this out. #22939 (comment)

  17. sobitneupane commented on Sep 5, 2023

    @sobitneupane
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

    #18221

    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #18221 (comment)

    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    This is an edge case and was missed in the PR review.

    • [@sobitneupane] Determine if we should create a regression test for this bug.

    Yes.

    • [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    #22939 (comment)

  18. sobitneupane commented on Sep 5, 2023

    @sobitneupane
    Contributor

    Regression Test Proposal

    1. Navigate to any chat in IOS/safari.
    2. Tap on Emoji button in composer
    3. Enter a term that has no results
    4. Scroll up and down slowly

    Do we agree 👍 or 👎

  19. sobitneupane commented on Sep 5, 2023

    @sobitneupane
    Contributor

    Requested Payment on newDot.

    #22939 (comment)

  20. JmillsExpensify commented on Sep 10, 2023

    @JmillsExpensify
    Contributor

    $3,000 payment approved via NewDot based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions