Skip to content

[HOLD for payment 2023-09-27] [$1000] Web - RHP overlapping with the popovers #22953

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login with any account and open any chat.
  2. Click on the avatar in the chat header to open the chat details RHP.
  3. Click anywhere else to close it.
  4. Press the video call icon in the chat header to open the popover.
  5. Press the forward button in the browser.

Expected Result:

RHP should open and popover should close.

Actual Result:

Both RHP and popover are open.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.41-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-15.at.1.38.43.AM.mov

image (26)

Expensify/Expensify Issue URL:
Issue reported by: Sibtain Ali
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689367096915129

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013464e806f5099ea9
  • Upwork Job ID: 1696143850157252608
  • Last Price Increase: 2023-09-04

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 15, 2023
  2. melvin-bot commented on Jul 15, 2023

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 15, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. ahmdshrif commented on Jul 15, 2023

    @ahmdshrif
    Contributor

    Proposal

    Please restate the problem that we are trying to solve in this issue.

    The video chat menu does not hide when RHP is open.

    What is the root cause of that problem?

    We are not checking if the screen is focused on the VideoChatMenuActive and hiding it accordingly.

    What changes do you think we should make in order to solve the problem?

    We will need to determine if the screen is focused or not using the withNavigationFocus HOC or useNavigationFocus hook. Then, we can create a hook to trigger when isFocused changes. If the screen is not focused, we will hide the menu. The code can be implemented as shown below:

    const propTypes = {
        ...
        ...withNavigationFocusPropTypes,
    };
    
    ...
    
    useEffect(() => {
        if (props.isFocused) {
            return;
        }
        setIsVideoChatMenuActive(false);
    }, [props.isFocused]);
    
    ...
    
    export default compose(withWindowDimensions, withLocalize, withNavigationFocus)(BaseVideoChatButtonAndMenu);

    What alternative solutions did you explore? (Optional)

    Another alternative solution is to use useNavigation change and check if the current route is not our route. If it's not our route, we can hide the call menu.

  5. allroundexperts commented on Jul 15, 2023

    @allroundexperts
    Contributor

    I think this should be held on #15289.

  6. changed the title [-]Web - RHP overlapping with the popovers[/-] [+][Hold for #15289] Web - RHP overlapping with the popovers[/+] on Jul 18, 2023
  7. NicMendonca commented on Jul 26, 2023

    @NicMendonca
    Contributor

    still holding

  8. 75 remaining items

  9. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-27. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  10. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
    • [@sobitneupane / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@sobitneupane / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@sobitneupane / @allroundexperts] Determine if we should create a regression test for this bug.
    • [@sobitneupane / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. sobitneupane commented on Sep 25, 2023

    @sobitneupane
    Contributor

    @allroundexperts Since you have worked on the functionality, do you have idea which PR caused this issue?

  12. allroundexperts commented on Sep 25, 2023

    @allroundexperts
    Contributor

    @sobitneupane I'm not sure if any PR has caused this. This seemed to be an edge case which existed even before the refactor we did around popovers!

  13. sobitneupane commented on Sep 25, 2023

    @sobitneupane
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Edge case that is present from long time.

    • [@sobitneupane / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    N/A

    • [@sobitneupane / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    N/A

    Yes.

    #22953 (comment)

  14. sobitneupane commented on Sep 25, 2023

    @sobitneupane
    Contributor

    Regression Test Proposal

    1. Log in to the app and click on the user avatar to open the RHP.
    2. Click anywhere else to close it.
    3. Open any popover.
    4. Press the forward button in the browser.
    5. Verify that the popover disappears.
  15. dangrous commented on Sep 27, 2023

    @dangrous
    Contributor

    I might just update #3 to give some options of popovers, to make it easy. Otherwise looks good!

  16. NicMendonca commented on Sep 27, 2023

    @NicMendonca
    Contributor
    • reporter AND contributor: @allroundexperts: $1800 (reporting + fixing + speed + bonus for reporting AND fixing lol)
    • C+: @sobitneupane: $1,500 (pr review + speed)

    @allroundexperts @sobitneupane don't forget to request payment via Expensify please!

  17. NicMendonca commented on Sep 27, 2023

    @NicMendonca
    Contributor

    all set here, thanks everyone!

  18. JmillsExpensify commented on Oct 5, 2023

    @JmillsExpensify
    Contributor

    $1,800 payment approved for @allroundexperts based on BZ summary.

  19. sobitneupane commented on Oct 9, 2023

    @sobitneupane
    Contributor

    #22953 (comment)

    Requested payment on newDot

  20. JmillsExpensify commented on Oct 9, 2023

    @JmillsExpensify
    Contributor

    $1,500 payment approved fro @sobitneupane based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions