You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-27] [$1000] Web - RHP overlapping with the popovers #22953
Click on the avatar in the chat header to open the chat details RHP.
Click anywhere else to close it.
Press the video call icon in the chat header to open the popover.
Press the forward button in the browser.
Expected Result:
RHP should open and popover should close.
Actual Result:
Both RHP and popover are open.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.41-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please restate the problem that we are trying to solve in this issue.
The video chat menu does not hide when RHP is open.
What is the root cause of that problem?
We are not checking if the screen is focused on the VideoChatMenuActive and hiding it accordingly.
What changes do you think we should make in order to solve the problem?
We will need to determine if the screen is focused or not using the withNavigationFocus HOC or useNavigationFocus hook. Then, we can create a hook to trigger when isFocused changes. If the screen is not focused, we will hide the menu. The code can be implemented as shown below:
What alternative solutions did you explore? (Optional)
Another alternative solution is to use useNavigation change and check if the current route is not our route. If it's not our route, we can hide the call menu.
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@sobitneupanedoes not require payment (Eligible for Manual Requests)
@allroundexpertsdoes not require payment (Eligible for Manual Requests)
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
N/A
[@sobitneupane / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Jul 15, 2023
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 15, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)ahmdshrif commentedon Jul 15, 2023
Proposal
Please restate the problem that we are trying to solve in this issue.
The video chat menu does not hide when RHP is open.
What is the root cause of that problem?
We are not checking if the screen is focused on the VideoChatMenuActive and hiding it accordingly.
What changes do you think we should make in order to solve the problem?
We will need to determine if the screen is focused or not using the
withNavigationFocusHOC oruseNavigationFocushook. Then, we can create a hook to trigger whenisFocusedchanges. If the screen is not focused, we will hide the menu. The code can be implemented as shown below:What alternative solutions did you explore? (Optional)
Another alternative solution is to use
useNavigationchange and check if the current route is not our route. If it's not our route, we can hide the call menu.allroundexperts commentedon Jul 15, 2023
I think this should be held on #15289.
[-]Web - RHP overlapping with the popovers[/-][+][Hold for #15289] Web - RHP overlapping with the popovers[/+]NicMendonca commentedon Jul 26, 2023
still holding
75 remaining items
melvin-bot commentedon Sep 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 20, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sobitneupane commentedon Sep 25, 2023
@allroundexperts Since you have worked on the functionality, do you have idea which PR caused this issue?
allroundexperts commentedon Sep 25, 2023
@sobitneupane I'm not sure if any PR has caused this. This seemed to be an edge case which existed even before the refactor we did around popovers!
sobitneupane commentedon Sep 25, 2023
Edge case that is present from long time.
N/A
N/A
Yes.
#22953 (comment)
sobitneupane commentedon Sep 25, 2023
Regression Test Proposal
dangrous commentedon Sep 27, 2023
I might just update #3 to give some options of popovers, to make it easy. Otherwise looks good!
NicMendonca commentedon Sep 27, 2023
@allroundexperts @sobitneupane don't forget to request payment via Expensify please!
NicMendonca commentedon Sep 27, 2023
all set here, thanks everyone!
JmillsExpensify commentedon Oct 5, 2023
$1,800 payment approved for @allroundexperts based on BZ summary.
sobitneupane commentedon Oct 9, 2023
#22953 (comment)
Requested payment on newDot
JmillsExpensify commentedon Oct 9, 2023
$1,500 payment approved fro @sobitneupane based on BZ summary.