You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Web - Magic code does not show if copy-pasted #22963
Copy the magic code from the email and paste it into the magic code input
Expected Result:
The pasted magic code is shown on the input
Actual Result:
You can't see the magic code you pasted. Sometimes, you can see the code for a very brief moment and then it disappears.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.41-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem we are trying to solve in this issue
Currently in the application, when a user copy-pastes a magic code from an email into the magic code input field during login, the pasted code is not visible or momentarily appears and then disappears
What is the root cause of that problem
This issue originates from the handling of the magic code input. Specifically, in the MagicCodeinput file, snippets like setInput(""); are clearing the input as soon as all the necessary digits are entered. This prematurely clears the magic code that the user has just pasted into the field.
changed the title [-][$1000] [Waiting on #21293] Web - Magic code does not show if copy-pasted[/-][+][$250] Web - Magic code does not show if copy-pasted[/+]on Jul 18, 2023
Activity
melvin-bot commentedon Jul 16, 2023
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 16, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)ygshbht commentedon Jul 17, 2023
Proposal
Please re-state the problem we are trying to solve in this issue
Currently in the application, when a user copy-pastes a magic code from an email into the magic code input field during login, the pasted code is not visible or momentarily appears and then disappears
What is the root cause of that problem
This issue originates from the handling of the magic code input. Specifically, in the
MagicCodeinputfile, snippets likesetInput("");are clearing the input as soon as all the necessary digits are entered. This prematurely clears the magic code that the user has just pasted into the field.For example in the
MagicCodeInputfile:What changes do you think we should make in order to solve the problem
To rectify this issue, we could either not clear the input, clear it after the server has sent a response, or clear it at any other preferred time.
StevenKKC commentedon Jul 17, 2023
Once 6 digits are all entered, signing in starts, and then magic code will be cleared.
After copy and pasted, it is same. Is it not a intended?
aimane-chnaif commentedon Jul 17, 2023
@tienifr and I are already working on this - #23023 as a follow-up of #22786
garrettmknight commentedon Jul 18, 2023
Thanks for the note @aimane-chnaif - I'll leave this to you to fix then!
bernhardoj commentedon Jul 18, 2023
@garrettmknight I think we should keep this open for the bug report payment
garrettmknight commentedon Jul 18, 2023
@bernhardoj good call, my mistake!
7 remaining items
melvin-bot commentedon Jul 18, 2023
Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Jul 18, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)garrettmknight commentedon Jul 18, 2023
@bernhardoj accept the offer and I'll pay you out.
[-][$1000] [Waiting on #21293] Web - Magic code does not show if copy-pasted[/-][+][$250] Web - Magic code does not show if copy-pasted[/+]melvin-bot commentedon Jul 18, 2023
Upwork job price has been updated to $250
bernhardoj commentedon Jul 19, 2023
@garrettmknight accepted
garrettmknight commentedon Jul 19, 2023
Paid and closed!