Skip to content

[$250] Web - Magic code does not show if copy-pasted #22963

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Sign out if you are signed in

  1. Enter your login and press Next
  2. Copy the magic code from the email and paste it into the magic code input

Expected Result:

The pasted magic code is shown on the input

Actual Result:

You can't see the magic code you pasted. Sometimes, you can see the code for a very brief moment and then it disappears.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.41-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-15.at.11.41.45.mov

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689385139111849

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014ff2d6906601d0f8
  • Upwork Job ID: 1681361155951980544
  • Last Price Increase: 2023-07-18

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2023
  2. melvin-bot commented on Jul 16, 2023

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 16, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. ygshbht commented on Jul 17, 2023

    @ygshbht
    Contributor

    Proposal

    Please re-state the problem we are trying to solve in this issue

    Currently in the application, when a user copy-pastes a magic code from an email into the magic code input field during login, the pasted code is not visible or momentarily appears and then disappears

    What is the root cause of that problem

    This issue originates from the handling of the magic code input. Specifically, in the MagicCodeinput file, snippets like setInput(""); are clearing the input as soon as all the necessary digits are entered. This prematurely clears the magic code that the user has just pasted into the field.

    For example in the MagicCodeInput file:

    onKeyPress: () => {
    
      <!-- preceding code-->
    
      setInput("");
      props.onFulfill(props.value):
    
      <!-- following code -->
    
    }
    

    What changes do you think we should make in order to solve the problem

    To rectify this issue, we could either not clear the input, clear it after the server has sent a response, or clear it at any other preferred time.

  5. StevenKKC commented on Jul 17, 2023

    @StevenKKC
    Contributor

    Once 6 digits are all entered, signing in starts, and then magic code will be cleared.
    After copy and pasted, it is same. Is it not a intended?

  6. aimane-chnaif commented on Jul 17, 2023

    @aimane-chnaif
    Contributor

    @tienifr and I are already working on this - #23023 as a follow-up of #22786

  7. garrettmknight commented on Jul 18, 2023

    @garrettmknight
    Contributor

    Thanks for the note @aimane-chnaif - I'll leave this to you to fix then!

  8. bernhardoj commented on Jul 18, 2023

    @bernhardoj
    Contributor

    @garrettmknight I think we should keep this open for the bug report payment

  9. garrettmknight commented on Jul 18, 2023

    @garrettmknight
    Contributor

    @bernhardoj good call, my mistake!

  10. 7 remaining items

  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 18, 2023
  12. melvin-bot commented on Jul 18, 2023

    @melvin-bot

    Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

  13. melvin-bot commented on Jul 18, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 18, 2023
  15. garrettmknight commented on Jul 18, 2023

    @garrettmknight
    Contributor

    @bernhardoj accept the offer and I'll pay you out.

  16. changed the title [-][$1000] [Waiting on #21293] Web - Magic code does not show if copy-pasted[/-] [+][$250] Web - Magic code does not show if copy-pasted[/+] on Jul 18, 2023
  17. melvin-bot commented on Jul 18, 2023

    @melvin-bot

    Upwork job price has been updated to $250

  18. bernhardoj commented on Jul 19, 2023

    @bernhardoj
    Contributor
  19. garrettmknight commented on Jul 19, 2023

    @garrettmknight
    Contributor

    Paid and closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions