You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-16] [$1000] On request money report clicking the down arrow on options to pay with expensify hides the entire button #23140
Login to ND (account should have permission to pay with Expensify)
Navigate to any request money report (if there is non then on user A request money to user B then login to user B to access request money report)
On request money report there should be a drop down button -> click on down arrow
Notice the dropdown option hides the pay with expensify button
Expected Result:
On opening the drop menu should not hide the button
Actual Result:
On opening the drop menu it hides the entire button
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.41-2 Reproducible in staging?: Needs reproducion (Pay with expensify only for USD) Reproducible in production?: Needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
On request money report clicking the down arrow on options to pay with expensify hides the entire button
What is the root cause of that problem?
The root cause is we are passing wrong verticalanchorAlignment on ButtonWithDropdownMenu that makes menu to over laps with button and hide under it
What changes do you think we should make in order to solve the problem?
We need to pass correct vertical``anchorAlignment that shows menu on bottom of the button without hiding that
Currently we are passing ANCHOR_ORIGIN_VERTICAL.BOTTOM instead of that ew just need to pass ANCHOR_ORIGIN_VERTICAL.TOP on below line
Also, we always add the height h to the vertical position but we only need to do this when we need to show the menu below button (MoneyReportHeader) not when we show the menu above the button MoneyRequestConfirmationList.
What changes do you think we should make in order to solve the problem?
We need to introduce a new prop anchorAlignment in ButtonWithDropdownMenu and SettlementButton -
// type -
anchorAlignment: PropTypes.shape({horizontal: PropTypes.oneOf(_.values(CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL)),vertical: PropTypes.oneOf(_.values(CONST.MODAL.ANCHOR_ORIGIN_VERTICAL)),})// default value -
anchorAlignment: {horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP,// we can keep it as bottom also}
Also, we need to calculate the vertical position based on the vertical anchorAlignment and add the consistent padding of 8px -
setPopoverAnchorPosition({horizontal: x+w,vertical: props.anchorAlignment.vertical===CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP
? y+h+8// if anchorPosition is top, menu will open below the button and we need to add the height of button
: y-8// if anchorPosition is bottom, menu will open above the button so no need to add height to vertical position});
We should make a constant for this 8px in CONST.js and then use it here and in other files.
Design team provided there approval on this 8px padding here.
Finally, we should pass the new prop from following components -
In SettlementButton we just need to pass the prop received from parent to ButtonWithDropdownMenu like - anchorAlignment={this.props.anchorAlignment}.
In MoneyReportHeader, the dropdown should open below button so vertical anchor position should be TOP -
What alternative solutions did you explore? (Optional)
Instead of introducing the anchorAlignment prop, we can make a simpler prop for just the vertical anchor alignment like -
topVerticalAnchorAlignment - a boolean prop which when true will set vertical anchor alignment to TOP otherwise BOTTOM.
verticalAnchorAlignment - a prop of type PropTypes.oneOf(_.values(CONST.MODAL.ANCHOR_ORIGIN_VERTICAL)), we can either pass CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP or BOTTOM.
changed the title [-]On request money report clicking the down arrow on options to pay with expensify hides the entire button[/-][+][$1000] On request money report clicking the down arrow on options to pay with expensify hides the entire button[/+]on Jul 20, 2023
changed the title [-][$1000] On request money report clicking the down arrow on options to pay with expensify hides the entire button[/-][+][HOLD for payment 2023-08-16] [$1000] On request money report clicking the down arrow on options to pay with expensify hides the entire button[/+]on Aug 9, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-16. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jul 18, 2023
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.kavimuru commentedon Jul 18, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
On request money report clicking the down arrow on options to pay with expensify hides the entire button
What is the root cause of that problem?
The root cause is we are passing wrong
verticalanchorAlignmentonButtonWithDropdownMenuthat makes menu to over laps with button and hide under itWhat changes do you think we should make in order to solve the problem?
We need to pass correct
vertical``anchorAlignmentthat shows menu on bottom of the button without hiding thatCurrently we are passing
ANCHOR_ORIGIN_VERTICAL.BOTTOMinstead of that ew just need to passANCHOR_ORIGIN_VERTICAL.TOPon below lineApp/src/components/ButtonWithDropdownMenu.js
Line 122 in 25c8ae5
What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon Jul 18, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)sakluger commentedon Jul 19, 2023
Asking in the Slack threadabout reproduction.
Nikhil-Vats commentedon Jul 19, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
In IOU Report, when caret/arrow/dropdown button is clicked in settlement button in header, the main button gets hidden behind the popover menu.
What is the root cause of that problem?
We are using a fixed
BOTTOMvertical alignment for the popover menu here. It should be passed via props based on where the position of button is -MoneyReportHeader, menu should open below it.MoneyRequestConfirmationList, menu should open above it.App/src/components/ButtonWithDropdownMenu.js
Line 122 in 9508dfa
Also, we always add the height
hto the vertical position but we only need to do this when we need to show the menu below button (MoneyReportHeader) not when we show the menu above the buttonMoneyRequestConfirmationList.App/src/components/ButtonWithDropdownMenu.js
Lines 67 to 70 in 9508dfa
Lastly, there is no padding here which we are using on other pages -
App/src/components/KYCWall/BaseKYCWall.js
Line 72 in 9508dfa
What changes do you think we should make in order to solve the problem?
We need to introduce a new prop
anchorAlignmentinButtonWithDropdownMenuandSettlementButton-Also, we need to calculate the vertical position based on the vertical
anchorAlignmentand add the consistent padding of8px-We should make a constant for this
8pxin CONST.js and then use it here and in other files.Design team provided there approval on this
8pxpadding here.Finally, we should pass the new prop from following components -
SettlementButtonwe just need to pass the prop received from parent toButtonWithDropdownMenulike -anchorAlignment={this.props.anchorAlignment}.MoneyReportHeader, the dropdown should open below button so vertical anchor position should beTOP-MoneyRequestConfirmationList, the dropdown should open above button so vertical anchor position should beBOTTOM-Other inconsistencies
We are using
10pxgap here so we can change this to8pxtoo. This is the add payment method menu in settings.App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js
Line 413 in b48e9a6
What alternative solutions did you explore? (Optional)
Instead of introducing the
anchorAlignmentprop, we can make a simpler prop for just the vertical anchor alignment like -topVerticalAnchorAlignment- a boolean prop which when true will set vertical anchor alignment toTOPotherwiseBOTTOM.verticalAnchorAlignment- a prop of typePropTypes.oneOf(_.values(CONST.MODAL.ANCHOR_ORIGIN_VERTICAL)), we can either passCONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOPorBOTTOM.Videos
Screen.Recording.2023-07-25.at.5.10.29.PM.mov
Screen.Recording.2023-07-25.at.5.11.08.PM.mov
sakluger commentedon Jul 20, 2023
I was able to reproduce this and it's definitely a bug!
[-]On request money report clicking the down arrow on options to pay with expensify hides the entire button[/-][+][$1000] On request money report clicking the down arrow on options to pay with expensify hides the entire button[/+]melvin-bot commentedon Jul 20, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01f871dc05dbdb8459
33 remaining items
Julesssss commentedon Aug 7, 2023
The PR was ready to merge within 3 days, but I was OOO. Bonus should apply.
[-][$1000] On request money report clicking the down arrow on options to pay with expensify hides the entire button[/-][+][HOLD for payment 2023-08-16] [$1000] On request money report clicking the down arrow on options to pay with expensify hides the entire button[/+]melvin-bot commentedon Aug 9, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 9, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-16. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Aug 9, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sakluger commentedon Aug 17, 2023
@situchan as soon as you finish the BugZero checklist I can complete your payment as well. Thanks!
situchan commentedon Aug 17, 2023
No PR caused regression. I'd say this is minor UI improvement than bug so no regression test is needed
sakluger commentedon Aug 17, 2023
Thanks @situchan! I completed payment via Upwork.