[HOLD for payment 2023-08-07] Incorrect font size & family on Two-factor authentication page

@shawnborton

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Enable 2FA
Go to Settings > Security > Two-factor authentication page
Observe paragraph text below headline

Expected Result:

The paragraph text should use our normal font size (15px) and font family (Expensify Neue)

Actual Result:

The paragraph text is too small and does not use our brand font.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.42-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689770034472829

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0112470818bb41c902
Upwork Job ID: 1682325993771044864
Last Price Increase: 2023-07-21

@greg-schroeder

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect font size & family on Two-factor authentication page

What is the root cause of that problem?

The paragraph has style styles.textLabel which isn't the expected font-size and doesn't contain font family

App/src/pages/settings/Security/TwoFactorAuth/IsEnabledPage.js

Line 46 in 7fea760

    
           <Text style={styles.textLabel}>{props.translate('twoFactorAuth.whatIsTwoFactorAuth')}</Text>

App/src/styles/styles.js

Lines 293 to 296 in 7fea760

    
           textLabel: { 
        
               color: themeColors.text, 
        
               fontSize: variables.fontSizeLabel, 
        
               lineHeight: variables.lineHeightLarge,

What changes do you think we should make in order to solve the problem?

We can remove this style here and use Text component that we designed to make the text has default style which has fontSize as 15px and fontFamily as Expensify Neue

App/src/pages/settings/Security/TwoFactorAuth/IsEnabledPage.js

Line 46 in 7fea760

    
           <Text style={styles.textLabel}>{props.translate('twoFactorAuth.whatIsTwoFactorAuth')}</Text>

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

The font size and font family is different on two factor auth page.

What is the root cause of that problem?

Currently for that text paragraph we are using a Text component from 'react-native' instead of using our own custom Text component, which will make the font-size and family non-standard.

App/src/pages/settings/Security/TwoFactorAuth/IsEnabledPage.js

Line 2 in 7fea760

import {Text, View, ScrollView} from 'react-native';

What changes do you think we should make in order to solve the problem?

We should instead import the Text component from ../../../../components/Text and remove the style applied to the text.

App/src/pages/settings/Security/TwoFactorAuth/IsEnabledPage.js

Line 46 in 7fea760

    
           <Text style={styles.textLabel}>{props.translate('twoFactorAuth.whatIsTwoFactorAuth')}</Text>

This was missed during initial implementation, and I'll take a look

Job added to Upwork: https://www.upwork.com/jobs/~0112470818bb41c902

@sobitneupane

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

Looks like Monil is gonna take this one on, marked Internal accordingly

PR on staging, awaiting deploy to prod

Reviewing label has been removed, please complete the "BugZero Checklist".

@sobitneupane

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Use correct component Text component and fix style #23708

If no regressions arise, payment will be issued on 2023-08-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@sobitneupane does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@sobitneupane

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Closing this as it was all internal, and we missed during initial implementation

Navigation Menu

Repository navigation

[HOLD for payment 2023-08-07] Incorrect font size & family on Two-factor authentication page #23326

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

8 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	textLabel: {
	color: themeColors.text,
	fontSize: variables.fontSizeLabel,
	lineHeight: variables.lineHeightLarge,

[HOLD for payment 2023-08-07] Incorrect font size & family on Two-factor authentication page #23326

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jul 21, 2023

melvin-bot commented on Jul 21, 2023

Bug0 Triage Checklist (Main S/O)

dukenv0307 commented on Jul 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

getusha commented on Jul 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

MonilBhavsar commented on Jul 21, 2023

melvin-bot commented on Jul 21, 2023

melvin-bot commented on Jul 21, 2023

greg-schroeder commented on Jul 21, 2023

8 remaining items

greg-schroeder commented on Jul 31, 2023

melvin-bot commented on Jul 31, 2023

melvin-bot commented on Jul 31, 2023

melvin-bot commented on Jul 31, 2023

MonilBhavsar commented on Aug 7, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions