You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-08] [$1000] Dev: Web - Message is not center aligned vertically #23350
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Dev 1.3.43-4 Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-08. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@Santhosh-Sellaveldoes not require payment (Eligable for Manual Requests)
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: 👍
[@stitesExpensify ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
[@stitesExpensify] Determine if we should create a regression test for this bug. No. This was found before prod
[@stitesExpensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. n/a
[@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jul 21, 2023
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 21, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)samh-nl commentedon Jul 21, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The message is not center aligned vertically.
What is the root cause of that problem?
A gap is added after a message that causes this misalignment. This container is used for rendering reactions, which are not present.
What changes do you think we should make in order to solve the problem?
We should only render the
Viewcontainer inside the reactions component (or alternatively, the component itself) if there are reactions present.What alternative solutions did you explore? (Optional)
N/A
alitoshmatov commentedon Jul 21, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Message is not center aligned vertically
What is the root cause of that problem?
We are still rendering component which is responsible for showing emoji reactions and it has some padding applied to it
App/src/components/Reactions/ReportActionItemEmojiReactions.js
Line 73 in a9e26e5
And it is resulting in empty element being rendered, and it is taking some space:
What changes do you think we should make in order to solve the problem?
We should add condition and render
ReportActionItemEmojiReactionsonly if report action has any reaction:App/src/pages/home/report/ReportActionItem.js
Line 361 in 8dcad16
We can add condition like this:
_.isEmpty(props.emojiReactions)What alternative solutions did you explore? (Optional)
Nodebrute commentedon Jul 21, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Dev: Web - Message is not center aligned vertically
What is the root cause of that problem?
This component is getting rendered even when props.emojiReactions is empty
App/src/pages/home/report/ReportActionItem.js
Line 361 in 041d640
What changes do you think we should make in order to solve the problem?
We can conditionally render this when props.emojiReactions is not empty
What alternative solutions did you explore? (Optional)
Pujan92 commentedon Jul 21, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat Message is not aligned center vertically
What is the root cause of that problem?
As
ReportActionItemEmojiReactionswe are rendering without having the reactions also causing the issue of top margin of 8px.App/src/pages/home/report/ReportActionItem.js
Line 361 in 041d640
App/src/components/Reactions/ReportActionItemEmojiReactions.js
Lines 71 to 73 in 041d640
What changes do you think we should make in order to solve the problem?
Only render the
ViewforReportActionItemEmojiReactionswhen we have the reactions for the message.App/src/pages/home/report/ReportActionItem.js
Line 360 in 041d640
situchan commentedon Jul 21, 2023
Proposal from slack (@kbecciv missed pasting)
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat message is not center aligned vertically
What is the root cause of that problem?
Issue happens on this line:
App/src/components/Reactions/ReportActionItemEmojiReactions.js
Line 73 in bc7f689
So even if no reactions to show, 8px is always added
What changes do you think we should make in order to solve the problem?
Early return null if totalReactionCount = 0
For this, we should run _map code first to calculate totalReactionCount earlier than return null
anmurali commentedon Jul 24, 2023
I am OOO for 10 days. Rotating the assigner.
47 remaining items
melvin-bot commentedon Aug 1, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-08. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Aug 1, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Santhosh-Sellavel commentedon Aug 2, 2023
This was handled as a regression cc: @stitesExpensify please take care of the checklist!
stitesExpensify commentedon Aug 2, 2023
done
situchan commentedon Aug 13, 2023
@bfitzexpensify sorry for late. reporting bonus is missing here
situchan commentedon Oct 8, 2023
bump ^
bfitzexpensify commentedon Oct 9, 2023
Reopening this to action today
bfitzexpensify commentedon Oct 9, 2023
Offer sent @situchan
bfitzexpensify commentedon Oct 10, 2023
OK, payment complete, we can close this out again.