You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-08] Bank account - Personal information is cleared after returning to it from 'Connect BA' page #23408
Please re-state the problem that we are trying to solve in this issue.
The personal information is cleared when returning to it from the Connect bank account page
What is the root cause of that problem?
The personal information is stored in Onyx under key reimbursementAccountDraft, when clicking Continue on the Connect bank account page the backend resets this Onyx data, believing the bank account has changed:
What changes do you think we should make in order to solve the problem?
The backend should not reset the Onyx data as the bank account has not changed.
What alternative solutions did you explore? (Optional)
changed the title [-]Bank account - Personal information is cleared after returning to it from 'Connect BA' page[/-][+][HOLD for payment 2023-08-08] Bank account - Personal information is cleared after returning to it from 'Connect BA' page[/+]on Aug 1, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-08. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
This bug was caught by Applause team so I believe this test case is already in VBA flow in testrail and no more test case is needed. @trjExpensify can you please confirm?
This bug was caught by Applause team so I believe this test case is already in VBA flow in testrail and no more test case is needed. @trjExpensify can you please confirm?
Yup, it is! :)
Only payment due here is $1,000 for the C+ review of the internal PR by @situchan. I've sent you an offer on this job here.
Activity
melvin-bot commentedon Jul 22, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)samh-nl commentedon Jul 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The personal information is cleared when returning to it from the Connect bank account page
What is the root cause of that problem?
The personal information is stored in Onyx under key
reimbursementAccountDraft, when clicking Continue on the Connect bank account page the backend resets this Onyx data, believing the bank account has changed:What changes do you think we should make in order to solve the problem?
The backend should not reset the Onyx data as the bank account has not changed.
What alternative solutions did you explore? (Optional)
N/A
trjExpensify commentedon Jul 24, 2023
I can reproduce this one. Adding
EngineeringandInternalfor a second opinion on this being a backend issue.melvin-bot commentedon Jul 24, 2023
Triggered auto assignment to @Li357 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.melvin-bot commentedon Jul 24, 2023
Job added to Upwork: https://www.upwork.com/jobs/~011bb3d019d1ea96da
melvin-bot commentedon Jul 24, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @situchan (
Internal)Li357 commentedon Jul 24, 2023
Is this a bug if you did not hit "Save and Continue" to save the personal details? Do we always save optimistically?
5 remaining items
[-]Bank account - Personal information is cleared after returning to it from 'Connect BA' page[/-][+][HOLD for payment 2023-08-08] Bank account - Personal information is cleared after returning to it from 'Connect BA' page[/+]melvin-bot commentedon Aug 1, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 1, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-08. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Aug 1, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
trjExpensify commentedon Aug 7, 2023
@situchan can you get a head start on the checklist, please? Thanks!
situchan commentedon Aug 7, 2023
This bug was caught by Applause team so I believe this test case is already in VBA flow in testrail and no more test case is needed. @trjExpensify can you please confirm?
trjExpensify commentedon Aug 8, 2023
Yup, it is! :)
Only payment due here is $1,000 for the C+ review of the internal PR by @situchan. I've sent you an offer on this job here.
trjExpensify commentedon Aug 8, 2023
Settled up!