You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-07] [$1000] Web - Incorrect timezone with new account #23479
Click your avatar in a message, observe that the timezone displayed on the profile page and the timezone of the device are different
Expected Result:
The timezone on the profile page must be the same as the device's timezone
Actual Result:
Timezone displayed on the profile page show time PDT
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.44-0 Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
In the case the user logout and login with a new account, the timezone here stored value previous, so when login the backend return timezone is PDT so it not update because here:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR is eligible for bonus speed 🚀
Assignment: Jul 26 GMT+7
PR merged: Jul 27 GMT+7
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
No offending PR. This issue appears due to the migration on accountID.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
This is a one-time bug, so the regression test should be enough.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Open the App
Login with a new account
Open a new chat and send any message
Click your avatar in a message
Verify that the timezone displayed on the profile page and the timezone of the device are the same
Activity
melvin-bot commentedon Jul 24, 2023
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 24, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)kbecciv commentedon Jul 24, 2023
QA team is not allow to chat with Concierge
kbecciv commentedon Jul 24, 2023
Proposal
by @namhihi237
Please re-state the problem that we are trying to solve in this issue.
The timezone on the profile page must be the same as the device's timezone
What is the root cause of that problem?
We have 2 things here:
So here it will be undefined
App/src/libs/Navigation/AppNavigator/AuthScreens.js
Line 59 in cd851d0
This leads to not updating the timezone when the default login will be
PDTfrom the backend returned.App/src/libs/Navigation/AppNavigator/AuthScreens.js
Lines 64 to 68 in cd851d0
App/src/libs/Navigation/AppNavigator/AuthScreens.js
Lines 51 to 57 in cd851d0
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
N/A
[-]Web - Incorrect timezone with new account[/-][+][$1000] Web - Incorrect timezone with new account[/+]melvin-bot commentedon Jul 25, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01044ba0c87324c5d3
melvin-bot commentedon Jul 25, 2023
Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.
29 remaining items
melvin-bot commentedon Jul 31, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
garrettmknight commentedon Aug 7, 2023
@mollfpr can you work through the checklist? I'll pay out the rest of the issue now and when you're done with the list I'll tee your payment up.
mollfpr commentedon Aug 7, 2023
The PR is eligible for bonus speed 🚀
Assignment: Jul 26 GMT+7
PR merged: Jul 27 GMT+7
No offending PR. This issue appears due to the migration on
accountID.This is a one-time bug, so the regression test should be enough.
garrettmknight commentedon Aug 8, 2023
Summarizing payments for this issue:
Upwork job is here: https://www.upwork.com/jobs/~01044ba0c87324c5d3
garrettmknight commentedon Aug 14, 2023
mollfpr commentedon Aug 18, 2023
@garrettmknight I'm still not in the beta to receive payment in ND. So, we can stick with the Upwork for now.
garrettmknight commentedon Aug 18, 2023
Ah, cool. You've been paid and I've updated the comment.