You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] [$1000] Dev: Web - User is unable to authenticate with magic link #23504
Open email > copy magic link > paste it address bar > prefix the link with 'http://localhost:8080/' > press enter
Expected Result:
User should be authenticated
Actual Result:
User is not signed in
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Dev 1.3.44-0 Reproducible in staging?: no Reproducible in production?: no If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
// A fresh session will not have credentials.login
if(login){
User.validateLogin(accountID,validateCode);
return;
}
When we initiate the sign in flow, credentials.login is set, so User.validateLogin will always run as long as we stay in the same session. The issue is that User.validateLogin is actually the old password-based validation. You can see the purpose of the block a bit more clearly in this older commit:
Hmm, this probably should've been marked as a deploy blocker since it was (previously) only on dev and is indeed a regression from #22461 as @StevenKKC pointed out.
@kadiealexander Would any compensation be due for me here, as my proposal was used for the fix? (I just couldn't implement it due to being in the "wrong" timezone and the fix was needed urgently!)
Thanks Jason! I had this on my to-do for today. As discussed here we agreed to compensate @jjcoffee 50% of the job price as we used their proposal. The following payouts are due:
Activity
melvin-bot commentedon Jul 24, 2023
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 24, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)StevenKKC commentedon Jul 24, 2023
This seems to be a regression from this PR.
If remove the following code, user can be authenticated.
App/src/pages/ValidateLoginPage/index.website.js
Lines 64 to 68 in 85d84b8
kadiealexander commentedon Jul 25, 2023
@NikkiWines @srikarparsi @johnmlee101 could you please take a look and see if this is a regression from #22461?
Natnael-Guchima commentedon Jul 25, 2023
This is reproducible on staging too on the latest release.
2023-07-25.06.46.09.mp4
jjcoffee commentedon Jul 25, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Opening magic links should sign the user in.
What is the root cause of that problem?
This PR has introduced this bug here:
App/src/pages/ValidateLoginPage/index.website.js
Lines 64 to 68 in 972d0ad
When we initiate the sign in flow,
credentials.loginis set, soUser.validateLoginwill always run as long as we stay in the same session. The issue is thatUser.validateLoginis actually the old password-based validation. You can see the purpose of the block a bit more clearly in this older commit:App/src/pages/ValidateLoginPage/index.website.js
Lines 64 to 69 in 07f1768
What changes do you think we should make in order to solve the problem?
Remove this whole block as it was only there for password-based login:
App/src/pages/ValidateLoginPage/index.website.js
Lines 64 to 68 in 972d0ad
We also should remove the
if (!login)conditional here:App/src/pages/ValidateLoginPage/index.js
Lines 46 to 57 in 972d0ad
as we also don't want
User.validateLoginto run here either. See the older commit below for a clearer understanding of the block's original purpose:App/src/pages/ValidateLoginPage/index.js
Lines 46 to 56 in 453f0eb
NikkiWines commentedon Jul 25, 2023
Hmm, this probably should've been marked as a deploy blocker since it was (previously) only on dev and is indeed a regression from #22461 as @StevenKKC pointed out.
55 remaining items
Natnael-Guchima commentedon Aug 4, 2023
Accepted the offer. Thanks @kadiealexander
kadiealexander commentedon Aug 4, 2023
All paid! Please reopen if anything got missed.
allroundexperts commentedon Aug 4, 2023
@kadiealexander My payment for the C+ review is pending here.
jjcoffee commentedon Aug 4, 2023
@kadiealexander Would any compensation be due for me here, as my proposal was used for the fix? (I just couldn't implement it due to being in the "wrong" timezone and the fix was needed urgently!)
pecanoro commentedon Aug 4, 2023
@kadiealexander @NikkiWines Discussing the above message here: https://expensify.slack.com/archives/C01GTK53T8Q/p1691145123070889
JmillsExpensify commentedon Aug 8, 2023
Re-opening for confirmation on payment for @allroundexperts
kadiealexander commentedon Aug 8, 2023
Thanks Jason! I had this on my to-do for today. As discussed here we agreed to compensate @jjcoffee 50% of the job price as we used their proposal. The following payouts are due:
Eligible for 50% #urgency bonus? No
Upwork job is here.
kadiealexander commentedon Aug 8, 2023
@jjcoffee please let me know when you've accepted the Upwork contract.
JmillsExpensify commentedon Aug 8, 2023
No worries! Reviewed the details for @allroundexperts. This is approved for payment via NewDot.
jjcoffee commentedon Aug 8, 2023
@kadiealexander Accepted the offer, thanks!