Skip to content

[HOLD for payment 2024-06-06] [$2000] Wrong Image opens on HT Report in Safari #23546

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

1.Go to PROD.
2. Join the following channel https://new.expensify.com/r/8292963527436014
3. Scroll up and open shared images by users
4. After scrolling a little up again open some other image
5. Wrong image is displayed

Expected Result:

Correct image should be displayed

Actual Result:

Wrong image is displayed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

wrong-image-ht.mov

Expensify/Expensify Issue URL:
Issue reported by: @Talha345
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690065844572829

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012f0ed142cb12018c
  • Upwork Job ID: 1685003651569020928
  • Last Price Increase: 2023-09-11
  • Automatic offers:
    • Talha345 | Reporter | 26772303
Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 25, 2023
  2. melvin-bot commented on Jul 25, 2023

    @melvin-bot

    Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 25, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Jul 28, 2023
  5. changed the title [-]Wrong Image opens on HT Report in Safari[/-] [+][$1000] Wrong Image opens on HT Report in Safari[/+] on Jul 28, 2023
  6. melvin-bot commented on Jul 28, 2023

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 28, 2023
  8. melvin-bot commented on Jul 28, 2023

    @melvin-bot

    Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

  9. melvin-bot commented on Jul 28, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  10. 283 remaining items

  11. CortneyOfstad commented on Jun 5, 2024

    @CortneyOfstad
    Contributor

    @parasharrajat can you complete the checklist before tomorrow so there is no delay in payment? Thanks!

  12. parasharrajat commented on Jun 5, 2024

    @parasharrajat
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: None, it is an issue with FlatList on Safari.
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
    • [@parasharrajat] Determine if we should create a regression test for this bug. yes
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Steps

    1. Open a chat with multiple attachments.
    2. Open and close several attachments randomly.
    3. Confirm that the attachment carousel always opens with the attachment that was selected.

    Do you agree 👍 or 👎 ?

  13. CortneyOfstad commented on Jun 5, 2024

    @CortneyOfstad
    Contributor

    @parasharrajat can you complete the checklist before tomorrow so there is no delay in payment?

    Also, at @mikesmnx can you link your Upwork profile so I can send you a payment contract? After discussing it with the team, it was decided to offer you 25% for your initial work on this. Thanks!

  14. parasharrajat commented on Jun 5, 2024

    @parasharrajat
    Member

    @CortneyOfstad I already did. Is there something else that I can help with?

  15. CortneyOfstad commented on Jun 5, 2024

    @CortneyOfstad
    Contributor

    Sorry, there was a glitch that caused my edited comment to then post on it's own — sorry for the confusion!

  16. parasharrajat commented on Jun 5, 2024

    @parasharrajat
    Member

    No worries. Thanks.

  17. mikesmnx commented on Jun 5, 2024

    @mikesmnx

    Also, at @mikesmnx can you link your Upwork profile so I can send you a payment contract? After discussing it with the team, it was decided to offer you 25% for your initial work on this. Thanks!

    @CortneyOfstad https://www.upwork.com/freelancers/~01ae736e03e7dce34c

  18. parasharrajat commented on Jun 5, 2024

    @parasharrajat
    Member

    @mikesmnx Please close your old PR. Thanks.

  19. CortneyOfstad commented on Jun 6, 2024

    @CortneyOfstad
    Contributor

    @mikesmnx and @Talha345 — I've sent you both offers in Upwork. Please let me know once you accept and I'll get those paid ASAP. Thanks!

  20. Talha345 commented on Jun 6, 2024

    @Talha345
    Contributor

    @mikesmnx and @Talha345 — I've sent you both offers in Upwork. Please let me know once you accept and I'll get those paid ASAP. Thanks!

    @CortneyOfstad Offer accepted!

  21. CortneyOfstad commented on Jun 6, 2024

    @CortneyOfstad
    Contributor

    Regression test created (here) so doing the payment summary now!

  22. CortneyOfstad commented on Jun 6, 2024

    @CortneyOfstad
    Contributor

    Payment Summary

    @kidroca — contracted
    @parasharrajat — to be paid $2,000 via NewDot
    @mikesmnx — paid $500 via Upwork (decided on 25% payout due to original PR creation and review process)
    @Talha345 — paid $250 for reporting (GH was created pre-pricing change)

    Thanks all and great work!

  23. parasharrajat commented on Jun 10, 2024

    @parasharrajat
    Member

    Payment requested as per #23546 (comment)

  24. JmillsExpensify commented on Jun 11, 2024

    @JmillsExpensify
    Contributor

    $2,000 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions