[Awaiting C+ payment] [$1000] App crashes on login after opening split bill details page

@dhanashree-sawant

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Click on plus and click on split bill
Enter any amount and continue
Select any 1 user and complete the split bill process
In the user report, click on split bill message to open split bill details page
Copy the URL, logout, paste the URL and login again, eg URL format: https://staging.new.expensify.com/r/5686244339424710/split/2464435729537161526
Observe that app crashes

Expected Result:

App should not crash when we open split bill details page

Actual Result:

App crashes when we logout and login with split bill details page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.45-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

crash.on.split.bill.URL.open.mp4

Recording.1336.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690262928105189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0168304d5ea41d503d
Upwork Job ID: 1684650192147705856
Last Price Increase: 2023-07-27
Automatic offers:

dukenv0307 | Contributor | 25865336
dhanashree-sawant | Reporter | 25865338

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes on login after opening split bill details page

What is the root cause of that problem?

When we open split bill page by deep link, we use HOC withReportOrNotFound to display loading page if openApp API is calling

But after this API is complete, props.reportActions still is empty because it must wait openReport API is complete. That makes reportAction is empty and the app crashes when we get participantAccountIDs from reportAction

App/src/pages/iou/SplitBillDetailsPage.js

Lines 66 to 70 in 031b4a3

    
           const reportAction = props.reportActions[`${props.route.params.reportActionID.toString()}`]; 
        
           const participantAccountIDs = reportAction.originalMessage.participantAccountIDs; 
        
           const participants = OptionsListUtils.getParticipantsOptions( 
        
               _.map(participantAccountIDs, (accountID) => ({accountID, selected: true})), 
        
               props.personalDetails,

What changes do you think we should make in order to solve the problem?

We should display loading page until both report data and report action data are loaded completely

Remove the HOC withReportOrNotFound, subscribe report and isLoadingReportData from Onyx
We should add the check to return loading page before this line

const isLoadingInitialReport = props.isLoadingReportData && _.isEmpty(props.report);
const isLoadingInitialReportActions = _.isEmpty(props.reportActions) || (props.report.isLoadingReportActions && _.isEmpty(reportAction);
const isExistReport = isLoadingInitialReport || (!_.isEmpty(props.report) && props.report.reportID);

const shouldShowLoading = (isLoadingInitialReport || isLoadingInitialReportActions) && isExistReport;
if (shouldShowLoading) {
    return <FullscreenLoadingIndicator />;
}

App/src/pages/iou/SplitBillDetailsPage.js

Line 67 in 031b4a3

    
           const participantAccountIDs = reportAction.originalMessage.participantAccountIDs;

We also should bring the not found page before this line because with reportActionID is invalid or not found , App also crashes

if (_.isEmpty(reportAction) || _.isEmpty(props.report)) {
    return (
        <FullPageNotFoundView shouldShow/>
    )
}

App/src/pages/iou/SplitBillDetailsPage.js

Line 67 in 031b4a3

    
           const participantAccountIDs = reportAction.originalMessage.participantAccountIDs;

What alternative solutions did you explore? (Optional)

NA

Result

Screencast-from-26-07-2023-01_38_16.mp4

@dukenv0307

👋 @dukenv0307 how related is this to this issue? CC: @aldo-expensify

@trjExpensify

@trjExpensify This issue and #21268 are different issue because the root cause is different.

@dukenv0307

If the root cause @dukenv0307 explained here is correct, they do appear unrelated to me.

Cool, will move on external for now! :)

Job added to Upwork: https://www.upwork.com/jobs/~0168304d5ea41d503d

@trjExpensify

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

@mananjadhav

@mananjadhav Open the PR to see more detail.

@mananjadhav

@mananjadhav Update: I updated HOC to resolve the problem above, please help to review the PR when you have a chance.

@mananjadhav

🎯 ⚡️ Woah @mananjadhav / @dukenv0307, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

when @dukenv0307 got assigned: 2023-07-31 20:53:43 Z
when the PR got merged: 2023-08-02 19:31:42 UTC

On to the next one 🚀

@trjExpensify

@trjExpensify This is ready for payout on 08/15 but the title wasn't updated.

Also I couldn't pinpoint to a specific PR causing this. I think we should add a regression test for this one as it is was crashing the app and related to IOU. The test steps from the PR are good enough for the regression test.

@Li357 wdyt?

Updated the title! :)

I think we should add a regression test for this one as it is was crashing the app and related to IOU. The test steps from the PR are good enough for the regression test.

Yeah cool, I'll ask Applause about what they think is best re: opening from deep links. We should do the same with request money as well.

Makes sense.

@dhanashree-sawant

Okay, confirming payments as follows:

@dhanashree-sawant $250 for the bug report (paid!)
@mananjadhav $1,500 for C+ & #urgency bonus (awaiting a request)
@dukenv0307 $1,500 for the fix (paid!)

I’ve raised my request on NewDot.

@mananjadhav

Reviewed the details for @mananjadhav. Approved for payment in NewDot based on BZ summary above.

Dope, we're all set then. Closing!

Navigation Menu

Repository navigation

[Awaiting C+ payment] [$1000] App crashes on login after opening split bill details page #23568

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

22 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const reportAction = props.reportActions[`${props.route.params.reportActionID.toString()}`];
	const participantAccountIDs = reportAction.originalMessage.participantAccountIDs;
	const participants = OptionsListUtils.getParticipantsOptions(
	_.map(participantAccountIDs, (accountID) => ({accountID, selected: true})),
	props.personalDetails,

[Awaiting C+ payment] [$1000] App crashes on login after opening split bill details page #23568

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jul 25, 2023

melvin-bot commented on Jul 25, 2023

Bug0 Triage Checklist (Main S/O)

dukenv0307 commented on Jul 25, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

trjExpensify commented on Jul 27, 2023

dukenv0307 commented on Jul 27, 2023

aldo-expensify commented on Jul 27, 2023

trjExpensify commented on Jul 27, 2023

melvin-bot commented on Jul 27, 2023

melvin-bot commented on Jul 27, 2023

22 remaining items

dukenv0307 commented on Aug 1, 2023

dukenv0307 commented on Aug 1, 2023

melvin-bot commented on Aug 2, 2023

mananjadhav commented on Aug 13, 2023

trjExpensify commented on Aug 14, 2023

mananjadhav commented on Aug 14, 2023

trjExpensify commented on Aug 15, 2023

mananjadhav commented on Aug 15, 2023

JmillsExpensify commented on Aug 15, 2023

trjExpensify commented on Aug 15, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions