Repository navigation
[HOLD for payment 2023-11-29] [$1000] Removed reactions on offline mode re appear on the receiver account and there is no way to remove them #23679
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open two new accounts on ND
- Start a chat with each other
- Go offline (disconnecting from the device required)
- React with 👍 on account A to the last message posted
- React with 👍 on account B to the last message
- Remove both the reactions from account A and account B
- Go online
Expected Result:
There should be no reaction on the last message
Actual Result:
Account B shows the 👍 reaction on the last message sent, it says that account A reacted on it, but when opening account A the reaction is not there.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.46-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
2023-07-25.09.56.43.mp4
Recording.1361.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690268434954109
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~015cd66a26c22a758e
- Upwork Job ID: 1694287577039745024
- Last Price Increase: 2023-11-08
- Automatic offers:
- aimane-chnaif | Reviewer | 27582689
- barros001 | Contributor | 27582692
- nathan-mulugeta | Reporter | 27582695
Activity
melvin-bot commentedon Jul 26, 2023
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 26, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)StevenKKC commentedon Jul 26, 2023
Dupe of #23388
melvin-bot commentedon Jul 31, 2023
@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...
mallenexpensify commentedon Jul 31, 2023
Was able to reproduce, I fully turned off my wifi when doing so. For the user that is still showing as having sent the 👍, they can click the 👍 emoji twice to remove it (if that matters).
melvin-bot commentedon Aug 4, 2023
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Aug 8, 2023
@mallenexpensify Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Aug 9, 2023
@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Aug 10, 2023
@mallenexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
101 remaining items
[-][$1000] Removed reactions on offline mode re appear on the receiver account and there is no way to remove them[/-][+][HOLD for payment 2023-11-29] [$1000] Removed reactions on offline mode re appear on the receiver account and there is no way to remove them[/+]melvin-bot commentedon Nov 22, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.1-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 22, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mallenexpensify commentedon Nov 28, 2023
@aimane-chnaif can you please complete the checklist above? Thx
aimane-chnaif commentedon Nov 29, 2023
I think this bug existed for long time. Not able to find offending PR.
Regression Test Proposal
mallenexpensify commentedon Nov 29, 2023
Bug reporter: @Nathan-Mulugeta paid $250 via Upwork (report was from wayyyyyy back)
Contributor: @barros001 paid $1000 via Upwork
Contributor+: @aimane-chnaif paid $1000 via Upwork
Thanks @aimane-chnaif I agree with
Created the testrail update GH
https://github.com/Expensify/Expensify/issues/340437
nyomanjyotisa commentedon Sep 21, 2026
The shared Pusher promise chain introduced in #31144 lacked rejection recovery, causing #100174: one failed apply prevented subsequent Pusher updates from running for the rest of the session. Fixed in #100594 with chain recovery and watermark continuity protection.