Repository navigation
[HOLD for payment 2023-08-10] [$1000] Android - Emoji - App crashes after selecting Emoji icon that is above the "Frequently used label" #23716
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Access a conversation chat with another user.
- Long press on any of your messages.
- Tap the "emoji reaction" icon.
- Tap the "emoji" icon that is above the "Frequently used label".
Expected Result:
The app should not crash.
Actual Result:
The app crashes.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: v1.3.46-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6143286_App_crashes_after_selecting_Emoji_icon_that_is_above_the_Frequently_used_label.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0165450f4a10937496
- Upwork Job ID: 1684677319871397888
- Last Price Increase: 2023-07-27
Activity
OSBotify commentedon Jul 27, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 27, 2023
Triggered auto assignment to @Gonals (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.hungvu193 commentedon Jul 27, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android - Emoji - App crashes after selecting Emoji icon that is above the "Frequently used label"
What is the root cause of that problem?
Problem came from this line:
App/src/components/EmojiPicker/EmojiPickerMenu/index.native.js
Line 6 in f8bc305
We're importing the wrong function which didn't exist.
What changes do you think we should make in order to solve the problem?
Remove usage of _scrollTo
We can use
this.emojiList.scrollToOffset({ offset: calculatedOffset, animated: true })insteadWhat alternative solutions did you explore? (Optional)
N/A
shubham1206agra commentedon Jul 27, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android - Emoji - App crashes after selecting Emoji icon that is above the "Frequently used label"
What is the root cause of that problem?
In this line:
App/src/components/EmojiPicker/EmojiPickerMenu/index.native.js
Line 6 in f8bc305
Since the
react-native-reanimatedis bumped to v3.4.0 in #23550. The function_scrollTowas removed, and we are forced to usescrollTofunction instead. Due to this, the function not found was shown.What changes do you think we should make in order to solve the problem?
Since
scrollTorequires the use ofuseAnimatedReffor the first argument. We will first quickly migrate this component to a functional component. And replace withscrollTosince this is the function recommended byreact-native-reanimated.What alternative solutions did you explore? (Optional)
N/A
shubham1206agra commentedon Jul 27, 2023
@Gonals BTW, this issue is also reproducible on iOS.
And I have tested my solution. Works without any problem :)
marcaaron commentedon Jul 27, 2023
revert fix tests well removing the blocker.
stitesExpensify commentedon Jul 27, 2023
We should still switch this to a functional component so that we can upgrade our version of reanimated. Marking this external to get a C+
28 remaining items
[-][$1000] Android - Emoji - App crashes after selecting Emoji icon that is above the "Frequently used label"[/-][+][HOLD for payment 2023-08-10] [$1000] Android - Emoji - App crashes after selecting Emoji icon that is above the "Frequently used label"[/+]melvin-bot commentedon Aug 3, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 3, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
EmojiPickerMenunative to functional component and usingscrollTomethod #23854If no regressions arise, payment will be issued on 2023-08-10. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
mananjadhav commentedon Aug 8, 2023
This was more of a fix related to upgrading the reanimated version and not a dev bug per say. Hence there is no offending PR.
I also don't think we should be adding a regression test for this one. The EmojiPicker should already consist of the tests for this.
jliexpensify commentedon Aug 9, 2023
Great, here's a Payment Summary:
Upworks job
mananjadhav commentedon Aug 10, 2023
@jliexpensify I've raised my request on NewDot.
JmillsExpensify commentedon Aug 10, 2023
Reviewed the details for @mananjadhav. This is approved for payment in NewDot.
jliexpensify commentedon Aug 11, 2023
Job closed in Upworks!