Skip to content

[HOLD for payment 2023-08-17] [$1000] Web - Inconsistent display format for phone number contact in members page of workspace and room #23724

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Precondition: Either logged in user should have primary account as phone number or logged user should have common workspace with user having primary account as phone number

  1. Open the app
  2. Open workspace room which has user with phone number as primary contact
  3. Click on header to open details page
  4. Click on members and observe the format of phone number contact displayed below display name of that user
  5. Click on back and click on workspace name
  6. Click on members and observe the format of phone number contact displayed below display name of that user, it is different then the one in step 4

Expected Result:

App should display phone number contact in newer format throughout the app on details pages

Actual Result:

App displays phone number contact in older format on room members page causing inconsistency in format between room members page and workspace members page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.45-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3927.mp4
inconsistent.number.format.room.workspace.mp4

Expensify/Expensify Issue URL:
Issue reported by: GH handle - @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690377835176189

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01584c3a7472629000
  • Upwork Job ID: 1687057935942258688
  • Last Price Increase: 2023-08-03
  • Automatic offers:
    • fedirjh | Reviewer | 25991568
    • samh-nl | Contributor | 25991575

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 27, 2023
  2. melvin-bot commented on Jul 27, 2023

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 27, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. samh-nl commented on Jul 27, 2023

    @samh-nl
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Inconsistent display format for phone number contact in members page of workspace and room

    What is the root cause of that problem?

    On the workspace members page, the phone number is formatted using formatPhoneNumber provided by the withLocalize HOC.

    text: props.formatPhoneNumber(item.displayName),
    alternateText: props.formatPhoneNumber(item.login),

    However, this is not the case for rooms (ReportParticipantsPage):

    const userLogin = Str.removeSMSDomain(userPersonalDetail.login || '') || translate('common.hidden');

    login: userLogin,

    What changes do you think we should make in order to solve the problem?

    We should consistently apply the formatPhoneNumber function for displaying phone numbers.

    What alternative solutions did you explore? (Optional)

    N/A

  5. c3024 commented on Jul 27, 2023

    @c3024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Login text is different in members page in workspace and in room members page

    What is the root cause of that problem?

    We are using

    const userLogin = Str.removeSMSDomain(userPersonalDetail.login || '') || translate('common.hidden');

    in ReportParticipantsPage where as we need to use the standard LocalePhoneNumber.formatPhoneNumber to format the number.

    What changes do you think we should make in order to solve the problem?

    We should change the above line to

    const userLogin = LocalePhoneNumber.formatPhoneNumber(userPersonalDetail.login || '') || translate('common.hidden');

    and import

    import * as LocalePhoneNumber from '../libs/LocalePhoneNumber';

    in ReportParticipantsPage

    What alternative solutions did you explore? (Optional)

  6. dylanexpensify commented on Jul 31, 2023

    @dylanexpensify
    Contributor

    reviewing today!

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Aug 3, 2023
  8. changed the title [-]Web - Inconsistent display format for phone number contact in members page of workspace and room[/-] [+][$1000] Web - Inconsistent display format for phone number contact in members page of workspace and room[/+] on Aug 3, 2023
  9. 28 remaining items

  10. melvin-bot commented on Aug 10, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Aug 10, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-17. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  12. melvin-bot commented on Aug 10, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
    • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@fedirjh] Determine if we should create a regression test for this bug.
    • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. dylanexpensify commented on Aug 11, 2023

    @dylanexpensify
    Contributor

    Great work here!

  14. fedirjh commented on Aug 17, 2023

    @fedirjh
    Contributor

    BugZero Checklist:

  15. dylanexpensify commented on Aug 18, 2023

    @dylanexpensify
    Contributor

    Payment summary:

    Upwork job. Please apply!

  16. dhanashree-sawant commented on Aug 19, 2023

    @dhanashree-sawant

    Hi @dylanexpensify, If possible, can you send me invite to the job?

  17. dylanexpensify commented on Aug 25, 2023

    @dylanexpensify
    Contributor

    Payments sent @fedirjh and @samh-nl! @dhanashree-sawant invite to job sent!

  18. dylanexpensify commented on Sep 1, 2023

    @dylanexpensify
    Contributor

    Offer waiting to be accepted @dhanashree-sawant!

  19. dhanashree-sawant commented on Sep 2, 2023

    @dhanashree-sawant

    Thanks @dylanexpensify, I have accepted the offer.

  20. dylanexpensify commented on Sep 11, 2023

    @dylanexpensify
    Contributor

    Paying out!

  21. dylanexpensify commented on Sep 20, 2023

    @dylanexpensify
    Contributor

    all done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions