You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-17] [$1000] Web - Inconsistent display format for phone number contact in members page of workspace and room #23724
Precondition: Either logged in user should have primary account as phone number or logged user should have common workspace with user having primary account as phone number
Open the app
Open workspace room which has user with phone number as primary contact
Click on header to open details page
Click on members and observe the format of phone number contact displayed below display name of that user
Click on back and click on workspace name
Click on members and observe the format of phone number contact displayed below display name of that user, it is different then the one in step 4
Expected Result:
App should display phone number contact in newer format throughout the app on details pages
Actual Result:
App displays phone number contact in older format on room members page causing inconsistency in format between room members page and workspace members page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.45-7 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Web - Inconsistent display format for phone number contact in members page of workspace and room[/-][+][$1000] Web - Inconsistent display format for phone number contact in members page of workspace and room[/+]on Aug 3, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Link to discussion: This is not a regression, It's a missed case from a new feature implementation.
Determine if we should create a regression test for this bug: I don't think we should require a regression test for this case, It's not truly a bug, but rather an inconsistency.
Activity
melvin-bot commentedon Jul 27, 2023
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 27, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)samh-nl commentedon Jul 27, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistent display format for phone number contact in members page of workspace and room
What is the root cause of that problem?
On the workspace members page, the phone number is formatted using
formatPhoneNumberprovided by thewithLocalizeHOC.App/src/pages/workspace/WorkspaceMembersPage.js
Lines 329 to 330 in f8bc305
However, this is not the case for rooms (
ReportParticipantsPage):App/src/pages/ReportParticipantsPage.js
Line 63 in f8bc305
App/src/pages/ReportParticipantsPage.js
Line 78 in f8bc305
What changes do you think we should make in order to solve the problem?
We should consistently apply the
formatPhoneNumberfunction for displaying phone numbers.What alternative solutions did you explore? (Optional)
N/A
c3024 commentedon Jul 27, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Login text is different in members page in workspace and in room members page
What is the root cause of that problem?
We are using
in
ReportParticipantsPagewhere as we need to use the standardLocalePhoneNumber.formatPhoneNumberto format the number.What changes do you think we should make in order to solve the problem?
We should change the above line to
and import
in
ReportParticipantsPageWhat alternative solutions did you explore? (Optional)
dylanexpensify commentedon Jul 31, 2023
reviewing today!
[-]Web - Inconsistent display format for phone number contact in members page of workspace and room[/-][+][$1000] Web - Inconsistent display format for phone number contact in members page of workspace and room[/+]28 remaining items
melvin-bot commentedon Aug 10, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Aug 10, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
dylanexpensify commentedon Aug 11, 2023
Great work here!
fedirjh commentedon Aug 17, 2023
BugZero Checklist:
dylanexpensify commentedon Aug 18, 2023
Payment summary:
Upwork job. Please apply!
dhanashree-sawant commentedon Aug 19, 2023
Hi @dylanexpensify, If possible, can you send me invite to the job?
dylanexpensify commentedon Aug 25, 2023
Payments sent @fedirjh and @samh-nl! @dhanashree-sawant invite to job sent!
dylanexpensify commentedon Sep 1, 2023
Offer waiting to be accepted @dhanashree-sawant!
dhanashree-sawant commentedon Sep 2, 2023
Thanks @dylanexpensify, I have accepted the offer.
dylanexpensify commentedon Sep 11, 2023
Paying out!
dylanexpensify commentedon Sep 20, 2023
all done!