[HOLD for payment 2023-09-21] [HOLD] [$1000] Chat - LHN page displayed instead Legal name page when using deeplink

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Login in the same account in 2 platform (mWeb/Safari and iOS app)
Go to Settings -> Profile -> Personal details -> Legal name -> Copy the URL of page (mWeb/Safari)
Paste URL in another program
Log out in iOS app
Open the URL that was copied in step 2
Login with same account

Expected Result:

App navigates user to the Legal name page

Actual Result:

LHN displayed instead of the Legal name page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.46-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1690559564.MP4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01327557008996edfb
Upwork Job ID: 1688707539214979072
Last Price Increase: 2023-08-08
Automatic offers:

mollfpr | Reviewer | 26045352

@jliexpensify

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kbecciv

@kbecciv I think the task description does not conform with the video atatched. Can you please recheck and clarify?

@Talha345

Agree with @Talha345 . @kbecciv please re-test and attach the correct video and re-open this GH.

@jliexpensify

Hey @jliexpensify Checking

@jliexpensify

@jliexpensify Sorry about confusion, steps and video have been updated. Thank you

@kbecciv

@kbecciv sorry I am still confused: you mentioned that this is for the IOS app but you've also checked Android. So is this an iOS issue or an Android one?

@kbecciv

Bumop @kbecciv - is this an iOS issue only or for both platforms? Thanks.

Reviewing label has been removed, please complete the "BugZero Checklist".

@kubabutkiewicz

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix/deeplinks when app in background #26073

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@kubabutkiewicz does not require payment (Contractor)
@mollfpr requires payment offer (Reviewer)
@lukemorawski does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@mollfpr

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@mollfpr

Bump @mollfpr to complete the checklist!

@mollfpr

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

#15788

[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/15788/files#r1330344843

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Make sure the app is in the background mode (only for iOS or Android)
Make sure you are logged out
Open the app from whatever deep link
Log in
You should be redirected to the screen that you provided in the deep link
👍 or 👎

@jliexpensify

Friendly bump @jliexpensify

@lukemorawski

Thanks for the bump - payment summary:

Contributor: @lukemorawski $1000 (Invoicing), according to the PR. It doesn't look like @kubabutkiewicz worked on it.
Contributor: @tienifr $250 (special payment, discussed here)
C+: @mollfpr $1000

Upworks job

Am I missing anything?

@jliexpensify

@jliexpensify I already have the Upwork contract for this issue.

@mollfpr

Yep, I'm aware @mollfpr - I generally do a payment summary for every job now, to make sure that I'm paying the correct amounts. Will pay via Upworks now.

All paid, job closed

Navigation Menu

Repository navigation

[HOLD for payment 2023-09-21] [HOLD] [$1000] Chat - LHN page displayed instead Legal name page when using deeplink #23745

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

81 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-09-21] [HOLD] [$1000] Chat - LHN page displayed instead Legal name page when using deeplink #23745

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jul 27, 2023

melvin-bot commented on Jul 27, 2023

Bug0 Triage Checklist (Main S/O)

Talha345 commented on Jul 27, 2023

jliexpensify commented on Jul 27, 2023

kbecciv commented on Jul 28, 2023

kbecciv commented on Jul 28, 2023

jliexpensify commented on Jul 31, 2023

jliexpensify commented on Aug 1, 2023

81 remaining items

melvin-bot commented on Sep 14, 2023

melvin-bot commented on Sep 14, 2023

melvin-bot commented on Sep 14, 2023

jliexpensify commented on Sep 18, 2023

mollfpr commented on Sep 19, 2023

mollfpr commented on Sep 22, 2023

jliexpensify commented on Sep 22, 2023

mollfpr commented on Sep 22, 2023

jliexpensify commented on Sep 22, 2023

jliexpensify commented on Sep 22, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions