[HOLD for payment 2023-08-17] [$1000] Web - Emoji count and details are not dynamically updating when reactions are added

@Nathan-Mulugeta

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Send a message from account A to account B
On account A, react with 👍
Right click on the reacted emoji to open the details modal
On account B click on the 👍 to add to the reaction
Go to account A and check the details modal

Expected Result:

Details modal should update showing the added reaction count and the account which reacted

Actual Result:

Details modal doesn't update dynamically

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.46-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-26.21.28.26.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690396271150109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0103b055021bf558bd
Upwork Job ID: 1684996447830929408
Last Price Increase: 2023-07-28
Automatic offers:

s77rt | Reviewer | 25876690
tienifr | Contributor | 25876692
Nathan-Mulugeta | Reporter | 25876693

@NicMendonca

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji count and details are not dynamically updating when reactions are added

What is the root cause of that problem?

When we open the popover, we explicitly pass the reactions:

App/src/components/Reactions/ReportActionItemEmojiReactions.js

Line 99 in f3196c1

    
           reactionListRef.current.showReactionList(event, popoverReactionListAnchor.current, reaction);

However, if this information changes, the popover will be unaware of it.

What changes do you think we should make in order to solve the problem?

Move PopoverReactionList to ReportActionItem and pass all reactions (props.emojiReactions) as a prop.
We should define const reactionListRef = useRef(null); here instead of using context and pass the ref to ReportActionItemEmojiReactions.
reactionListRef.current.showReactionList should pass reaction.emojiName instead of reaction.

Subsequently, we can filter the passed emojiReactions for the relevant emoji.

What alternative solutions did you explore? (Optional)

N/A

Duplicate of #23746

I think the issue you have linked is the dupe, this issue was reported on slack yesterday.

Job added to Upwork: https://www.upwork.com/jobs/~0103b055021bf558bd

@NicMendonca

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

Reviewing label has been removed, please complete the "BugZero Checklist".

@s77rt

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Popover reaction list does not update dynamically #24024

If no regressions arise, payment will be issued on 2023-08-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@s77rt requires payment offer (Reviewer)
@tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@s77rt

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The PR that introduced the bug has been identified: fixed: dev: '0:undefined:' displayed in reaction emoji tooltip #23371
The offending PR has been commented on: fixed: dev: '0:undefined:' displayed in reaction emoji tooltip #23371 (comment)
A discussion in #expensify-bugs has been started: Not needed as there is not much to discuss, the regression could have been caught during PR review/test
Determine if we should create a regression test for this bug: No

@Nathan-Mulugeta

Reporter: @Nathan-Mulugeta - $250
Contributor: @tienifr - $1,000
Contributor+: @s77rt - $1,000

Everyone has been paid 🎉

Navigation Menu

Repository navigation

[HOLD for payment 2023-08-17] [$1000] Web - Emoji count and details are not dynamically updating when reactions are added #23752

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

24 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-08-17] [$1000] Web - Emoji count and details are not dynamically updating when reactions are added #23752

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jul 27, 2023

melvin-bot commented on Jul 27, 2023

Bug0 Triage Checklist (Main S/O)

samh-nl commented on Jul 27, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

samh-nl commented on Jul 27, 2023

Nathan-Mulugeta commented on Jul 27, 2023

melvin-bot commented on Jul 28, 2023

melvin-bot commented on Jul 28, 2023

24 remaining items

melvin-bot commented on Aug 10, 2023

melvin-bot commented on Aug 10, 2023

melvin-bot commented on Aug 10, 2023

s77rt commented on Aug 13, 2023

NicMendonca commented on Aug 21, 2023

NicMendonca commented on Aug 21, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions