Skip to content

[HOLD for payment 2023-08-16] [$1000] Message with button gets cut off early for certain length of emails #23769

New issue
New issue
Closed
Closed
[HOLD for payment 2023-08-16] [$1000] Message with button gets cut off early for certain length of emails#23769
Assignees
puneetlathgarrettmknightOllywsahmedGaber93
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Description

@kavimuru
kavimuru
opened on Jul 27, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open ND on android
  2. Click on FAB > split bill > enter an amount
  3. Share with account emails which are not renamed (for easier reproduction use these emails for testing nathanmulugetatesting+123@gmail.com, nathanmulugetatesting+1234@gmail.com, nathanmulugetatesting+12345@gmail.com)
  4. Split the bill
  5. Click on the IOU card
  6. Select one of the contacts from the side panel
  7. Observe the Message with button

Expected Result:

Message with button should not be cut off early

Actual Result:

Message with button gets cut off early.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.47-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230727_104300_New.Expensify.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690444037073499

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013be117aa6991d578
  • Upwork Job ID: 1685001865802149888
  • Last Price Increase: 2023-07-28
  • Automatic offers:
    • Ollyws | Contributor | 25886833
    • ahmedGaber93 | Contributor | 25909402
    • nathan-mulugeta | Reporter | 25909403

Activity

  1. kavimuru
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 27, 2023
  2. melvin-bot
    assigned
    garrettmknight
    on Jul 27, 2023

  3. melvin-bot commented on Jul 27, 2023

    @melvin-bot
    melvin-botBot
    on Jul 27, 2023

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Jul 27, 2023

    @melvin-bot
    melvin-botBot
    on Jul 27, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  5. ahmedGaber93 commented on Jul 27, 2023

    @ahmedGaber93
    ahmedGaber93
    on Jul 27, 2023
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Message with button gets cut off early for certain length of emails

    What is the root cause of that problem?

    The root cause is android use different way to break words, see here and textbreakstrategy explanation here
    the problem is all android textbreakstrategy need flex 1 style to work fine.

    Message longEmailxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx@gmail.com

// will break to
Message 
longEmailxxxxxxxxxxxxxxxxxxxxx
xxxxxxxxxxxxxxxxxxx@gmail.com

// with numberOfLines 1 will be
Message ...

    What changes do you think we should make in order to solve the problem?

    pass style styles.flex1 in props.titleStyle will fix the issue.
    we need to pass it in two places DetailsPage and the ProfilePage

    What alternative solutions did you explore? (Optional)

    we can add style styles.flex1 to titleTextStyle here, but this will affect on the next icon here to move to right.

  6. garrettmknight commented on Jul 28, 2023

    @garrettmknight
    garrettmknight
    on Jul 28, 2023
    Contributor

    Confirmed on browserstack

  7. garrettmknight
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 28, 2023
  8. melvin-bot
    changed the title [-]Message with button gets cut off early for certain length of emails[/-] [+][$1000] Message with button gets cut off early for certain length of emails[/+] on Jul 28, 2023

  9. melvin-bot commented on Jul 28, 2023

    @melvin-bot
    melvin-botBot
    on Jul 28, 2023

    Job added to Upwork: https://www.upwork.com/jobs/~013be117aa6991d578

  10. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 28, 2023

  11. melvin-bot commented on Jul 28, 2023

    @melvin-bot
    melvin-botBot
    on Jul 28, 2023

    Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

  12. melvin-bot
    assigned
    Santhosh-Sellavel
    on Jul 28, 2023

  13. melvin-bot commented on Jul 28, 2023

    @melvin-bot
    melvin-botBot
    on Jul 28, 2023

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

  14. Santhosh-Sellavel commented on Jul 28, 2023

    @Santhosh-Sellavel
    Santhosh-Sellavel
    on Jul 28, 2023
    Collaborator

    Seems like a regression to me, couldn't find any PR. It's hard to reproduce, needs a proper root cause here why it occurs thanks!

  15. 34 remaining items

  16. melvin-bot commented on Aug 9, 2023

    @melvin-bot
    melvin-botBot
    on Aug 9, 2023

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-16. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty

  17. melvin-bot commented on Aug 9, 2023

    @melvin-bot
    melvin-botBot
    on Aug 9, 2023

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
    • [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Ollyws] Determine if we should create a regression test for this bug.
    • [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  18. Ollyws commented on Aug 15, 2023

    @Ollyws
    Ollyws
    on Aug 15, 2023
    Contributor

  19. garrettmknight commented on Aug 16, 2023

    @garrettmknight
    garrettmknight
    on Aug 16, 2023
    Contributor

    @Ollyws have you started a discussion around regression or created a regression test? Once you do, I'll process payment on this issue.

  20. Ollyws commented on Aug 16, 2023

    @Ollyws
    Ollyws
    on Aug 16, 2023
    Contributor

    Regression Test Proposal

    1. Click on FAB > split bill > enter an amount then click next.
    2. Share with account has long email (example: testingtestingtestingtesting+12345@test.com).
    3. Split the bill.
    4. Click on the IOU card to open its details.
    5. Click on the account you split the bill with him.
    6. Verify that the "Message with" button is not truncated early before the end of line.
    7. Return to the chat and mention an account that has a long email (example: testingtestingtestingtesting+12345@test.com).
    8. Select the mention to navigate to the details page.
    9. Verify that the "Message with" button is not truncated early before the end of line.

    Do we agree 👍 or 👎

  21. Ollyws commented on Aug 16, 2023

    @Ollyws
    Ollyws
    on Aug 16, 2023
    Contributor

    @garrettmknight All updated, thanks!

  22. garrettmknight
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Aug 16, 2023

  23. garrettmknight commented on Aug 18, 2023

    @garrettmknight
    garrettmknight
    on Aug 18, 2023
    Contributor

    Summarizing payments for this issue:

    #urgency bonus? Yes
    Reporter: @Nathan-Mulugeta $250 paid via Upwork
    Contributor: @ahmedGaber93 $1500 paid via Upwork
    Contributor+: @Ollyws $1500 paid via Upwork

    Upwork job is here: https://www.upwork.com/jobs/~013be117aa6991d578

  24. garrettmknight commented on Aug 18, 2023

    @garrettmknight
    garrettmknight
    on Aug 18, 2023
    Contributor

    @Ollyws are you getting paid via NewDot or Upwork?

  25. Ollyws commented on Aug 19, 2023

    @Ollyws
    Ollyws
    on Aug 19, 2023
    Contributor

    @garrettmknight Upwork thanks.

  26. melvin-bot
    added
    Overdue
    on Aug 21, 2023

  27. garrettmknight commented on Aug 21, 2023

    @garrettmknight
    garrettmknight
    on Aug 21, 2023
    Contributor

    Paid via Upwork. Closing!

  28. garrettmknight
    closed this as completedon Aug 21, 2023
  29. melvin-bot
    removed
    Overdue
    on Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions