You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Web - User is taken to concierge instead of chat screen when IOU is deleted #23785
Open the IOU report by clicking on the report preview
Do the same (step 2) on account B
Delete the IOU request from account A
Observe where account B is redirected
Expected Result:
Account B should be redirected to the chat report just as it does for account A
Actual Result:
Account B is redirected to concierge
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.47-2 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Yes, the issue happens because we keep those chats in the navigation stack but when the reports are deleted, we default to navigating to the Concierge chat. We're creating a way to clear the navigation stack in the issue I linked above, which would also solve the issue mentioned in the current issue.
Activity
kbecciv commentedon Jul 28, 2023
This is the PR which introduced this feature.
OSBotify commentedon Jul 28, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 28, 2023
Triggered auto assignment to @flodnv (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.aimane-chnaif commentedon Jul 28, 2023
Delete money request is a new feature and still WIP. Not a deploy blocker
flodnv commentedon Jul 28, 2023
@luacmartins if you can confirm that, can you remove the deploy blocker and unassign me? Thanks!
Discussion here: https://expensify.slack.com/archives/C049HHMV9SM/p1690546811937609?thread_ts=1690536863.093449&cid=C049HHMV9SM
mountiny commentedon Jul 28, 2023
this is not a blocker, this issue is known and @luacmartins will be addressing it
luacmartins commentedon Jul 28, 2023
Closing in favor of #20908
Nathan-Mulugeta commentedon Jul 28, 2023
Are those two issues related @luacmartins ?
luacmartins commentedon Jul 28, 2023
Yes, the issue happens because we keep those chats in the navigation stack but when the reports are deleted, we default to navigating to the Concierge chat. We're creating a way to clear the navigation stack in the issue I linked above, which would also solve the issue mentioned in the current issue.
Nathan-Mulugeta commentedon Jul 28, 2023
Okay thanks for the explanation 😊