Skip to content

[HOLD for payment 2023-08-21] [$1000] Web -Pointer cursor is displayed on send button even when compose box is empty #23848

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open any report and hover on send button

Expected Result:

'not-allowed' cursor should be displayed on send button when there is no text in compose box

Actual Result:

Pointer cursor is displayed on send button even when there is no text in compose box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.47-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

pointer.cursor.displayed.on.send.button.mp4
Recording.3987.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690618580440309

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fb9c3994ff691de4
  • Upwork Job ID: 1685975218636345344
  • Last Price Increase: 2023-07-31
  • Automatic offers:
    • dhanashree-sawant | Reporter | 25955399
    • Nodebrute | Contributor | 25990051

Activity

  1. OSBotify commented on Jul 29, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jul 29, 2023

    @melvin-bot

    Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. c3024 commented on Jul 29, 2023

    @c3024
    Contributor

    Edited as the earlier RCA was incorrect

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Pointer is shown on Send button when the compose box is empty.

    What is the root cause of that problem?

    PR 22227 removed the disabled prop of Pressable and added it to the Tap. So there is default pointer for Pressable at all times

    What changes do you think we should make in order to solve the problem?

    We can use

    pointerEvents = {this.state.isCommentEmpty || isBlockedFromConcierge || this.props.disabled || hasExceededMaxCommentLength ? 'none' : 'auto'}
                                        

    on the Pressable.
    or add to style,

    {cursor: this.state.isCommentEmpty || isBlockedFromConcierge || this.props.disabled || hasExceededMaxCommentLength ? "not-allowed" : 'auto'}

    and conditionally show the tooltip for the send button.

    What alternative solutions did you explore? (Optional)

  4. Beamanator commented on Jul 31, 2023

    @Beamanator
    Contributor

    @c3024 that looks exactly why this is failing 👍

    Do you have a chance to put up a PR quickly?

  5. c3024 commented on Jul 31, 2023

    @c3024
    Contributor

    Yes, will make it right away.

  6. Beamanator commented on Jul 31, 2023

    @Beamanator
    Contributor

    Actually it looks like disabled was removed here: #22227

  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 31, 2023
  8. 70 remaining items

  9. rushatgabhane commented on Aug 23, 2023

    @rushatgabhane
    Member

    im waiting for existing manual requests to be approved.
    i'll complete final steps once that's done

  10. laurenreidexpensify commented on Aug 27, 2023

    @laurenreidexpensify
    Contributor

    Not overdue - waiting on Rushat's payment to be approved.

  11. laurenreidexpensify commented on Aug 29, 2023

    @laurenreidexpensify
    Contributor

    Still waiting on Rushat's final payment cc @JmillsExpensify

  12. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    @PauloGasparSv, @rushatgabhane, @laurenreidexpensify, @Nodebrute Eep! 4 days overdue now. Issues have feelings too...

  13. rushatgabhane commented on Sep 5, 2023

    @rushatgabhane
    Member
    1. The PR that introduced the bug has been identified. Link to the PR: #10148 — The message got sent but it also stayed in the compose box #22227

    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22227/files#r1315354049

    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A. part of checklist

    4. Determine if we should create a regression test for this bug. No

    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

  14. rushatgabhane commented on Sep 5, 2023

    @rushatgabhane
    Member
  15. laurenreidexpensify commented on Sep 7, 2023

    @laurenreidexpensify
    Contributor

    Closing - all steps complete

  16. JmillsExpensify commented on Oct 5, 2023

    @JmillsExpensify
    Contributor

    $1,500 payment approved for @rushatgabhane based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions