You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-21] [$1000] Web -Pointer cursor is displayed on send button even when compose box is empty #23848
'not-allowed' cursor should be displayed on send button when there is no text in compose box
Actual Result:
Pointer cursor is displayed on send button even when there is no text in compose box
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.47-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A. part of checklist
Determine if we should create a regression test for this bug. No
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.
Activity
OSBotify commentedon Jul 29, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 29, 2023
Triggered auto assignment to @PauloGasparSv (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.c3024 commentedon Jul 29, 2023
Edited as the earlier RCA was incorrect
Proposal
Please re-state the problem that we are trying to solve in this issue.
Pointer is shown on Send button when the compose box is empty.
What is the root cause of that problem?
PR 22227 removed the disabled prop of Pressable and added it to the Tap. So there is default pointer for Pressable at all times
What changes do you think we should make in order to solve the problem?
We can use
on the
Pressable.or add to style,
and conditionally show the tooltip for the send button.
What alternative solutions did you explore? (Optional)
Beamanator commentedon Jul 31, 2023
@c3024 that looks exactly why this is failing 👍
Do you have a chance to put up a PR quickly?
c3024 commentedon Jul 31, 2023
Yes, will make it right away.
Beamanator commentedon Jul 31, 2023
Actually it looks like
disabledwas removed here: #2222770 remaining items
rushatgabhane commentedon Aug 23, 2023
im waiting for existing manual requests to be approved.
i'll complete final steps once that's done
laurenreidexpensify commentedon Aug 27, 2023
Not overdue - waiting on Rushat's payment to be approved.
laurenreidexpensify commentedon Aug 29, 2023
Still waiting on Rushat's final payment cc @JmillsExpensify
melvin-bot commentedon Sep 4, 2023
@PauloGasparSv, @rushatgabhane, @laurenreidexpensify, @Nodebrute Eep! 4 days overdue now. Issues have feelings too...
rushatgabhane commentedon Sep 5, 2023
The PR that introduced the bug has been identified. Link to the PR: #10148 — The message got sent but it also stayed in the compose box #22227
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22227/files#r1315354049
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A. part of checklist
Determine if we should create a regression test for this bug. No
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.
rushatgabhane commentedon Sep 5, 2023
Created a manual request here - https://staging.new.expensify.com/r/108474191068853
laurenreidexpensify commentedon Sep 7, 2023
Closing - all steps complete
JmillsExpensify commentedon Oct 5, 2023
$1,500 payment approved for @rushatgabhane based on BZ summary.