You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-16] [$1000] Web - The state name in the company information does not update to "Incorporation State," causing both state names to appear the same #23870
Select a workspace and access "Connect Bank Account."
Proceed to Step 2 out of 5.
Expected Result:
The second state name in the company information should be changed to "Incorporation State."
Actual Result:
The state name in the company information does not update to "Incorporation State," causing both state names to appear the same
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.47-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
The state name in the company information does not update to "Incorporation State," causing both state names to appear the same
What is the root cause of that problem?
The root cause is we are not accepting custom title on StatePicker component that stick to the same label as state
What changes do you think we should make in order to solve the problem?
The solution is we should define new props for adding custom label directly to <State> component
After defining the customLabel props this should be added to <MenuItemWithTopDescription> as an description props and we should also pass this to <StateSelectorModal> that we are using on <State> component
On SelectionListRadio we need to add. customLabel to textInputLabel on <StateSelectorModal>
Above both will fix component and selector page as well
We can also pass this same custom label to <HeaderWithBackButton> title props on <StateSelectorModal> so that page title can also have consistency
We already have translate key for that we can just use that or define new key
Fallback value for customLabel props should be translate('common.state’)
What alternative solutions did you explore? (Optional)
changed the title [-]Web - The state name in the company information does not update to "Incorporation State," causing both state names to appear the same[/-][+][$1000] Web - The state name in the company information does not update to "Incorporation State," causing both state names to appear the same[/+]on Aug 1, 2023
I'll finish the checklist today. I think it is related to when we migrated to StatePicker component. Meanwhile @adelekennedy can you post the payment summary here?
As I mentioned we added refactored the StatePicker component in this PR, but we didn't add the label property.
I've added a comment in the PR. I think the following point covers the impacted components, but we missed testing it.
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
Activity
melvin-bot commentedon Jul 29, 2023
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)dhairyasenjaliya commentedon Jul 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
StatePickercomponent that stick to the same label asstateWhat changes do you think we should make in order to solve the problem?
The solution is we should define new props for adding custom label directly to
<State>componentAfter defining the
customLabelprops this should be added to<MenuItemWithTopDescription>as andescriptionprops and we should also pass this to<StateSelectorModal>that we are using on<State>componentOn
SelectionListRadiowe need to add.customLabeltotextInputLabelon<StateSelectorModal>Above both will fix
componentandselectorpage as wellWe can also pass this same custom label to
<HeaderWithBackButton>title props on<StateSelectorModal>so that page title can also have consistencyWe already have translate key for that we can just use that or define new key
Fallback value for
customLabelprops should betranslate('common.state’)What alternative solutions did you explore? (Optional)
———————
Result
[-]Web - The state name in the company information does not update to "Incorporation State," causing both state names to appear the same[/-][+][$1000] Web - The state name in the company information does not update to "Incorporation State," causing both state names to appear the same[/+]melvin-bot commentedon Aug 1, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0180f3b211410f7a0c
melvin-bot commentedon Aug 1, 2023
Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Aug 1, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)kevinksullivan commentedon Aug 1, 2023
@mananjadhav are you able to review the proposal above?
36 remaining items
melvin-bot commentedon Aug 10, 2023
Upwork job price has been updated to $1000
mananjadhav commentedon Aug 16, 2023
I'll finish the checklist today. I think it is related to when we migrated to
StatePickercomponent. Meanwhile @adelekennedy can you post the payment summary here?mananjadhav commentedon Aug 16, 2023
As I mentioned we added refactored the
StatePickercomponent in this PR, but we didn't add thelabelproperty.I've added a comment in the PR. I think the following point covers the impacted components, but we missed testing it.
I don't think we need a regression test here.
cc - @adelekennedy
adelekennedy commentedon Aug 16, 2023
Payouts due:
Issue Reporter: $250 @ayazhussain79
Contributor: $1000 @dhairyasenjaliya Upwork
Contributor+: $1000 @mananjadhav NewDot
Eligible for 50% #urgency bonus? Y
Upwork job is here.
JmillsExpensify commentedon Aug 17, 2023
Reviewed the details for @mananjadhav. This $1,500 payment is approved in NewDot based on the BZ summary above.
mananjadhav commentedon Aug 18, 2023
@JmillsExpensify Can you correct the amount from $15000 to $1500. 🤑
kevinksullivan commentedon Aug 21, 2023
stepping back in to handle final payment. @ayazhussain79 just sent an offer for reporting. Let me know when you accept!
ayazhussain79 commentedon Aug 21, 2023
@kevinksullivan offer accepted, Thank you
adelekennedy commentedon Aug 21, 2023
@kevinksullivan everyone was already paid! - GH was left open for the checklist
ayazhussain79 commentedon Aug 21, 2023
I think not everyone
kevinksullivan commentedon Aug 22, 2023
yeah, @adelekennedy @ayazhussain79 didn't appear to get paid for reporting so I just sent them an offer
kevinksullivan commentedon Aug 22, 2023
Alright, all set on payment. So what checklist are we waiting on now @adelekennedy ?
melvin-bot commentedon Aug 30, 2023
@francoisl, @mananjadhav, @kevinksullivan, @dhairyasenjaliya Whoops! This issue is 2 days overdue. Let's get this updated quick!