Skip to content

[HOLD for payment 2023-08-16] [$1000] Web - The state name in the company information does not update to "Incorporation State," causing both state names to appear the same #23870

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to Settings > Workspaces
  2. Select a workspace and access "Connect Bank Account."
  3. Proceed to Step 2 out of 5.

Expected Result:

The second state name in the company information should be changed to "Incorporation State."

Actual Result:

The state name in the company information does not update to "Incorporation State," causing both state names to appear the same

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.47-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-29.at.1.33.54.AM.mov
Recording.3998.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690576478988209

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0180f3b211410f7a0c
  • Upwork Job ID: 1686400237560549376
  • Last Price Increase: 2023-08-10
  • Automatic offers:
    • dhairyasenjaliya | Contributor | 25889382

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 29, 2023
  2. melvin-bot commented on Jul 29, 2023

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. dhairyasenjaliya commented on Jul 29, 2023

    @dhairyasenjaliya
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • The state name in the company information does not update to "Incorporation State," causing both state names to appear the same

    What is the root cause of that problem?

    • The root cause is we are not accepting custom title on StatePicker component that stick to the same label as state

    What changes do you think we should make in order to solve the problem?

    • The solution is we should define new props for adding custom label directly to <State> component

    • After defining the customLabel props this should be added to <MenuItemWithTopDescription> as an description props and we should also pass this to <StateSelectorModal> that we are using on <State> component

    • On SelectionListRadio we need to add. customLabel to textInputLabel on <StateSelectorModal>

    • Above both will fix component and selector page as well

    • We can also pass this same custom label to <HeaderWithBackButton> title props on <StateSelectorModal> so that page title can also have consistency

    • We already have translate key for that we can just use that or define new key

    • Fallback value for customLabel props should be translate('common.state’)

    What alternative solutions did you explore? (Optional)

    • N/A
      ———————

    Result

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 1, 2023
  6. changed the title [-]Web - The state name in the company information does not update to "Incorporation State," causing both state names to appear the same[/-] [+][$1000] Web - The state name in the company information does not update to "Incorporation State," causing both state names to appear the same[/+] on Aug 1, 2023
  7. melvin-bot commented on Aug 1, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 1, 2023
  9. melvin-bot commented on Aug 1, 2023

    @melvin-bot

    Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

  10. melvin-bot commented on Aug 1, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  11. kevinksullivan commented on Aug 1, 2023

    @kevinksullivan
    Contributor

    @mananjadhav are you able to review the proposal above?

  12. 36 remaining items

  13. melvin-bot commented on Aug 10, 2023

    @melvin-bot

    Upwork job price has been updated to $1000

  14. mananjadhav commented on Aug 16, 2023

    @mananjadhav
    Collaborator

    I'll finish the checklist today. I think it is related to when we migrated to StatePicker component. Meanwhile @adelekennedy can you post the payment summary here?

  15. mananjadhav commented on Aug 16, 2023

    @mananjadhav
    Collaborator

    As I mentioned we added refactored the StatePicker component in this PR, but we didn't add the label property.

    I've added a comment in the PR. I think the following point covers the impacted components, but we missed testing it.

    I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
    

    I don't think we need a regression test here.

    cc - @adelekennedy

  16. adelekennedy commented on Aug 16, 2023

    @adelekennedy
    Contributor

    Payouts due:

    Issue Reporter: $250 @ayazhussain79
    Contributor: $1000 @dhairyasenjaliya Upwork
    Contributor+: $1000 @mananjadhav NewDot

    Eligible for 50% #urgency bonus? Y

    Upwork job is here.

  17. JmillsExpensify commented on Aug 17, 2023

    @JmillsExpensify
    Contributor

    Reviewed the details for @mananjadhav. This $1,500 payment is approved in NewDot based on the BZ summary above.

  18. mananjadhav commented on Aug 18, 2023

    @mananjadhav
    Collaborator

    @JmillsExpensify Can you correct the amount from $15000 to $1500. 🤑

  19. kevinksullivan commented on Aug 21, 2023

    @kevinksullivan
    Contributor

    stepping back in to handle final payment. @ayazhussain79 just sent an offer for reporting. Let me know when you accept!

  20. ayazhussain79 commented on Aug 21, 2023

    @ayazhussain79
    Contributor

    @kevinksullivan offer accepted, Thank you

  21. removed their assignment
    on Aug 21, 2023
  22. adelekennedy commented on Aug 21, 2023

    @adelekennedy
    Contributor

    @kevinksullivan everyone was already paid! - GH was left open for the checklist

  23. ayazhussain79 commented on Aug 21, 2023

    @ayazhussain79
    Contributor

    I think not everyone

  24. kevinksullivan commented on Aug 22, 2023

    @kevinksullivan
    Contributor

    yeah, @adelekennedy @ayazhussain79 didn't appear to get paid for reporting so I just sent them an offer

  25. kevinksullivan commented on Aug 22, 2023

    @kevinksullivan
    Contributor

    Alright, all set on payment. So what checklist are we waiting on now @adelekennedy ?

  26. melvin-bot commented on Aug 30, 2023

    @melvin-bot

    @francoisl, @mananjadhav, @kevinksullivan, @dhairyasenjaliya Whoops! This issue is 2 days overdue. Let's get this updated quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions