Preferences - The description of Priority mode does not match the logic #23903

Activity

1. kbecciv

   added

   DailyKSv2KSv2

   BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.

   on Jul 30, 2023
2. melvin-bot

   assigned

   tjferriss

   on Jul 30, 2023
3. melvin-bot commented on Jul 30, 2023

   

   melvin-botBot

   on Jul 30, 2023

   More actions

   Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
4. melvin-bot commented on Jul 30, 2023

   

   melvin-botBot

   on Jul 30, 2023

   More actions

   Bug0 Triage Checklist (Main S/O)

   • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
   • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
     • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
   • This bug is reproducible using the reproduction steps in the OP. S/O
     • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
     • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
   • This issue is filled out as thoroughly and clearly as possible
     • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
   • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
5. kbecciv commented on Jul 30, 2023

   

   kbecciv

   on Jul 30, 2023

   Author

   More actions

   Proposal by: @namhihi237
   Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690654739888759

   Proposal

   Please re-state the problem that we are trying to solve in this issue.

   The description of the focus mode must match the logic including: pined, unread and draft item

   What is the root cause of that problem?

   Currently, the logic of the show report on LHN of focus mode is unread, pined, and drafted but the description for focus is incomplete and confusing for users.

   What changes do you think we should make in order to solve the problem?

   We need to update the description for focus mode here:
   

   App/src/languages/en.js

   Line 667 in eb02006

   explainerText: 'Choose whether to show all chats by default sorted with most recent with pinned items at the top, or #focus on unread pinned items, sorted alphabetically.',

   
   Can be like this:
   Choose whether to show all chats by default sorted with most recent with pinned items at the top, or #focus on unread, pinned, and draft items, sorted alphabetically.
   

   App/src/languages/en.js

   Line 675 in eb02006

   description: 'Only show unread sorted alphabetically',

   
   Show unread, pined, and draft sorted alphabetically
   And Spanish translation

   What alternative solutions did you explore? (Optional)

   N/A
6. jeet-dhandha commented on Jul 31, 2023

   

   jeet-dhandha

   on Jul 31, 2023

   Contributor

   More actions

   Proposal

   Please re-state the problem that we are trying to solve in this issue.

   • Explainer Text doesn't match Priority modes description.

   What is the root cause of that problem?

   • The description was changed in the below commit.
     • PR: Update Preferences page with push-to-page design #14591
     • Commit: jeet-dhandha@4384921

   What changes do you think we should make in order to solve the problem?

   • We can first update explainer text as below:

     • BEFORE: Choose whether to show all chats by default sorted with most recent with pinned items at the top, or #focus on unread pinned items, sorted alphabetically.
     • UPDATED: Choose whether to show all chats sorted with the most recent and pinned items at the top by default, or #focus on unread and pinned chats sorted alphabetically. (Fixed some writing issues using grammerly)
     • UPDATED SPANISH: Elige si mostrar todas las conversaciones ordenadas con las más recientes y los elementos anclados en la parte superior de manera predeterminada, o #enfocarse en las conversaciones no leídas y ancladas ordenadas alfabéticamente.

   • Now we also need to update #focus mode's description:

     • BEFORE: Only show unread sorted alphabetically
     • UPDATED: Only show unread and pinned chats, sorted alphabetically.
     • Updated SPANISH: "Mostrar solo chats no leídos y anclados, ordenados alfabéticamente."

   What alternative solutions did you explore? (Optional)

   • N/A
7. jeet-dhandha commented on Jul 31, 2023

   

   jeet-dhandha

   on Jul 31, 2023

   Contributor

   More actions

   Now i forgot about the draft items will update that shortly. 👍
8. tjferriss commented on Aug 1, 2023

   

   tjferriss

   on Aug 1, 2023

   Contributor

   More actions

   Determining whether we assign copy updates externally. Discussing here.
9. tjferriss commented on Aug 3, 2023

   

   tjferriss

   on Aug 3, 2023

   Contributor

   More actions

   I'm going to close this out as it's more of an improvement suggestion rather than a bug preventing someone from using the app.
10. tjferriss

    closed this as completedon Aug 3, 2023