Skip to content

[HOLD for payment 2023-08-07] Payment Issue for C+ Review #23952

Closed

Description

@dangrous

Cutting out most of the details here - we have internal issue https://github.com/Expensify/Expensify/issues/292452 for deprecating the moderationDecisions array in the front end. @Santhosh-Sellavel reviewed the App PR and needs payment!

Let me know if you have any questions

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 31, 2023
  2. melvin-bot commented on Jul 31, 2023

    @melvin-bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 31, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. Santhosh-Sellavel commented on Jul 31, 2023

    @Santhosh-Sellavel
    Collaborator

    Thanks, @dangrous!

    @puneetlath
    PR got deployed to production today.
    Kindly add relevant labels and update Hold for payment in the issue title with a date.

    Also leave a comment mentioning the amount, so I can use it when it's to request payout on ND thanks!

  5. changed the title [-]Payment Issue for C+ Review[/-] [+][HOLD for payment 2023-08-07] Payment Issue for C+ Review[/+] on Jul 31, 2023
  6. puneetlath commented on Jul 31, 2023

    @puneetlath
    Contributor

    Only payment needed here is:

  7. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 31, 2023
  8. Santhosh-Sellavel commented on Aug 2, 2023

    @Santhosh-Sellavel
    Collaborator

    @puneetlath assign me the issue as well, thanks!

  9. puneetlath commented on Aug 7, 2023

    @puneetlath
    Contributor

    @Santhosh-Sellavel please go ahead and request the payment on NewDot.

  10. puneetlath commented on Aug 8, 2023

    @puneetlath
    Contributor

    @Santhosh-Sellavel let me know when you've requested so that I can assign Jason to pay.

  11. Santhosh-Sellavel commented on Aug 10, 2023

    @Santhosh-Sellavel
    Collaborator

    Requested on ND

  12. puneetlath commented on Aug 10, 2023

    @puneetlath
    Contributor

    Assigning @JmillsExpensify for payment.

  13. JmillsExpensify commented on Aug 15, 2023

    @JmillsExpensify
    Contributor

    Reviewed the details for @Santhosh-Sellavel. Approved for payment in NewDot based on BZ summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions