Skip to content

[HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] [$1000] IOU - Double "request money" tab if request money #23962

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #22649

Action Performed:

  1. Open https://staging.new.expensify.com/
  2. Click on "+" in any chat / click on FAB menu
  3. Click on "Request money"
  4. Insert amount
  5. Click "Next"

Expected Result:

At step 5 user lands in IOU summary (with destination, amount and description)

Actual Result:

At step 5 user lands in the same "insert amount" tab, it is duplicated.
Also if user switches to a different chat and requests money - amount from previous IOU would be dispalyed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.48.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6148594_Recording__840.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d986e83acbb6b2e5
  • Upwork Job ID: 1686336524126748672
  • Last Price Increase: 2023-08-01

Activity

  1. OSBotify commented on Jul 31, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jul 31, 2023

    @melvin-bot

    Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. hayata-suenaga commented on Jul 31, 2023

    @hayata-suenaga
    Contributor

    the product can be still used. the user just have to click twice. this is not a deploy blocker

  4. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jul 31, 2023
  5. melvin-bot commented on Jul 31, 2023

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. melvin-bot commented on Jul 31, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. hayata-suenaga commented on Jul 31, 2023

    @hayata-suenaga
    Contributor

    @mountiny do you think this is part of regression from the navigation refactoring?

  8. 62 remaining items

  9. aimane-chnaif commented on Aug 13, 2023

    @aimane-chnaif
    Contributor

    Regarding BZ Checklist:

    This was regression from performance upgrade in Onyx. The author (@hannojg) is already aware of it.
    And this was caught by Applause team, so no need regression test.

  10. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    @mallenexpensify, @aimane-chnaif, @hayata-suenaga Huh... This is 4 days overdue. Who can take care of this?

  11. melvin-bot commented on Aug 24, 2023

    @melvin-bot

    @mallenexpensify, @aimane-chnaif, @hayata-suenaga Still overdue 6 days?! Let's take care of this!

  12. hayata-suenaga commented on Aug 24, 2023

    @hayata-suenaga
    Contributor

    @mallenexpensify I'd appreciate if you could take care of payment when you have time 🙇

  13. mallenexpensify commented on Aug 29, 2023

    @mallenexpensify
    Contributor

    Sorry for the (lonnnnng) delay. It appears @aimane-chnaif is the only one due compensation, for C+ review of the PR. If so, @aimane-chnaif , can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~01d986e83acbb6b2e5

  14. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    @mallenexpensify, @aimane-chnaif, @hayata-suenaga Eep! 4 days overdue now. Issues have feelings too...

  15. mallenexpensify commented on Sep 4, 2023

    @mallenexpensify
    Contributor

    Contributor+: @aimane-chnaif paid $1000 via Upwork.

  16. hungvu193 commented on Sep 5, 2023

    @hungvu193
    Contributor

    Hey if it's considered as a bug, please update me as reporter. I reported it few days ago, but it wasn't logged: https://expensify.slack.com/archives/C049HHMV9SM/p1690591424340319

    @mallenexpensify I think I'm eligible for reporting bonus because I reported this issue firstly on slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions