Repository navigation
Not Allowed sign is not shown when dragging attachments on LHN #23969
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open any chat
- drag attachments on LHN
Expected Result:
Not Allowed sign is shown when dragging the attachment on LHN
Actual Result:
Copy sign is shown when dragging the attachment on LHN
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.48-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Test95.Dragonlhn-1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690836365230309
Activity
melvin-bot commentedon Jul 31, 2023
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 31, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Jul 31, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 31, 2023
Triggered auto assignment to @marcaaron (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.marcaaron commentedon Jul 31, 2023
@roryabraham do you maybe know what is up with this one? I thought I remember you saying something about refactoring drag and drop things.
marcaaron commentedon Jul 31, 2023
Related PR -> #23589
dummy-1111 commentedon Aug 1, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Not allowed sign isn't shown when dragging attachment on LHN
What is the root cause of that problem?
We're not wrapping the LHN with
NoDropZoneWhat changes do you think we should make in order to solve the problem?
Wrapping the
SidebarLinkswithNoDropZonewould solve the issuefullScreenprops with default true to theNoDropZonecomponentNoDropZoneinSidebarLink.jswithfullScreen={false}This works as expected
Result
What alternative solutions did you explore? (Optional)
roryabraham commentedon Aug 1, 2023
@s-alves10 I don't think that's the root cause of the problem – its a proposed solution.
dummy-1111 commentedon Aug 1, 2023
@roryabraham
Can you provide me with the link?
roryabraham commentedon Aug 1, 2023
@marcaaron I'll grab this from you since I almost certainly caused it with #23589
ginsuma commentedon Aug 1, 2023
I think it will be handled here #22218 (comment).
allroundexperts commentedon Aug 1, 2023
@roryabraham This is not a regression I think. LHN wasn't showing the not allowed icon before your PR as well.
roryabraham commentedon Aug 1, 2023
I think it is a regression, because it's reproducible on staging but not main
allroundexperts commentedon Aug 1, 2023
Take a look at #22218. I think we're trying to use a different approach by disabling drag and drop entirely across the app and just enabling it for composer. We might want to combine these two issues.
roryabraham commentedon Aug 1, 2023
Ok, going to close this one in favor of #22218 then and remove the deploy blocker
roryabraham commentedon Aug 1, 2023
FWIW I think the simplest quick-and-dirty fix to this issue would be to update this listener to also set
dropEffect: noneon the event.