[HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] IOU - When a new IOU is opened, the sum of the previous IOU is displayed in the modal window

@Natnael-Guchima

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Preconditions:
Start creating an IOU, but close the modal window at the moment you select a contact

Open https://staging.new.expensify.com/
Click on the "Global action" button (Big green plus button in LHN)
Click on "Request money"

Expected Result:

The amount of the previous IOU should not be saved when opening a new IOU

Actual Result:

When opening a new IOU in the modal window, the amount of the previous uncompleted IOU has already been entered

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.48.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6148717_Recording_Regression_23945_All.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Tam / @Natnael-Guchima

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690830970030189?thread_ts=1690829632.233769&cid=C049HHMV9SM

View all open jobs on GitHub

@marcaaron

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

No idea which PR might have introduced this. Nothing obvious stands out. I'd maybe check to see if the recent Onyx changes have something to do with it first.

I can't repo this on main .. but it's repo in staging. looks like there is a PR fixed it.

Screen.Recording.2023-08-01.at.3.34.57.PM.mov

No idea which PR might have introduced this. Nothing obvious stands out. I'd maybe check to see if the recent Onyx changes have something to do with it first.

This PR #23749 introduces the issue.

@hannojg

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - When a new IOU is opened, the sum of the previous IOU is displayed in the modal window

What is the root cause of that problem?

As I have discussed with @hannojg on slack. This issue #23749 creates read faster than writes, due to this,

App/src/libs/actions/IOU.js

Line 1441 in 6c9e459

function startMoneyRequest(iouType, reportID = '') {

depends on

App/src/libs/actions/IOU.js

Lines 64 to 72 in 6c9e459

    
           function resetMoneyRequestInfo(id = '') { 
        
               Onyx.merge(ONYXKEYS.IOU, { 
        
                   id, 
        
                   amount: 0, 
        
                   currency: lodashGet(currentUserPersonalDetails, 'localCurrencyCode', CONST.CURRENCY.USD), 
        
                   comment: '', 
        
                   participants: [], 
        
               }); 
        
           }

.

As Onyx.update is slow, at MoneyRequestAmountPage older values populate the page due to read cached behaviour.

What changes do you think we should make in order to solve the problem?

Since Onyx.update returns a promise, we can chain

App/src/libs/actions/IOU.js

Line 1443 in 6c9e459

Navigation.navigate(ROUTES.getMoneyRequestRoute(iouType, reportID));

under a .then so we make sure that MoneyRequestAmountPage opens with latest values.

What alternative solutions did you explore? (Optional)

N/A

The proposal looks valid to me, and fixes the issue, yes!

@Beamanator

We will revert the PR causing the regression and make a separate PR that will include all the fixes. Your proposal will be incorporated in that PR.
Not sure how we handle compensation in that case (cc @Beamanator as we were talking about this) ?

@Beamanator

A gentle bump for reporting payment @Beamanator 🙂

@marcaaron

@marcaaron can you help get a BZ assigned to sort out payment? 🙏

@slafortune

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@slafortune

@slafortune can you help with #23973 (comment) 🙏

@Natnael-Guchima

External issue reporter - @Natnael-Guchima $250 - OFFER sent
Contributor that fixed the issue - NA
Contributor+ that helped on the issue and/or PR - NA

@slafortune

Accepted the offer. Thanks @slafortune

Navigation Menu

Repository navigation

[HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] IOU - When a new IOU is opened, the sum of the previous IOU is displayed in the modal window #23973

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

23 remaining items

Bug0 Triage Checklist (Main S/O)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function resetMoneyRequestInfo(id = '') {
	Onyx.merge(ONYXKEYS.IOU, {
	id,
	amount: 0,
	currency: lodashGet(currentUserPersonalDetails, 'localCurrencyCode', CONST.CURRENCY.USD),
	comment: '',
	participants: [],
	});
	}

[HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] IOU - When a new IOU is opened, the sum of the previous IOU is displayed in the modal window #23973

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Aug 1, 2023

OSBotify commented on Aug 1, 2023

marcaaron commented on Aug 1, 2023

ahmdshrif commented on Aug 1, 2023

shubham1206agra commented on Aug 1, 2023

shubham1206agra commented on Aug 1, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

hannojg commented on Aug 1, 2023

hannojg commented on Aug 1, 2023

23 remaining items

Natnael-Guchima commented on Aug 14, 2023

Beamanator commented on Aug 14, 2023

melvin-bot commented on Aug 14, 2023

melvin-bot commented on Aug 14, 2023

Bug0 Triage Checklist (Main S/O)

marcaaron commented on Aug 14, 2023

slafortune commented on Aug 16, 2023

Natnael-Guchima commented on Aug 17, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions