[HOLD for payment 2023-08-17] [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Payments - App crashed when try to set default if added BA #24005
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Launch App
- Navigate to Settings -> Payments -> Add Payment Method -> Bank Account
- Click on the recently added bank account
- Tap on "Make default payment method"
Expected Result:
App should not crashed
Actual Result:
App crashed when try to set default if added BA
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.48.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6149269_crashed.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Activity
OSBotify commentedon Aug 1, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 1, 2023
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.tgolen commentedon Aug 1, 2023
I was able to reproduce the crash on iOS. When I reproduced the issue on web, I got this JS console error, which must be what's causing the crash:
Beamanator commentedon Aug 1, 2023
Ooh good catch -
canUsePasswordlessLoginslooks like a method that got removedtgolen commentedon Aug 1, 2023
Yeah, looks like @NikkiWines removed it in #22461. Reassigning to Nikki.
Beamanator commentedon Aug 1, 2023
Yep, then #22412 just got to staging so we probably added it back here w/out knowing it got removed somehow
tgolen commentedon Aug 1, 2023
Ah, good call. Assigning it to them too
15 remaining items
[-][HOLD for payment 2023-08-08] Payments - App crashed when try to set default if added BA[/-][+][HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Payments - App crashed when try to set default if added BA[/+]melvin-bot commentedon Aug 3, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-10. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
rushatgabhane commentedon Aug 7, 2023
manual request here - https://staging.new.expensify.com/r/2267949987948189
[-][HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Payments - App crashed when try to set default if added BA[/-][+][HOLD for payment 2023-08-17] [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Payments - App crashed when try to set default if added BA[/+]melvin-bot commentedon Aug 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
tgolen commentedon Aug 21, 2023
@rushatgabhane it sounds like you've requested payment already, so I think we are OK to close this. If not, please reopen and let me know what we need to do. Thanks!