[HOLD for payment 2023-08-24] [$1000] Task - Second avatar of group avatar is highlighted when long pressing on Share somewhere

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify.com
Go to any group chat
Click + > Assign task
Enter title and click Next
Long press on Share somewhere field

Expected Result:

Since Share somewhere field is not selectable in group chat task assignment, it should not have any feedback when pressing on it

Actual Result:

The second avatar of group avatar is highlighted when long pressing on Share somewhere

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.48.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6149411_Screen_Recording_20230801_200354_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause -Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a8af40e296417c50
Upwork Job ID: 1686485461826138112
Last Price Increase: 2023-08-01
Automatic offers:

reinaldosg | Contributor | 25951887

@lschurr

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Second avatar of group avatar is highlighted on long press

What is the root cause of that problem?

MultipleAvatars style ignore props.interactive so the element always have action

App/src/components/MenuItem.js

Lines 155 to 156 in 9dc5f19

    
           pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.buttonPressedBG) : undefined, 
        
           isHovered && !pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.border) : undefined,

What changes do you think we should make in order to solve the problem?

Check props.interactive to determine the style

pressed && props.interactive ? StyleUtils.getBackgroundAndBorderStyle(themeColors.buttonPressedBG) : undefined,
isHovered && !pressed && props.interactive ? StyleUtils.getBackgroundAndBorderStyle(themeColors.border) : undefined,

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~01a8af40e296417c50

@lschurr

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

@sobitneupane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

I can do this

@hanzalahsamana

📣 @hanzalahsamana! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Sorry for the delay. I will try to get to it by EOD.

@sobitneupane

Bump on this one @sobitneupane :)

@sobitneupane

Hi @sobitneupane - would really like to get this one closed out. Could you confirm whether we need a regression test or not?

Regression Test Proposal

Open a group chat
Assign task
Enter title and click Next
Hover on Share somewhere field -> Verify that avatars are not highlighted
Press on Share somewhere field -> Verify that avatars are not highlighted
Long Press on Share somewhere field -> Verify that avatars are not highlighted

Do we agree 👍 or 👎

@sobitneupane

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#20145

[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/20145/files#r1311937536

[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

[@sobitneupane] Determine if we should create a regression test for this bug.

Yes

[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#24008 (comment)

@danieldoglas

@danieldoglas, @reinaldosg, @sobitneupane, @lschurr Whoops! This issue is 2 days overdue. Let's get this updated quick!

@lschurr

@lschurr I think this one is ready to pay/close!

Yep, thanks! I'm going to create a QA GH and will close.

All done!

Requested payment on newDot.

#24008 (comment)

$1,500 approved for payment via NewDot based on BZ summary.

Navigation Menu

Repository navigation

[HOLD for payment 2023-08-24] [$1000] Task - Second avatar of group avatar is highlighted when long pressing on Share somewhere #24008

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

48 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.buttonPressedBG) : undefined,
	isHovered && !pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.border) : undefined,

[HOLD for payment 2023-08-24] [$1000] Task - Second avatar of group avatar is highlighted when long pressing on Share somewhere #24008

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Aug 1, 2023

melvin-bot commented on Aug 1, 2023

Bug0 Triage Checklist (Main S/O)

reinaldosg commented on Aug 1, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Aug 1, 2023

melvin-bot commented on Aug 1, 2023

melvin-bot commented on Aug 1, 2023

hanzalahsamana commented on Aug 1, 2023

melvin-bot commented on Aug 1, 2023

48 remaining items

sobitneupane commented on Aug 28, 2023

lschurr commented on Aug 29, 2023

lschurr commented on Aug 30, 2023

sobitneupane commented on Aug 31, 2023

sobitneupane commented on Aug 31, 2023

melvin-bot commented on Sep 4, 2023

danieldoglas commented on Sep 4, 2023

lschurr commented on Sep 4, 2023

lschurr commented on Sep 5, 2023

sobitneupane commented on Sep 5, 2023

JmillsExpensify commented on Sep 10, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions