Skip to content

mWeb Android/Chrome - Compose box is hidden when we delete edited message #24016

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app in android chrome
  2. Open any report
  3. Send any text
  4. Write some text in compose box and long press message sent in step 3 and edit the message
  5. Remove all the text and click send, in delete popup, click on delete
  6. Observe that composer is now not visible

Expected Result:

App should display the composer after we delete edited message

Actual Result:

App does not display the composer after we delete edited message in android chrome

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.48-3
Reproducible in staging?: Y
Reproducible in production?: Needs repro
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

compose.box.invisible.on.delete.edit.msg.mp4
az_recorder_20230801_125819.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690903191529089

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 1, 2023
  2. melvin-bot commented on Aug 1, 2023

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 1, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Aug 1, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 1, 2023

    @melvin-bot

    Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. mvtglobally commented on Aug 1, 2023

    @mvtglobally
    Author

    @bfitzexpensify We are near closure of the checklist. Contributor is not able to repro on PROD, i need a bit more time to validate PROD. If you can check on your side as well to confirm if its a blocker or no, would be great

  7. marcochavezf commented on Aug 1, 2023

    @marcochavezf
    Contributor

    I'm also not able to reproduce it on prod, investigating what caused the issue

  8. kushu7 commented on Aug 1, 2023

    @kushu7
    Contributor

    @marcochavezf Issue is from this PR
    tested with reverting this PR.

  9. 11 remaining items

  10. dummy-1111 commented on Aug 1, 2023

    @dummy-1111
    Contributor
  11. s77rt commented on Aug 1, 2023

    @s77rt
    Member

    @s-alves10 Please raise a PR, I will test asap. You need to test that as well.

  12. dummy-1111 commented on Aug 1, 2023

    @dummy-1111
    Contributor

    @s77rt

    PR is in draft.
    Please test with it. I'm testing but it shows an error in android native

  13. s77rt commented on Aug 1, 2023

    @s77rt
    Member

    @s-alves10 Let's continue proposal discussion here.

  14. marcochavezf commented on Aug 2, 2023

    @marcochavezf
    Contributor

    The PR that caused the regression was reverted, so I'm going to close this issue since it's no longer happening on staging

  15. dhanashree-sawant commented on Aug 2, 2023

    @dhanashree-sawant

    Hi @marcochavezf, @s77rt, it seems like issue was useful to trigger the solution, will it be eligible for reporting bonus?

  16. marcochavezf commented on Aug 2, 2023

    @marcochavezf
    Contributor

    Oh sorry @dhanashree-sawant, I think yes since it was a deploy blocker and fixed with the revert. Reopening for payment cc @bfitzexpensify

  17. bfitzexpensify commented on Aug 3, 2023

    @bfitzexpensify
    Contributor

    Cool, this has been paid out.

  18. s77rt commented on Aug 24, 2023

    @s77rt
    Member

    I think this is reproducible again

  19. s77rt commented on Aug 30, 2023

    @s77rt
    Member
  20. dummy-1111 commented on Aug 31, 2023

    @dummy-1111
    Contributor

    I think this should be fixed in #23908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions