Skip to content

[Snyk] Security upgrade electron from 25.2.0 to 25.4.0 #24120

Closed

Description

@melvin-bot

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Issue Breaking Change Exploit Maturity
high severity Use After Free
SNYK-JS-ELECTRON-5812138
No No Known Exploit
high severity Use After Free
SNYK-JS-ELECTRON-5812149
No No Known Exploit
high severity Out-of-bounds Write
SNYK-JS-ELECTRON-5812567
No No Known Exploit

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Use After Free

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e58746a77c9c36d9
  • Upwork Job ID: 1687146838934872064
  • Last Price Increase: 2023-08-03

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Aug 3, 2023
  2. melvin-bot commented on Aug 3, 2023

    @melvin-bot
    Author

    This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

        C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
        - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
        - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
        - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
        - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.
    
  3. melvin-bot commented on Aug 3, 2023

    @melvin-bot
    Author
  4. melvin-bot commented on Aug 3, 2023

    @melvin-bot
    Author

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

  5. rushatgabhane commented on Aug 3, 2023

    @rushatgabhane
    Member

    PR here - #24119 (comment)

    I think we can upgrade this.

    • The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users. - electron is being upgraded. It fixes 3 high vulnerabilities that have no known exploits. It has no impact on end users.
    • If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it. - Issue is worth fixing as it's a minor version change without any negative impact.
    • Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes. - There are no breaking changes.
    • Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.
  6. rushatgabhane commented on Aug 23, 2023

    @rushatgabhane
    Member

    I think $250 is more than enough for this issue.

  7. rushatgabhane commented on Sep 5, 2023

    @rushatgabhane
    Member
  8. melvin-bot commented on Sep 29, 2023

    @melvin-bot
    Author

    This issue has not been updated in over 15 days. @rushatgabhane eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  9. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 5, 2023
  10. melvin-bot commented on Oct 5, 2023

    @melvin-bot
    Author

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  11. melvin-bot commented on Oct 5, 2023

    @melvin-bot
    Author

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  12. JmillsExpensify commented on Oct 5, 2023

    @JmillsExpensify
    Contributor

    @CortneyOfstad Do you mind providing a BZ payment summary for this issue so that I can get Rushat paid?

  13. melvin-bot commented on Oct 9, 2023

    @melvin-bot
    Author

    @CortneyOfstad, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. CortneyOfstad commented on Oct 9, 2023

    @CortneyOfstad
    Contributor

    Reviewing this now!

  15. CortneyOfstad commented on Oct 9, 2023

    @CortneyOfstad
    Contributor

    BZ Payment Summary

    Contributor + @rushatgabhane to be paid $250 (based on comment here)

    This is to be paid in NewDot, based on SO here

    CC @JmillsExpensify

  16. JmillsExpensify commented on Oct 9, 2023

    @JmillsExpensify
    Contributor

    $250 payment approved for @rushatgabhane based on BZ summary.

  17. CortneyOfstad commented on Oct 12, 2023

    @CortneyOfstad
    Contributor

    Alright, closing this out! Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions