You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Snyk] Security upgrade electron from 25.2.0 to 25.4.0 #24120
This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.
C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
- [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
- [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
- [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
- [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.
The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users. - electron is being upgraded. It fixes 3 high vulnerabilities that have no known exploits. It has no impact on end users.
If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it. - Issue is worth fixing as it's a minor version change without any negative impact.
Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes. - There are no breaking changes.
Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.
This issue has not been updated in over 15 days. @rushatgabhane eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Aug 3, 2023
This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.
melvin-bot commentedon Aug 3, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01e58746a77c9c36d9
melvin-bot commentedon Aug 3, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (
Internal)rushatgabhane commentedon Aug 3, 2023
PR here - #24119 (comment)
I think we can upgrade this.
electronis being upgraded. It fixes 3 high vulnerabilities that have no known exploits. It has no impact on end users.rushatgabhane commentedon Aug 23, 2023
I think $250 is more than enough for this issue.
rushatgabhane commentedon Sep 5, 2023
created a manual request here https://staging.new.expensify.com/r/2508372919229023
melvin-bot commentedon Sep 29, 2023
This issue has not been updated in over 15 days. @rushatgabhane eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
melvin-bot commentedon Oct 5, 2023
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 5, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)JmillsExpensify commentedon Oct 5, 2023
@CortneyOfstad Do you mind providing a BZ payment summary for this issue so that I can get Rushat paid?
melvin-bot commentedon Oct 9, 2023
@CortneyOfstad, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!
CortneyOfstad commentedon Oct 9, 2023
Reviewing this now!
CortneyOfstad commentedon Oct 9, 2023
BZ Payment Summary
Contributor + @rushatgabhane to be paid $250 (based on comment here)
This is to be paid in NewDot, based on SO here
CC @JmillsExpensify
JmillsExpensify commentedon Oct 9, 2023
$250 payment approved for @rushatgabhane based on BZ summary.
CortneyOfstad commentedon Oct 12, 2023
Alright, closing this out! Thanks all!