You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-28] [$1000] When deleting a file, there is a space between the username and the '[Deleted message]' #24216
Notice the space between username and delete message
Now check that after deleting a text message
Expected Result:
When deleting a file or text message, there should be consistent spacing between the username and the '[Deleted message]'
Actual Result:
When deleting a file, there is a space between the username and the '[Deleted message]' message, causing an inconsistency in spacing compared to deleting a text message.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.50-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
This property is not available on the BE, so if you logout, isAttachment will be lost, and therefore the attachment check will rely on ReportUtils.isReportMessageAttachment(message).
The problem is, when we delete a message, we never set the isAttachment to false. So, the [Deleted message] text will still have the margin-top of 8.
What changes do you think we should make in order to solve the problem?
Set isAttachment to false when we delete a message.
changed the title [-]When deleting a file, there is a space between the username and the '[Deleted message]'[/-][+][$1000] When deleting a file, there is a space between the username and the '[Deleted message]'[/+]on Aug 8, 2023
Ah, whoops! I've made the payments on those. I think the easiest thing to do is to simply deduct from your next issue bounties. Do you have any in the works you can make a note on to reduce the amount due accordingly?
Activity
namhihi237 commentedon Aug 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When deleting a file or text message, there should be consistent spacing between the username and the '[Deleted message]'
What is the root cause of that problem?
Here is the difference between space after deleting text message and attachment
If it's an attachment, we pass
styles.mt2hereApp/src/pages/home/report/ReportActionItem.js
Line 330 in c3bafa6
We have 2 cases:
What changes do you think we should make in order to solve the problem?
Here we should check more if the attachment has been deleted or not
Result:
Screen.Recording.2023-08-08.at.00.36.26.mov
Screen.Recording.2023-08-08.at.00.38.29.mov
What alternative solutions did you explore? (Optional)
N/A
DanutGavrus commentedon Aug 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When deleting a file, there is a space between the username and the '[Deleted message]'
What is the root cause of that problem?
In
ReportActionItem, we set a top margin if the action is an attachment, but we do not verify that it was not deleted:App/src/pages/home/report/ReportActionItem.js
Line 330 in 4230f28
What changes do you think we should make in order to solve the problem?
We should also verify that:
What alternative solutions did you explore?
If we want also want to keep the space while waiting for the attachment to be deleted, we should update to:
melvin-bot commentedon Aug 7, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 7, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)yh-0218 commentedon Aug 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When deleting a file, there is a space between the username and the '[Deleted message]'
What is the root cause of that problem?
App/src/pages/home/report/ReportActionItem.js
Line 330 in 8639fb6
Because we have
styles.mt2for all attachments.What changes do you think we should make in order to solve the problem?
We have to remove
styles.mt2for only deleted attachments.We can get deleted status from action
ReportActionsUtils.isDeletedAction(props.action).What alternative solutions did you explore? (Optional)
bernhardoj commentedon Aug 8, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
After deleting a thread message that is an attachment, the [Deleted Message] still has the margin value that is supposed to be for an attachment only.
What is the root cause of that problem?
When the message is an attachment, we apply a margin-top of 8.
App/src/pages/home/report/ReportActionItem.js
Line 314 in 2ce4328
App/src/pages/home/report/ReportActionItem.js
Line 330 in 2ce4328
Currently, we check if it's an attachment from the report action
isAttachmentandReportUtils.isReportMessageAttachment(message)isAttachmentis a local onyx data that is set when we add a new action/message.App/src/libs/ReportUtils.js
Line 1507 in 2ce4328
App/src/libs/ReportUtils.js
Line 1539 in 2ce4328
This property is not available on the BE, so if you logout,
isAttachmentwill be lost, and therefore the attachment check will rely onReportUtils.isReportMessageAttachment(message).The problem is, when we delete a message, we never set the
isAttachmenttofalse. So, the [Deleted message] text will still have the margin-top of 8.What changes do you think we should make in order to solve the problem?
Set
isAttachmentto false when we delete a message.App/src/libs/actions/Report.js
Lines 882 to 890 in 2ce4328
What alternative solutions did you explore? (Optional)
Remove
props.action.isAttachmentchecks.[-]When deleting a file, there is a space between the username and the '[Deleted message]'[/-][+][$1000] When deleting a file, there is a space between the username and the '[Deleted message]'[/+]melvin-bot commentedon Aug 8, 2023
Job added to Upwork: https://www.upwork.com/jobs/~019a73e78df922007d
melvin-bot commentedon Aug 8, 2023
Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.
49 remaining items
trjExpensify commentedon Aug 30, 2023
Hey everyone! Sorry for the delay, I've been out of office.
Confirming payments as follows:
ayazhussain79 commentedon Aug 30, 2023
@trjExpensify offer accepted, Thank you
trjExpensify commentedon Aug 30, 2023
Paid!
bernhardoj commentedon Aug 30, 2023
@trjExpensify Oh no, I think we shouldn't be getting paid yet as we still have a regression here.
(I just realized we haven't linked the regression issue here, my bad)
cc: @cubuspl42
jakub-trzebiatowski commentedon Aug 30, 2023
@trjExpensify It's my fault. Do you know how we can clean this up, or should I start a topic on Slack?
I also bumped the PRs that are blocking #25415, I hope we'll soon have this whole thing behind us
trjExpensify commentedon Aug 30, 2023
Ah, whoops! I've made the payments on those. I think the easiest thing to do is to simply deduct from your next issue bounties. Do you have any in the works you can make a note on to reduce the amount due accordingly?
bernhardoj commentedon Aug 30, 2023
@trjExpensify I have one that is currently pending for payment #23420
trjExpensify commentedon Aug 30, 2023
Excellent, commented there.
jakub-trzebiatowski commentedon Aug 31, 2023
@trjExpensify Here: #25514
trjExpensify commentedon Aug 31, 2023
Thanks, commented!