You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] Web-Workspace-App does nothing on clicking on 3 dots when modal is open (modal closes for phone) #24284
Click on 3 dots, modal will be displayed, again click on 3 dots and observe that it does nothing
Visit any user report, click on phone icon in header, it will open modal, again click on phone icon and observe that it will close the modal
Similar working happens for all other modals like Actions, New, Emoji
Expected Result:
App should close the modal when we click on 3 dots again like it does for all other type of modals throughout the app
Actual Result:
App does nothing when we click on 3 dots again
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: v1.3.51-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
note: i am not sure if we should call onIconPress both on opening and closing. currently ThreeDotMenu is used in HeaderView (onIconPress is not defined using default prop - () => {})and function HeaderWithBackButton defined but still it is a default prop () => {}
changes for AddPaymentMethodMenu in payments page
add the following condition here
constpaymentMethodPressed=(nativeEvent,accountType,account,isDefault,methodID)=>{if(shouldShowAddPaymentMenu){setShouldShowAddPaymentMenu(false);return;}// rest of code
In BaseKYCWall add following changes: (wasn't able to test this properly i dont have beta access)
Sorry for not checking this myself but do you know what exact Betas you need?
I think we should probably add you to the specific Betas you need instead of enabling all : )
thanks @aimane-chnaif, just one question if i ask for permission for email@gmail.com. all test accounts (eg."email+abcd@gmail.com") got the permission right? or should i ask for all the test email accounts?
Aimane already answered this but yeah, I'm pretty sure it doesn't work like that and that the betas will only be applied to the account you specifically ask them for!
Thanks for your response @PauloGasparSv, can you add me to the betas that are required for testing of AddPaymentMethodMenu in BaseKYCWall and ButtonWithDropdownMenu.
Thanks for your response @PauloGasparSv, can you add me to the betas that are required for testing of AddPaymentMethodMenu in BaseKYCWall and ButtonWithDropdownMenu.
As mentioned on slack I have added your 3 accounts to the policyExpenseChat Beta!
Please note that Betas will usually take up to an hour to have an effect. So if this doesn't work let's wait a bit before checking if you need another Beta or something : D
External issue reporter - @dhanashree-sawant - $250 - OFFER SENT
Contributor that fixed the issue - @ishpaul777, $1500
Contributor+ that helped on the issue and/or PR - @aimane-chnaif $1500
🎉 Speed bonus to be given
Activity
melvin-bot commentedon Aug 8, 2023
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 8, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Aug 8, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 8, 2023
Triggered auto assignment to @PauloGasparSv (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.ishpaul777 commentedon Aug 8, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web-Workspace-App does nothing on clicking on 3 dots when modal is open
What is the root cause of that problem?
we are not closing the popover here only opening the popover usingthis.showPopoverMenu()on press of buttonThese are all non-toggle popovers and closing of the popovers not handeled :
What changes do you think we should make in order to solve the problem?
add the condition to close popover if
isPopupMenuVisibleistrue(popover is open) usingthis.hidePopoverMenu()note: i am not sure if we should call onIconPress both on opening and closing. currently ThreeDotMenu is used in HeaderView (
onIconPressis not defined using default prop -() => {})and function HeaderWithBackButton defined but still it is a default prop() => {}add the following condition here
In BaseKYCWall add following changes: (wasn't able to test this properly i dont have beta access)
48 remaining items
ishpaul777 commentedon Aug 16, 2023
okay thanks, and what are testing steps for AddPaymentMethodMenu in BaseKYCWall?
PauloGasparSv commentedon Aug 16, 2023
Hey @ishpaul777 I found the slack post where you requested access.
Sorry for not checking this myself but do you know what exact Betas you need?
I think we should probably add you to the specific Betas you need instead of enabling all : )
Aimane already answered this but yeah, I'm pretty sure it doesn't work like that and that the betas will only be applied to the account you specifically ask them for!
ishpaul777 commentedon Aug 16, 2023
Thanks for your response @PauloGasparSv, can you add me to the betas that are required for testing of AddPaymentMethodMenu in BaseKYCWall and ButtonWithDropdownMenu.
email - ishpaul207@gmail.com, ishpaul207+web@gmail.com, ishpaul207+native@gmail.com
PauloGasparSv commentedon Aug 16, 2023
Sure thing @ishpaul777!
As mentioned on slack I have added your 3 accounts to the
policyExpenseChatBeta!Please note that Betas will usually take up to an hour to have an effect. So if this doesn't work let's wait a bit before checking if you need another Beta or something : D
ishpaul777 commentedon Aug 16, 2023
I greatly appreciate your assistance, @PauloGasparSv. Could you kindly provide a response to #24284 (comment)
ishpaul777 commentedon Aug 16, 2023
@aimane-chnaif I tried to override the condition here https://github.com/Expensify/App/blob/043b1eded5eef81d06611df2891b0d6c793b42dd/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js#L290C1-L291C1
for testing AddPaymentMethodMenu in BaseKYCWall
Notice a weired positioning of AddPaymentMethodMenu.
No changes made other than
props.userWallet.currentBalance > -1https://www.loom.com/share/bb08c53218f44163a24fb1a39d23fae8?sid=46a8cc00-00b9-4545-876f-559454fffac6
melvin-bot commentedon Aug 18, 2023
🎯 ⚡️ Woah @aimane-chnaif / @ishpaul777, great job pushing this forwards! ⚡️
The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
On to the next one 🚀
slafortune commentedon Aug 22, 2023
External issue reporter - @dhanashree-sawant - $250 - OFFER SENT
Contributor that fixed the issue - @ishpaul777, $1500
Contributor+ that helped on the issue and/or PR - @aimane-chnaif $1500
🎉 Speed bonus to be given
slafortune commentedon Aug 28, 2023
Paid