Skip to content

[HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] BA - iOS App crashes if user tap ‘Back’ on the Onfido start screen Offline #24343

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Start iOS App
  2. Login with Expensifail account
  3. Go to existing or create new workspace
  4. Go to Workspace > Connect bank account
  5. Follow the flow for adding a VBA using the credentials [Company - Expensify, First name - First, Last name - Last] until you reach the Onfido screen
  6. Onfido first screen loads
  7. Go OFFline
  8. Go next screen
  9. User can’t go next from this 2nd screen offline
  10. Tap 'Back' 2 times while staying offline

Expected Result:

User should return to the Personal Information page

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.52.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6159354_T3575395-iOS-Onfido-Crash-Offline.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Aug 9, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 9, 2023

    @melvin-bot

    Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. tgolen commented on Aug 9, 2023

    @tgolen
    Contributor

    @lanitochka17 I see that you're able to reproduce it on iOS. Have you tried the same flow on other platforms and it's working on those platforms? Also, is this a brand new crash that hasn't been on previous versions of the app?

  4. lanitochka17 commented on Aug 9, 2023

    @lanitochka17
    Author

    Issue reproducible in only IOS

  5. situchan commented on Aug 9, 2023

    @situchan
    Contributor
  6. tgolen commented on Aug 10, 2023

    @tgolen
    Contributor

    @situchan Thank you for finding that! I agree, let's revert and have the code resubmitted with proper cross-platform support. Can you please take care of doing the revert?

  7. situchan commented on Aug 10, 2023

    @situchan
    Contributor

    @situchan Thank you for finding that! I agree, let's revert and have the code resubmitted with proper cross-platform support. Can you please take care of doing the revert?

    Sure I can do that

  8. situchan commented on Aug 10, 2023

    @situchan
    Contributor

    @tgolen PR is ready

  9. 13 remaining items

  10. situchan commented on Aug 14, 2023

    @situchan
    Contributor

    I am using upwork. As I am the PR author, I'd say this is worked externally so no "flat" concept. Also, I am not sure if this applies timeline rule.

  11. dylanexpensify commented on Aug 14, 2023

    @dylanexpensify
    Contributor

    Ah perfect, yes timeline applies and you hit it! Nice one! Please apply here!

  12. changed the title [-][HOLD for payment 2023-08-17] BA - iOS App crashes if user tap ‘Back’ on the Onfido start screen Offline[/-] [+][HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] BA - iOS App crashes if user tap ‘Back’ on the Onfido start screen Offline[/+] on Aug 14, 2023
  13. melvin-bot commented on Aug 14, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-21. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. melvin-bot commented on Aug 14, 2023

    @melvin-bot

    📣 @krkrishnaraj11! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  15. krkrishnaraj11 commented on Aug 14, 2023

    @krkrishnaraj11

    I have recreated the error issue in ios.
    There is an issue error "document" doesn't exist.
    Mostly due to api response and no network state

    Need to console and find the error

    Contributor details
    Your Expensify account email: krkrishnaraj11@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01bc44c7d52ff7f012

  16. melvin-bot commented on Aug 14, 2023

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  17. dylanexpensify commented on Aug 17, 2023

    @dylanexpensify
    Contributor

    @situchan bump on applying!

  18. situchan commented on Aug 17, 2023

    @situchan
    Contributor

    @dylanexpensify if possible, can you please invite me to the job or send offer?

  19. dylanexpensify commented on Aug 17, 2023

    @dylanexpensify
    Contributor

    Not a problem!

  20. dylanexpensify commented on Aug 17, 2023

    @dylanexpensify
    Contributor

    Sent!

  21. dylanexpensify commented on Aug 17, 2023

    @dylanexpensify
    Contributor

    offer sent!

  22. dylanexpensify commented on Aug 18, 2023

    @dylanexpensify
    Contributor

    payment sent! Thanks again @situchan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions