You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] BA - iOS App crashes if user tap ‘Back’ on the Onfido start screen Offline #24343
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@lanitochka17 I see that you're able to reproduce it on iOS. Have you tried the same flow on other platforms and it's working on those platforms? Also, is this a brand new crash that hasn't been on previous versions of the app?
@situchan Thank you for finding that! I agree, let's revert and have the code resubmitted with proper cross-platform support. Can you please take care of doing the revert?
@situchan Thank you for finding that! I agree, let's revert and have the code resubmitted with proper cross-platform support. Can you please take care of doing the revert?
changed the title [-][HOLD for payment 2023-08-17] BA - iOS App crashes if user tap ‘Back’ on the Onfido start screen Offline[/-][+][HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] BA - iOS App crashes if user tap ‘Back’ on the Onfido start screen Offline[/+]on Aug 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
📣 @krkrishnaraj11! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Activity
OSBotify commentedon Aug 9, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 9, 2023
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.tgolen commentedon Aug 9, 2023
@lanitochka17 I see that you're able to reproduce it on iOS. Have you tried the same flow on other platforms and it's working on those platforms? Also, is this a brand new crash that hasn't been on previous versions of the app?
lanitochka17 commentedon Aug 9, 2023
Issue reproducible in only IOS
situchan commentedon Aug 9, 2023
root cause: https://github.com/Expensify/App/pull/23864/files#r1289249208
I suggest to revert #23864
tgolen commentedon Aug 10, 2023
@situchan Thank you for finding that! I agree, let's revert and have the code resubmitted with proper cross-platform support. Can you please take care of doing the revert?
situchan commentedon Aug 10, 2023
Sure I can do that
situchan commentedon Aug 10, 2023
@tgolen PR is ready
13 remaining items
situchan commentedon Aug 14, 2023
I am using upwork. As I am the PR author, I'd say this is worked externally so no "flat" concept. Also, I am not sure if this applies timeline rule.
dylanexpensify commentedon Aug 14, 2023
Ah perfect, yes timeline applies and you hit it! Nice one! Please apply here!
[-][HOLD for payment 2023-08-17] BA - iOS App crashes if user tap ‘Back’ on the Onfido start screen Offline[/-][+][HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] BA - iOS App crashes if user tap ‘Back’ on the Onfido start screen Offline[/+]melvin-bot commentedon Aug 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Aug 14, 2023
📣 @krkrishnaraj11! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
krkrishnaraj11 commentedon Aug 14, 2023
I have recreated the error issue in ios.
There is an issue error "document" doesn't exist.
Mostly due to api response and no network state
Need to console and find the error
Contributor details
Your Expensify account email: krkrishnaraj11@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01bc44c7d52ff7f012
melvin-bot commentedon Aug 14, 2023
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
dylanexpensify commentedon Aug 17, 2023
@situchan bump on applying!
situchan commentedon Aug 17, 2023
@dylanexpensify if possible, can you please invite me to the job or send offer?
dylanexpensify commentedon Aug 17, 2023
Not a problem!
dylanexpensify commentedon Aug 17, 2023
Sent!
dylanexpensify commentedon Aug 17, 2023
offer sent!
dylanexpensify commentedon Aug 18, 2023
payment sent! Thanks again @situchan!