Skip to content

IOU - Comment in IOU report preview does not update after deleting money request #24365

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #23043

Action Performed:

  1. Go to staging.new.expensify.com
  2. Request money two times from a user with no conversation history
  3. Click on the IOU report preview
  4. Delete one of the requests
  5. Return to IOU report preview

Expected Result:

The comment in IOU report preview will update

Actual Result:

The comment in IOU report preview updates and reverts to '2 requests'

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.52.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @tewodrosGirmaA

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691168685718989

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d88723e84c14ed1f
  • Upwork Job ID: 1689633879427391488
  • Last Price Increase: 2023-08-10

Activity

  1. OSBotify commented on Aug 10, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 10, 2023

    @melvin-bot

    Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Aug 10, 2023
  4. melvin-bot commented on Aug 10, 2023

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    InternalRequires API changes or must be handled by Expensify staff
    on Aug 10, 2023
  6. melvin-bot commented on Aug 10, 2023

    @melvin-bot
  7. 43 remaining items

  8. joekaufmanexpensify commented on Oct 9, 2023

    @joekaufmanexpensify
    Contributor

    Same.

  9. joekaufmanexpensify commented on Oct 16, 2023

    @joekaufmanexpensify
    Contributor

    Same

  10. joekaufmanexpensify commented on Oct 23, 2023

    @joekaufmanexpensify
    Contributor

    Same

  11. joekaufmanexpensify commented on Oct 30, 2023

    @joekaufmanexpensify
    Contributor

    @Julesssss do you think you'll be able to raise the fix for this one anytime soon?

  12. Julesssss commented on Oct 30, 2023

    @Julesssss
    Contributor

    Sorry but no. All engineers are super busy with wave issues so I doubt this will be prioritized this year. Maybe we could get it looked at as a first pick, but we'd have to be pretty lucky.

  13. added
    FirstPickEngineering only, please! Only add when there is an identified code solution.
    on Oct 30, 2023
  14. joekaufmanexpensify commented on Oct 30, 2023

    @joekaufmanexpensify
    Contributor

    Okay, all good. I will make it a monthly for now then!

  15. Julesssss commented on Nov 17, 2023

    @Julesssss
    Contributor

    Hey @joekaufmanexpensify, I just retested this bug and I don't think it is occurring anymore 🎉

    I see an updated preview. Would you mind verifying?

    Screenshot 2023-11-17 at 16 33 13
    Screenshot 2023-11-17 at 16 33 01

  16. joekaufmanexpensify commented on Nov 17, 2023

    @joekaufmanexpensify
    Contributor

    Sure, I'll take a look now!

  17. joekaufmanexpensify commented on Nov 17, 2023

    @joekaufmanexpensify
    Contributor

    Yep, this is fixed for me as well. Closing as no action needed in this issue!

  18. tewodrosGirmaA commented on Nov 17, 2023

    @tewodrosGirmaA

    Hello @Julesssss and @joekaufmanexpensify, may I inquire about my eligibility for payment? The reported bug has been confirmed as valid and subsequently fixed by our engineer. Initially, it was a deploy blocker in the first stage.

  19. joekaufmanexpensify commented on Nov 17, 2023

    @joekaufmanexpensify
    Contributor

    @tewodrosGirmaA My initial thought is I don't think any payment is due here. We did not fix anything in this issue. Generally the way we approach situations like this is you'd need to find the PR that fixed this to show that your report came first in order for this to qualify for payment.

    If this was reported before whatever caused us to change this product behavior, LMK and I'll take another look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringFirstPickEngineering only, please! Only add when there is an identified code solution.MonthlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions