Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #24071
Action Performed:
- Request money from another user
- Tap the report preview (this will navigate you to the iou report)
- Hover the IOU preview and tap the thrash can icon
- Verify that a modal confirming if you want to delete the request shows up
- Tap Cancel and verify that the modal closes
- Repeat step 1-4 but this time tap Delete
- Verify that the request is deleted
- Request money again
- Tap the report preview (this will navigate you to the iou report)
- Tap the IOU preview (this will navigate you to the transaction thread report)
- Tap the three dot menu at the top right of the page and then Delete request
- Verify that the same confirmation modal shows up
- Tap Cancel and verify that the modal closes
- Tap the three dot menu at the top right of the page and then Delete request again
Expected Result:
Delete request confirmation modal displayed without any issues
Actual Result:
Screen flickering on tapping delete(Transition not smooth)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.53.1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6161591_RPReplay_Final1691777346.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~019298424ebc35a6e6
- Upwork Job ID: 1696029632941596672
- Last Price Increase: 2023-10-02
- Automatic offers:
- 0xmiroslav | Reviewer | 27008615
- ntdiary | Contributor | 27008616
- getusha | Contributor | 0
Issue Owner
Current Issue Owner: @kadiealexanderMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Aug 11, 2023
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 11, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)bernhardoj commentedon Aug 12, 2023
I think this can be handled in #13922
sophiepintoraetz commentedon Aug 14, 2023
Sounds good - closing this for now.
bernhardoj commentedon Aug 15, 2023
@sophiepintoraetz looks like it won't be handled in #13922. I think we can keep this open for now.
melvin-bot commentedon Aug 21, 2023
@sophiepintoraetz Eep! 4 days overdue now. Issues have feelings too...
sophiepintoraetz commentedon Aug 21, 2023
I need to find the time to reproduce this!
257 remaining items
getusha commentedon Jun 27, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@getusha] The PR that introduced the bug has been identified. Link to the PR: N/a This is an edge case and i don't think there is a specific PR that's responsible for this issue
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/a
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. Yes
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Do we agree 👍 or 👎
Julesssss commentedon Jun 27, 2024
Sorry @getusha I should have said earlier, but I don't think we need a specific regression test for this flickering.
getusha commentedon Jul 9, 2024
we can skip it since we had this issue happening several places. my reasoning was to just have one simpler test case to ensure it gets caught if any changes are made to the new focus manager.
getusha commentedon Jul 25, 2024
@kadiealexander friendly bump for payment on this one, i am not able to find the offer :)
kadiealexander commentedon Jul 26, 2024
Hey @getusha is this offer visible for you? https://www.upwork.com/nx/wm/offer/103274633
kadiealexander commentedon Jul 29, 2024
@getusha bump!
getusha commentedon Jul 30, 2024
@kadiealexander accepted the offer, thank you!