[HOLD for payment 2023-10-09] [$500] Update Task Report System Messages and LHN Display for Consistency

From https://expensify.slack.com/archives/C01GTK53T8Q/p1691602405412179

Currently in group chats the LHN preview when a task is created looks like:

which is confusing with the double colon. We should remove the one before the task title.

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01240ad1a87681ff41
Upwork Job ID: 1692247492479631360
Last Price Increase: 2023-09-19
Automatic offers:

rayane-djouah | Contributor | 26769074

@kevinksullivan

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kevinksullivan

@kevinksullivan I'm gonna handle this internally, it's very quick (and also requires some backend stuff)

Confirming expected behavior for the additional task messages (cancelled, completed, reopened). Will go from there.

(also note to self, changes have to be made in the App as well as in Auth)

Job added to Upwork: https://www.upwork.com/jobs/~01240ad1a87681ff41

The PR that introduced the bug has been identified. Link to the PR: this isn't a regression per se, just an update to system messages for tasks
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. N/A

@JmillsExpensify

Backend PR is up for review!

One question, I think for @JmillsExpensify - We previously had a (I guess not surfaced in the front end) system message for deleting a task, of "deleted task: " + taskTitle;. I updated that to just deleted, to match marked as complete and marked as incomplete. Does that feel right to you?

Missed this, but yeah that feels right.

Will get NewDot payments processed as soon as I have a payment summary.

@rayane-djouah

Payment summary

Contributor: @rayane-djouah $500
C+: @eVoloshchak $500 (in NewDot)

@eVoloshchak

$500 payment approved for @eVoloshchak based on BZ symmary.

@kevinksullivan

Upwork offer already accepted
@kevinksullivan

@kevinksullivan

Bump @kevinksullivan for processing payment

all set

@kevinksullivan

Since we're updating these system messages we'll need to update the existing regression tests so QA doesn't create issues from these changes - could we make sure that happens before closing this out please? cc @kevinksullivan

yup, done

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-09] [$500] Update Task Report System Messages and LHN Display for Consistency #24601

Bug0 Triage Checklist (Main S/O)

72 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-10-09] [$500] Update Task Report System Messages and LHN Display for Consistency #24601

Description

Activity

melvin-bot commented on Aug 15, 2023

melvin-bot commented on Aug 15, 2023

Bug0 Triage Checklist (Main S/O)

dangrous commented on Aug 15, 2023

dangrous commented on Aug 16, 2023

melvin-bot commented on Aug 17, 2023

72 remaining items

eVoloshchak commented on Oct 11, 2023

JmillsExpensify commented on Oct 11, 2023

JmillsExpensify commented on Oct 11, 2023

kevinksullivan commented on Oct 11, 2023

JmillsExpensify commented on Oct 11, 2023

rayane-d commented on Oct 11, 2023

rayane-d commented on Oct 13, 2023

kevinksullivan commented on Oct 13, 2023

thienlnam commented on Oct 16, 2023

kevinksullivan commented on Oct 17, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions