You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Clean up MapboxToken subscriptions when DistanceRequest unmounts #24612
As described here, we aren't cleaning up our Onxy.connect subscriptions, App state listener, and timeout from the MapboxToken library when the DistanceRequest component un-mounts. That's a bit of a waste.
Solution
Clean up when the DistanceRequest component un-mounts.
Activity
tgolen commentedon Aug 17, 2023
PR is up for this: #25408
tgolen commentedon Aug 17, 2023
Depending on the order of how things get merged...
If #24306 is merged first, then #25408 will need to be updated to tie into the
unmountof the DistanceRequest component.If #25408 is merged first, then #24306 will need to be updated to use
Mapbox.stop()hayata-suenaga commentedon Aug 17, 2023
#25408 has been merged first. Updating my PR to use the
stopmethod to cleanup listenersmelvin-bot commentedon Aug 25, 2023
@tgolen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
tgolen commentedon Aug 28, 2023
This is done and all deployed.